You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Raju Bairishetti <ra...@gmail.com> on 2015/12/30 00:50:05 UTC
Re: Review Request 39576: LENS-833 : Limit number of open sessions
per user on session service
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39576/
-----------------------------------------------------------
(Updated Dec. 29, 2015, 11:50 p.m.)
Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
Changes
-------
Add error code and synchonized the updates of session counts
Bugs: LENS-833
https://issues.apache.org/jira/browse/LENS-833
Repository: lens
Description
-------
Failing the open session operation if user creates more sessions than configured limit.
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/error/ErrorCollectionFactory.java 741630b
lens-api/src/main/resources/lens-errors.conf 06960a0
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 558e97f
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 43d0722
lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 32ed7b0
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 42c6bae
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 30f4ec1
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 448d0f6
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 9fce233
lens-cli/src/test/java/org/apache/lens/cli/TestLensLogResourceCommands.java f4b043e
lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java d453803
lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 8bccac2
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 88e5a01
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 0821fe7
lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java dc20f0f
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 3ba5edd
lens-server/src/main/resources/lensserver-default.xml cac641a
lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 75f21e1
lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java 8e22837
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java e0c0923
lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 69c3f46
lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 01e846a
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 3055ce5
lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java 6f7c216
lens-server/src/test/resources/lens-site.xml 9cb4a6f
src/site/apt/admin/config.apt 54f827e
Diff: https://reviews.apache.org/r/39576/diff/
Testing
-------
Thanks,
Raju Bairishetti
Re: Review Request 39576: LENS-833 : Limit number of open sessions
per user on session service
Posted by Raju Bairishetti <ra...@gmail.com>.
> On Jan. 18, 2016, 5:36 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java, line 125
> > <https://reviews.apache.org/r/39576/diff/7/?file=1195612#file1195612line125>
> >
> > set for debugging?
Yes, added for debugging. Will remove it.
> On Jan. 18, 2016, 5:36 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java, line 549
> > <https://reviews.apache.org/r/39576/diff/7/?file=1195620#file1195620line549>
> >
> > mp not used ?
Yes, not using *mp* now as I am using newly added RestAPITestUtil class for opening and closing sessions.
> On Jan. 18, 2016, 5:36 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/error/LensHttpStatus.java, line 25
> > <https://reviews.apache.org/r/39576/diff/7/?file=1195593#file1195593line25>
> >
> > Did not like the fact we are doing a copy of Response.Status. We should be see if there is anyother way to achieve this.
Completely Agree. Any changes in Response.Status will always need a modification in LensHttpSttaus class as well. But did not find any other alternative. Jersy Response class is tightly coupled like **Status** is **enum**. Can not extend **Status** for using the existing Status class for building LensHttpStatus.
- Raju
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39576/#review114953
-----------------------------------------------------------
On Jan. 13, 2016, 12:11 p.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39576/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2016, 12:11 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
>
>
> Bugs: LENS-833
> https://issues.apache.org/jira/browse/LENS-833
>
>
> Repository: lens
>
>
> Description
> -------
>
> Failing the open session operation if user creates more sessions than configured limit.
>
> Created LensHttpStatus for adding new status codes in the Response class. Both Status from Response class and LensHttpStatus implements StatusType interface.
> Changed teh parameter type to StatusType to make it generic
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/ErrorCollectionFactory.java 741630b
> lens-api/src/main/java/org/apache/lens/api/error/LensError.java 1cb7409
> lens-api/src/main/java/org/apache/lens/api/error/LensHttpStatus.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/result/LensAPIResult.java 238f9e6
> lens-api/src/main/resources/lens-errors.conf 9087fcd
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 558e97f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 43d0722
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 32ed7b0
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 160699b
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 30f4ec1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 448d0f6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 9fce233
> lens-cli/src/test/java/org/apache/lens/cli/TestLensLogResourceCommands.java f4b043e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java e5f11f2
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 8bccac2
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java a3dbfc0
> lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java a1ffeb6
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 0821fe7
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java dc20f0f
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 3ba5edd
> lens-server/src/main/resources/lensserver-default.xml cac641a
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 8f52ddd
> lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 75f21e1
> lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java 8e22837
> lens-server/src/test/java/org/apache/lens/server/common/ErrorResponseExpectedData.java 4d4f137
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 925fc86
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 6f8886c
> lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 01e846a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java c5d75de
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 3055ce5
> lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java 6f7c216
> lens-server/src/test/resources/lens-site.xml 9cb4a6f
> src/site/apt/admin/config.apt 54f827e
> src/site/apt/admin/session-config.apt 05a2c2c
>
> Diff: https://reviews.apache.org/r/39576/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 39576: LENS-833 : Limit number of open sessions
per user on session service
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39576/#review114953
-----------------------------------------------------------
lens-api/src/main/java/org/apache/lens/api/error/LensHttpStatus.java (line 25)
<https://reviews.apache.org/r/39576/#comment175787>
Did not like the fact we are doing a copy of Response.Status. We should be see if there is anyother way to achieve this.
lens-server/src/main/resources/lensserver-default.xml (line 812)
<https://reviews.apache.org/r/39576/#comment175788>
Please document what happens if it exceeds.
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java (line 125)
<https://reviews.apache.org/r/39576/#comment175789>
set for debugging?
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java (line 547)
<https://reviews.apache.org/r/39576/#comment175790>
mp not used ?
- Amareshwari Sriramadasu
On Jan. 13, 2016, 12:11 p.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39576/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2016, 12:11 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
>
>
> Bugs: LENS-833
> https://issues.apache.org/jira/browse/LENS-833
>
>
> Repository: lens
>
>
> Description
> -------
>
> Failing the open session operation if user creates more sessions than configured limit.
>
> Created LensHttpStatus for adding new status codes in the Response class. Both Status from Response class and LensHttpStatus implements StatusType interface.
> Changed teh parameter type to StatusType to make it generic
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/ErrorCollectionFactory.java 741630b
> lens-api/src/main/java/org/apache/lens/api/error/LensError.java 1cb7409
> lens-api/src/main/java/org/apache/lens/api/error/LensHttpStatus.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/result/LensAPIResult.java 238f9e6
> lens-api/src/main/resources/lens-errors.conf 9087fcd
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 558e97f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 43d0722
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 32ed7b0
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 160699b
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 30f4ec1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 448d0f6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 9fce233
> lens-cli/src/test/java/org/apache/lens/cli/TestLensLogResourceCommands.java f4b043e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java e5f11f2
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 8bccac2
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java a3dbfc0
> lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java a1ffeb6
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 0821fe7
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java dc20f0f
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 3ba5edd
> lens-server/src/main/resources/lensserver-default.xml cac641a
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 8f52ddd
> lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 75f21e1
> lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java 8e22837
> lens-server/src/test/java/org/apache/lens/server/common/ErrorResponseExpectedData.java 4d4f137
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 925fc86
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 6f8886c
> lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 01e846a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java c5d75de
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 3055ce5
> lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java 6f7c216
> lens-server/src/test/resources/lens-site.xml 9cb4a6f
> src/site/apt/admin/config.apt 54f827e
> src/site/apt/admin/session-config.apt 05a2c2c
>
> Diff: https://reviews.apache.org/r/39576/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 39576: LENS-833 : Limit number of open sessions
per user on session service
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39576/#review121094
-----------------------------------------------------------
Over all changes look fine to me. Can you update to master and run tests?
- Amareshwari Sriramadasu
On Feb. 23, 2016, 2:38 p.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39576/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2016, 2:38 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
>
>
> Bugs: LENS-833
> https://issues.apache.org/jira/browse/LENS-833
>
>
> Repository: lens
>
>
> Description
> -------
>
> Failing the open session operation if user creates more sessions than configured limit.
>
> Created LensHttpStatus for adding new status codes in the Response class. Both Status from Response class and LensHttpStatus implements StatusType interface.
> Changed teh parameter type to StatusType to make it generic
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/ErrorCollectionFactory.java 741630b
> lens-api/src/main/java/org/apache/lens/api/error/LensError.java 1cb7409
> lens-api/src/main/java/org/apache/lens/api/error/LensHttpStatus.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/result/LensAPIResult.java 238f9e6
> lens-api/src/main/resources/lens-errors.conf 9087fcd
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 558e97f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 43d0722
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 32ed7b0
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 160699b
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 30f4ec1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 448d0f6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 9fce233
> lens-cli/src/test/java/org/apache/lens/cli/TestLensLogResourceCommands.java f4b043e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java e5f11f2
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 8bccac2
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java a3dbfc0
> lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java a1ffeb6
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 0821fe7
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java dc20f0f
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 3ba5edd
> lens-server/src/main/resources/lensserver-default.xml cac641a
> lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 75f21e1
> lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java 8e22837
> lens-server/src/test/java/org/apache/lens/server/common/ErrorResponseExpectedData.java 4d4f137
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 925fc86
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 6f8886c
> lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 01e846a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java c5d75de
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 3055ce5
> lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java 6f7c216
> lens-server/src/test/resources/lens-site.xml 9cb4a6f
> src/site/apt/admin/config.apt 54f827e
> src/site/apt/admin/session-config.apt 05a2c2c
>
> Diff: https://reviews.apache.org/r/39576/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 39576: LENS-833 : Limit number of open sessions
per user on session service
Posted by Raju Bairishetti <ra...@gmail.com>.
> On Feb. 24, 2016, 2:34 p.m., Puneet Gupta wrote:
> > lens-api/src/main/java/org/apache/lens/api/error/ErrorCollectionFactory.java, lines 67-69
> > <https://reviews.apache.org/r/39576/diff/8-9/?file=1203168#file1203168line67>
> >
> > should we move this part inside method LensHttpStatus.fromStatusCode?
> >
> > Then all users (right now only one) of LensHttpStatus can use it without worrying about whether to fetch it form Response.Status or LensHttpStatus.
Actually user does not need to implement this code at any time. He just need to pass the config files.
Moving this part to LensHttpStatus.
- Raju
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39576/#review120504
-----------------------------------------------------------
On Feb. 23, 2016, 2:38 p.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39576/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2016, 2:38 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
>
>
> Bugs: LENS-833
> https://issues.apache.org/jira/browse/LENS-833
>
>
> Repository: lens
>
>
> Description
> -------
>
> Failing the open session operation if user creates more sessions than configured limit.
>
> Created LensHttpStatus for adding new status codes in the Response class. Both Status from Response class and LensHttpStatus implements StatusType interface.
> Changed teh parameter type to StatusType to make it generic
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/ErrorCollectionFactory.java 741630b
> lens-api/src/main/java/org/apache/lens/api/error/LensError.java 1cb7409
> lens-api/src/main/java/org/apache/lens/api/error/LensHttpStatus.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/result/LensAPIResult.java 238f9e6
> lens-api/src/main/resources/lens-errors.conf 9087fcd
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 558e97f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 43d0722
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 32ed7b0
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 160699b
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 30f4ec1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 448d0f6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 9fce233
> lens-cli/src/test/java/org/apache/lens/cli/TestLensLogResourceCommands.java f4b043e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java e5f11f2
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 8bccac2
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java a3dbfc0
> lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java a1ffeb6
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 0821fe7
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java dc20f0f
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 3ba5edd
> lens-server/src/main/resources/lensserver-default.xml cac641a
> lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 75f21e1
> lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java 8e22837
> lens-server/src/test/java/org/apache/lens/server/common/ErrorResponseExpectedData.java 4d4f137
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 925fc86
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 6f8886c
> lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 01e846a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java c5d75de
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 3055ce5
> lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java 6f7c216
> lens-server/src/test/resources/lens-site.xml 9cb4a6f
> src/site/apt/admin/config.apt 54f827e
> src/site/apt/admin/session-config.apt 05a2c2c
>
> Diff: https://reviews.apache.org/r/39576/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 39576: LENS-833 : Limit number of open sessions
per user on session service
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39576/#review120504
-----------------------------------------------------------
lens-api/src/main/java/org/apache/lens/api/error/ErrorCollectionFactory.java (lines 67 - 69)
<https://reviews.apache.org/r/39576/#comment181973>
should we move this part inside method LensHttpStatus.fromStatusCode?
Then all users (right now only one) of LensHttpStatus can use it without worrying about whether to fetch it form Response.Status or LensHttpStatus.
- Puneet Gupta
On Feb. 23, 2016, 2:38 p.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39576/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2016, 2:38 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
>
>
> Bugs: LENS-833
> https://issues.apache.org/jira/browse/LENS-833
>
>
> Repository: lens
>
>
> Description
> -------
>
> Failing the open session operation if user creates more sessions than configured limit.
>
> Created LensHttpStatus for adding new status codes in the Response class. Both Status from Response class and LensHttpStatus implements StatusType interface.
> Changed teh parameter type to StatusType to make it generic
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/ErrorCollectionFactory.java 741630b
> lens-api/src/main/java/org/apache/lens/api/error/LensError.java 1cb7409
> lens-api/src/main/java/org/apache/lens/api/error/LensHttpStatus.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/result/LensAPIResult.java 238f9e6
> lens-api/src/main/resources/lens-errors.conf 9087fcd
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 558e97f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 43d0722
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 32ed7b0
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 160699b
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 30f4ec1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 448d0f6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 9fce233
> lens-cli/src/test/java/org/apache/lens/cli/TestLensLogResourceCommands.java f4b043e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java e5f11f2
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 8bccac2
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java a3dbfc0
> lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java a1ffeb6
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 0821fe7
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java dc20f0f
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 3ba5edd
> lens-server/src/main/resources/lensserver-default.xml cac641a
> lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 75f21e1
> lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java 8e22837
> lens-server/src/test/java/org/apache/lens/server/common/ErrorResponseExpectedData.java 4d4f137
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 925fc86
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 6f8886c
> lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 01e846a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java c5d75de
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 3055ce5
> lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java 6f7c216
> lens-server/src/test/resources/lens-site.xml 9cb4a6f
> src/site/apt/admin/config.apt 54f827e
> src/site/apt/admin/session-config.apt 05a2c2c
>
> Diff: https://reviews.apache.org/r/39576/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 39576: LENS-833 : Limit number of open sessions
per user on session service
Posted by Raju Bairishetti <ra...@gmail.com>.
> On Feb. 29, 2016, 12:44 p.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java, line 218
> > <https://reviews.apache.org/r/39576/diff/10/?file=1273670#file1273670line218>
> >
> > Seems the update is not happening upon restore. We need to take care of that as well.
We are already handling this case.
public void restoreSession(...) {
try {
...
updateSessionsPerUser(userName);
} catch (HiveSQLException e) {
throw new LensException("Error restoring session " + sessionHandle, e);
}
}
- Raju
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39576/#review121233
-----------------------------------------------------------
On Feb. 29, 2016, 11:10 p.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39576/
> -----------------------------------------------------------
>
> (Updated Feb. 29, 2016, 11:10 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
>
>
> Bugs: LENS-833
> https://issues.apache.org/jira/browse/LENS-833
>
>
> Repository: lens
>
>
> Description
> -------
>
> Failing the open session operation if user creates more sessions than configured limit.
>
> Created LensHttpStatus for adding new status codes in the Response class. Both Status from Response class and LensHttpStatus implements StatusType interface.
> Changed teh parameter type to StatusType to make it generic
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/ErrorCollectionFactory.java 741630b
> lens-api/src/main/java/org/apache/lens/api/error/LensError.java 1cb7409
> lens-api/src/main/java/org/apache/lens/api/error/LensHttpStatus.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/result/LensAPIResult.java 238f9e6
> lens-api/src/main/resources/lens-errors.conf 09b221f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 558e97f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 97ca2c8
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 32ed7b0
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 45555f4
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java bea128b
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 1454e5f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 9fce233
> lens-cli/src/test/java/org/apache/lens/cli/TestLensLogResourceCommands.java f4b043e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java e5f11f2
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java a178296
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 1b7d0f9
> lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java a1ffeb6
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 0821fe7
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java dc20f0f
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java ac77418
> lens-server/src/main/resources/lensserver-default.xml a711d03
> lens-server/src/test/java/org/apache/lens/server/TestServerMode.java caf968a
> lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java 8e22837
> lens-server/src/test/java/org/apache/lens/server/common/ErrorResponseExpectedData.java 4d4f137
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java a541e9b
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 30f7aff
> lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java a5ee5cc
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java bde7b9b
> lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java be87e65
> lens-server/src/test/resources/lens-site.xml c3187a8
> src/site/apt/admin/config.apt fb15d83
>
> Diff: https://reviews.apache.org/r/39576/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.737s]
> [INFO] Lens .............................................. SUCCESS [3.140s]
> [INFO] Lens API .......................................... SUCCESS [22.188s]
> [INFO] Lens API for server and extensions ................ SUCCESS [16.051s]
> [INFO] Lens Cube ......................................... SUCCESS [9:34.494s]
> [INFO] Lens DB storage ................................... SUCCESS [17.660s]
> [INFO] Lens Query Library ................................ SUCCESS [19.226s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:55.805s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [49.269s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [23.175s]
> [INFO] Lens Server ....................................... SUCCESS [20:34.425s]
> [INFO] Lens client ....................................... SUCCESS [30.663s]
> [INFO] Lens CLI .......................................... SUCCESS [47.568s]
> [INFO] Lens Examples ..................................... SUCCESS [11.947s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.749s]
> [INFO] Lens Distribution ................................. SUCCESS [8.793s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:10.207s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.813s]
> [INFO] Lens Regression ................................... SUCCESS [13.033s]
> [INFO] Lens UI ........................................... SUCCESS [0.157s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 38:42.684s
> [INFO] Finished at: Tue Mar 01 01:47:10 SGT 2016
> [INFO] Final Memory: 185M/1085M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 39576: LENS-833 : Limit number of open sessions
per user on session service
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39576/#review121233
-----------------------------------------------------------
lens-api/src/main/java/org/apache/lens/api/result/LensAPIResult.java (line 71)
<https://reviews.apache.org/r/39576/#comment182917>
Let us not change the API passing DATA. Only change the API wrt LensErrorTO
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java (line 217)
<https://reviews.apache.org/r/39576/#comment182918>
Seems the update is not happening upon restore. We need to take care of that as well.
- Amareshwari Sriramadasu
On Feb. 28, 2016, 11:43 p.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39576/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2016, 11:43 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
>
>
> Bugs: LENS-833
> https://issues.apache.org/jira/browse/LENS-833
>
>
> Repository: lens
>
>
> Description
> -------
>
> Failing the open session operation if user creates more sessions than configured limit.
>
> Created LensHttpStatus for adding new status codes in the Response class. Both Status from Response class and LensHttpStatus implements StatusType interface.
> Changed teh parameter type to StatusType to make it generic
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/ErrorCollectionFactory.java 741630b
> lens-api/src/main/java/org/apache/lens/api/error/LensError.java 1cb7409
> lens-api/src/main/java/org/apache/lens/api/error/LensHttpStatus.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/result/LensAPIResult.java 238f9e6
> lens-api/src/main/resources/lens-errors.conf 09b221f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 558e97f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 97ca2c8
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 32ed7b0
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 45555f4
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java bea128b
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 1454e5f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 9fce233
> lens-cli/src/test/java/org/apache/lens/cli/TestLensLogResourceCommands.java f4b043e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java e5f11f2
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java a178296
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 1b7d0f9
> lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java a1ffeb6
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 0821fe7
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java dc20f0f
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java ac77418
> lens-server/src/main/resources/lensserver-default.xml a711d03
> lens-server/src/test/java/org/apache/lens/server/TestServerMode.java caf968a
> lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java 8e22837
> lens-server/src/test/java/org/apache/lens/server/common/ErrorResponseExpectedData.java 4d4f137
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java a541e9b
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 30f7aff
> lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java a5ee5cc
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 699fa68
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java bde7b9b
> lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java be87e65
> lens-server/src/test/resources/lens-site.xml c3187a8
> src/site/apt/admin/config.apt fb15d83
>
> Diff: https://reviews.apache.org/r/39576/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 39576: LENS-833 : Limit number of open sessions
per user on session service
Posted by Raju Bairishetti <ra...@gmail.com>.
> On Feb. 29, 2016, 4:15 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java, line 318
> > <https://reviews.apache.org/r/39576/diff/10/?file=1273670#file1273670line318>
> >
> > Shouldnt we remove from map when count reaches zero?
>
> Raju Bairishetti wrote:
> This code can not be reachable when there are no active sessions for that user. closeSession will throw an exception if user is trying to a session which is not exists.
>
> Count zero here indicates that there are no active sessions.
>
> Amareshwari Sriramadasu wrote:
> I feel when the last session is closed, we should remove it from this map as well.
>
> Also, how is this map reconstucted upon restart. Will check code anyways.
Agree, we should remove entry from the map when the last session is closed.
Map will be updated on every session restore, open and close.
- Raju
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39576/#review121185
-----------------------------------------------------------
On Feb. 29, 2016, 11:10 p.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39576/
> -----------------------------------------------------------
>
> (Updated Feb. 29, 2016, 11:10 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
>
>
> Bugs: LENS-833
> https://issues.apache.org/jira/browse/LENS-833
>
>
> Repository: lens
>
>
> Description
> -------
>
> Failing the open session operation if user creates more sessions than configured limit.
>
> Created LensHttpStatus for adding new status codes in the Response class. Both Status from Response class and LensHttpStatus implements StatusType interface.
> Changed teh parameter type to StatusType to make it generic
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/ErrorCollectionFactory.java 741630b
> lens-api/src/main/java/org/apache/lens/api/error/LensError.java 1cb7409
> lens-api/src/main/java/org/apache/lens/api/error/LensHttpStatus.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/result/LensAPIResult.java 238f9e6
> lens-api/src/main/resources/lens-errors.conf 09b221f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 558e97f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 97ca2c8
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 32ed7b0
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 45555f4
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java bea128b
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 1454e5f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 9fce233
> lens-cli/src/test/java/org/apache/lens/cli/TestLensLogResourceCommands.java f4b043e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java e5f11f2
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java a178296
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 1b7d0f9
> lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java a1ffeb6
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 0821fe7
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java dc20f0f
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java ac77418
> lens-server/src/main/resources/lensserver-default.xml a711d03
> lens-server/src/test/java/org/apache/lens/server/TestServerMode.java caf968a
> lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java 8e22837
> lens-server/src/test/java/org/apache/lens/server/common/ErrorResponseExpectedData.java 4d4f137
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java a541e9b
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 30f7aff
> lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java a5ee5cc
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java bde7b9b
> lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java be87e65
> lens-server/src/test/resources/lens-site.xml c3187a8
> src/site/apt/admin/config.apt fb15d83
>
> Diff: https://reviews.apache.org/r/39576/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.737s]
> [INFO] Lens .............................................. SUCCESS [3.140s]
> [INFO] Lens API .......................................... SUCCESS [22.188s]
> [INFO] Lens API for server and extensions ................ SUCCESS [16.051s]
> [INFO] Lens Cube ......................................... SUCCESS [9:34.494s]
> [INFO] Lens DB storage ................................... SUCCESS [17.660s]
> [INFO] Lens Query Library ................................ SUCCESS [19.226s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:55.805s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [49.269s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [23.175s]
> [INFO] Lens Server ....................................... SUCCESS [20:34.425s]
> [INFO] Lens client ....................................... SUCCESS [30.663s]
> [INFO] Lens CLI .......................................... SUCCESS [47.568s]
> [INFO] Lens Examples ..................................... SUCCESS [11.947s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.749s]
> [INFO] Lens Distribution ................................. SUCCESS [8.793s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:10.207s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.813s]
> [INFO] Lens Regression ................................... SUCCESS [13.033s]
> [INFO] Lens UI ........................................... SUCCESS [0.157s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 38:42.684s
> [INFO] Finished at: Tue Mar 01 01:47:10 SGT 2016
> [INFO] Final Memory: 185M/1085M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 39576: LENS-833 : Limit number of open sessions
per user on session service
Posted by Raju Bairishetti <ra...@gmail.com>.
> On Feb. 29, 2016, 4:15 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/test/java/org/apache/lens/server/common/ErrorResponseExpectedData.java, line 51
> > <https://reviews.apache.org/r/39576/diff/10/?file=1273676#file1273676line51>
> >
> > Error wont not be coming in Data. Why is this change done?
>
> Raju Bairishetti wrote:
> LensErrorTO is coming as part of Data with my changes.
>
> I had seen some issues with LensAPIResult composedOf invocations.
>
> LensAPIResult.java:
> **Before/After the changes the follwoing method was invoked from other methods:**
>
> public static <DATA> LensAPIResult<DATA> composedOf(final String apiVersion,
> final String id, @NonNull final DATA data, @NonNull final Response.StatusType httpStatusCode) {
>
> return new LensAPIResult<>(apiVersion, id, data, null, httpStatusCode);
> }
>
>
> **After/Before StatusType changes this method getting called:**
>
> public static LensAPIResult<NoResultData> composedOf(
> final String apiVersion, final String id, @NonNull final LensErrorTO lensErrorTO,
> @NonNull final Status httpStatusCode) {
>
> return new LensAPIResult<>(apiVersion, id, null, lensErrorTO, httpStatusCode);
> }
>
>
> Did not remember properly. I will check it now.
>
> Amareshwari Sriramadasu wrote:
> Seems the following is not changed to take Response.StatusType, which caused this issue.
> public static LensAPIResult<NoResultData> composedOf(
> final String apiVersion, final String id, @NonNull final LensErrorTO lensErrorTO,
> @NonNull final Status httpStatusCode) {
Thanks @Amareshwari, yes that fixed the issue. Will revert the changes in test cases.
- Raju
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39576/#review121185
-----------------------------------------------------------
On Feb. 28, 2016, 11:43 p.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39576/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2016, 11:43 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
>
>
> Bugs: LENS-833
> https://issues.apache.org/jira/browse/LENS-833
>
>
> Repository: lens
>
>
> Description
> -------
>
> Failing the open session operation if user creates more sessions than configured limit.
>
> Created LensHttpStatus for adding new status codes in the Response class. Both Status from Response class and LensHttpStatus implements StatusType interface.
> Changed teh parameter type to StatusType to make it generic
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/ErrorCollectionFactory.java 741630b
> lens-api/src/main/java/org/apache/lens/api/error/LensError.java 1cb7409
> lens-api/src/main/java/org/apache/lens/api/error/LensHttpStatus.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/result/LensAPIResult.java 238f9e6
> lens-api/src/main/resources/lens-errors.conf 09b221f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 558e97f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 97ca2c8
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 32ed7b0
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 45555f4
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java bea128b
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 1454e5f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 9fce233
> lens-cli/src/test/java/org/apache/lens/cli/TestLensLogResourceCommands.java f4b043e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java e5f11f2
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java a178296
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 1b7d0f9
> lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java a1ffeb6
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 0821fe7
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java dc20f0f
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java ac77418
> lens-server/src/main/resources/lensserver-default.xml a711d03
> lens-server/src/test/java/org/apache/lens/server/TestServerMode.java caf968a
> lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java 8e22837
> lens-server/src/test/java/org/apache/lens/server/common/ErrorResponseExpectedData.java 4d4f137
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java a541e9b
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 30f7aff
> lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java a5ee5cc
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 699fa68
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java bde7b9b
> lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java be87e65
> lens-server/src/test/resources/lens-site.xml c3187a8
> src/site/apt/admin/config.apt fb15d83
>
> Diff: https://reviews.apache.org/r/39576/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 39576: LENS-833 : Limit number of open sessions
per user on session service
Posted by Raju Bairishetti <ra...@gmail.com>.
> On Feb. 29, 2016, 4:15 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java, line 318
> > <https://reviews.apache.org/r/39576/diff/10/?file=1273670#file1273670line318>
> >
> > Shouldnt we remove from map when count reaches zero?
This code can not be reachable when there are no active sessions for that user. closeSession will throw an exception if user is trying to a session which is not exists.
Count zero here indicates that there are no active sessions.
> On Feb. 29, 2016, 4:15 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/test/java/org/apache/lens/server/common/ErrorResponseExpectedData.java, line 51
> > <https://reviews.apache.org/r/39576/diff/10/?file=1273676#file1273676line51>
> >
> > Error wont not be coming in Data. Why is this change done?
LensErrorTO is coming as part of Data with my changes.
I had seen some issues with LensAPIResult composedOf invocations.
LensAPIResult.java:
**Before/After the changes the follwoing method was invoked from other methods:**
public static <DATA> LensAPIResult<DATA> composedOf(final String apiVersion,
final String id, @NonNull final DATA data, @NonNull final Response.StatusType httpStatusCode) {
return new LensAPIResult<>(apiVersion, id, data, null, httpStatusCode);
}
**After/Before StatusType changes this method getting called:**
public static LensAPIResult<NoResultData> composedOf(
final String apiVersion, final String id, @NonNull final LensErrorTO lensErrorTO,
@NonNull final Status httpStatusCode) {
return new LensAPIResult<>(apiVersion, id, null, lensErrorTO, httpStatusCode);
}
Did not remember properly. I will check it now.
- Raju
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39576/#review121185
-----------------------------------------------------------
On Feb. 28, 2016, 11:43 p.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39576/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2016, 11:43 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
>
>
> Bugs: LENS-833
> https://issues.apache.org/jira/browse/LENS-833
>
>
> Repository: lens
>
>
> Description
> -------
>
> Failing the open session operation if user creates more sessions than configured limit.
>
> Created LensHttpStatus for adding new status codes in the Response class. Both Status from Response class and LensHttpStatus implements StatusType interface.
> Changed teh parameter type to StatusType to make it generic
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/ErrorCollectionFactory.java 741630b
> lens-api/src/main/java/org/apache/lens/api/error/LensError.java 1cb7409
> lens-api/src/main/java/org/apache/lens/api/error/LensHttpStatus.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/result/LensAPIResult.java 238f9e6
> lens-api/src/main/resources/lens-errors.conf 09b221f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 558e97f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 97ca2c8
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 32ed7b0
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 45555f4
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java bea128b
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 1454e5f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 9fce233
> lens-cli/src/test/java/org/apache/lens/cli/TestLensLogResourceCommands.java f4b043e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java e5f11f2
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java a178296
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 1b7d0f9
> lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java a1ffeb6
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 0821fe7
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java dc20f0f
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java ac77418
> lens-server/src/main/resources/lensserver-default.xml a711d03
> lens-server/src/test/java/org/apache/lens/server/TestServerMode.java caf968a
> lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java 8e22837
> lens-server/src/test/java/org/apache/lens/server/common/ErrorResponseExpectedData.java 4d4f137
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java a541e9b
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 30f7aff
> lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java a5ee5cc
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 699fa68
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java bde7b9b
> lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java be87e65
> lens-server/src/test/resources/lens-site.xml c3187a8
> src/site/apt/admin/config.apt fb15d83
>
> Diff: https://reviews.apache.org/r/39576/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 39576: LENS-833 : Limit number of open sessions
per user on session service
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Feb. 29, 2016, 4:15 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/test/java/org/apache/lens/server/common/ErrorResponseExpectedData.java, line 51
> > <https://reviews.apache.org/r/39576/diff/10/?file=1273676#file1273676line51>
> >
> > Error wont not be coming in Data. Why is this change done?
>
> Raju Bairishetti wrote:
> LensErrorTO is coming as part of Data with my changes.
>
> I had seen some issues with LensAPIResult composedOf invocations.
>
> LensAPIResult.java:
> **Before/After the changes the follwoing method was invoked from other methods:**
>
> public static <DATA> LensAPIResult<DATA> composedOf(final String apiVersion,
> final String id, @NonNull final DATA data, @NonNull final Response.StatusType httpStatusCode) {
>
> return new LensAPIResult<>(apiVersion, id, data, null, httpStatusCode);
> }
>
>
> **After/Before StatusType changes this method getting called:**
>
> public static LensAPIResult<NoResultData> composedOf(
> final String apiVersion, final String id, @NonNull final LensErrorTO lensErrorTO,
> @NonNull final Status httpStatusCode) {
>
> return new LensAPIResult<>(apiVersion, id, null, lensErrorTO, httpStatusCode);
> }
>
>
> Did not remember properly. I will check it now.
Seems the following is not changed to take Response.StatusType, which caused this issue.
public static LensAPIResult<NoResultData> composedOf(
final String apiVersion, final String id, @NonNull final LensErrorTO lensErrorTO,
@NonNull final Status httpStatusCode) {
> On Feb. 29, 2016, 4:15 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java, line 318
> > <https://reviews.apache.org/r/39576/diff/10/?file=1273670#file1273670line318>
> >
> > Shouldnt we remove from map when count reaches zero?
>
> Raju Bairishetti wrote:
> This code can not be reachable when there are no active sessions for that user. closeSession will throw an exception if user is trying to a session which is not exists.
>
> Count zero here indicates that there are no active sessions.
I feel when the last session is closed, we should remove it from this map as well.
Also, how is this map reconstucted upon restart. Will check code anyways.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39576/#review121185
-----------------------------------------------------------
On Feb. 28, 2016, 11:43 p.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39576/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2016, 11:43 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
>
>
> Bugs: LENS-833
> https://issues.apache.org/jira/browse/LENS-833
>
>
> Repository: lens
>
>
> Description
> -------
>
> Failing the open session operation if user creates more sessions than configured limit.
>
> Created LensHttpStatus for adding new status codes in the Response class. Both Status from Response class and LensHttpStatus implements StatusType interface.
> Changed teh parameter type to StatusType to make it generic
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/ErrorCollectionFactory.java 741630b
> lens-api/src/main/java/org/apache/lens/api/error/LensError.java 1cb7409
> lens-api/src/main/java/org/apache/lens/api/error/LensHttpStatus.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/result/LensAPIResult.java 238f9e6
> lens-api/src/main/resources/lens-errors.conf 09b221f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 558e97f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 97ca2c8
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 32ed7b0
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 45555f4
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java bea128b
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 1454e5f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 9fce233
> lens-cli/src/test/java/org/apache/lens/cli/TestLensLogResourceCommands.java f4b043e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java e5f11f2
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java a178296
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 1b7d0f9
> lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java a1ffeb6
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 0821fe7
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java dc20f0f
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java ac77418
> lens-server/src/main/resources/lensserver-default.xml a711d03
> lens-server/src/test/java/org/apache/lens/server/TestServerMode.java caf968a
> lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java 8e22837
> lens-server/src/test/java/org/apache/lens/server/common/ErrorResponseExpectedData.java 4d4f137
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java a541e9b
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 30f7aff
> lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java a5ee5cc
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 699fa68
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java bde7b9b
> lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java be87e65
> lens-server/src/test/resources/lens-site.xml c3187a8
> src/site/apt/admin/config.apt fb15d83
>
> Diff: https://reviews.apache.org/r/39576/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 39576: LENS-833 : Limit number of open sessions
per user on session service
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39576/#review121185
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java (line 317)
<https://reviews.apache.org/r/39576/#comment182847>
Shouldnt we remove from map when count reaches zero?
lens-server/src/test/java/org/apache/lens/server/common/ErrorResponseExpectedData.java (line 51)
<https://reviews.apache.org/r/39576/#comment182848>
Error wont not be coming in Data. Why is this change done?
- Amareshwari Sriramadasu
On Feb. 28, 2016, 11:43 p.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39576/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2016, 11:43 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
>
>
> Bugs: LENS-833
> https://issues.apache.org/jira/browse/LENS-833
>
>
> Repository: lens
>
>
> Description
> -------
>
> Failing the open session operation if user creates more sessions than configured limit.
>
> Created LensHttpStatus for adding new status codes in the Response class. Both Status from Response class and LensHttpStatus implements StatusType interface.
> Changed teh parameter type to StatusType to make it generic
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/ErrorCollectionFactory.java 741630b
> lens-api/src/main/java/org/apache/lens/api/error/LensError.java 1cb7409
> lens-api/src/main/java/org/apache/lens/api/error/LensHttpStatus.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/result/LensAPIResult.java 238f9e6
> lens-api/src/main/resources/lens-errors.conf 09b221f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 558e97f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 97ca2c8
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 32ed7b0
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 45555f4
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java bea128b
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 1454e5f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 9fce233
> lens-cli/src/test/java/org/apache/lens/cli/TestLensLogResourceCommands.java f4b043e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java e5f11f2
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java a178296
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 1b7d0f9
> lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java a1ffeb6
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 0821fe7
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java dc20f0f
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java ac77418
> lens-server/src/main/resources/lensserver-default.xml a711d03
> lens-server/src/test/java/org/apache/lens/server/TestServerMode.java caf968a
> lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java 8e22837
> lens-server/src/test/java/org/apache/lens/server/common/ErrorResponseExpectedData.java 4d4f137
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java a541e9b
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 30f7aff
> lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java a5ee5cc
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 699fa68
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java bde7b9b
> lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java be87e65
> lens-server/src/test/resources/lens-site.xml c3187a8
> src/site/apt/admin/config.apt fb15d83
>
> Diff: https://reviews.apache.org/r/39576/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 39576: LENS-833 : Limit number of open sessions
per user on session service
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39576/#review121389
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Feb. 29, 2016, 11:10 p.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39576/
> -----------------------------------------------------------
>
> (Updated Feb. 29, 2016, 11:10 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
>
>
> Bugs: LENS-833
> https://issues.apache.org/jira/browse/LENS-833
>
>
> Repository: lens
>
>
> Description
> -------
>
> Failing the open session operation if user creates more sessions than configured limit.
>
> Created LensHttpStatus for adding new status codes in the Response class. Both Status from Response class and LensHttpStatus implements StatusType interface.
> Changed teh parameter type to StatusType to make it generic
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/ErrorCollectionFactory.java 741630b
> lens-api/src/main/java/org/apache/lens/api/error/LensError.java 1cb7409
> lens-api/src/main/java/org/apache/lens/api/error/LensHttpStatus.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/result/LensAPIResult.java 238f9e6
> lens-api/src/main/resources/lens-errors.conf 09b221f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 558e97f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 97ca2c8
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 32ed7b0
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 45555f4
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java bea128b
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 1454e5f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 9fce233
> lens-cli/src/test/java/org/apache/lens/cli/TestLensLogResourceCommands.java f4b043e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java e5f11f2
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java a178296
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 1b7d0f9
> lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java a1ffeb6
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 0821fe7
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java dc20f0f
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java ac77418
> lens-server/src/main/resources/lensserver-default.xml a711d03
> lens-server/src/test/java/org/apache/lens/server/TestServerMode.java caf968a
> lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java 8e22837
> lens-server/src/test/java/org/apache/lens/server/common/ErrorResponseExpectedData.java 4d4f137
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java a541e9b
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 30f7aff
> lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java a5ee5cc
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java bde7b9b
> lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java be87e65
> lens-server/src/test/resources/lens-site.xml c3187a8
> src/site/apt/admin/config.apt fb15d83
>
> Diff: https://reviews.apache.org/r/39576/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.737s]
> [INFO] Lens .............................................. SUCCESS [3.140s]
> [INFO] Lens API .......................................... SUCCESS [22.188s]
> [INFO] Lens API for server and extensions ................ SUCCESS [16.051s]
> [INFO] Lens Cube ......................................... SUCCESS [9:34.494s]
> [INFO] Lens DB storage ................................... SUCCESS [17.660s]
> [INFO] Lens Query Library ................................ SUCCESS [19.226s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:55.805s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [49.269s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [23.175s]
> [INFO] Lens Server ....................................... SUCCESS [20:34.425s]
> [INFO] Lens client ....................................... SUCCESS [30.663s]
> [INFO] Lens CLI .......................................... SUCCESS [47.568s]
> [INFO] Lens Examples ..................................... SUCCESS [11.947s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.749s]
> [INFO] Lens Distribution ................................. SUCCESS [8.793s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:10.207s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.813s]
> [INFO] Lens Regression ................................... SUCCESS [13.033s]
> [INFO] Lens UI ........................................... SUCCESS [0.157s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 38:42.684s
> [INFO] Finished at: Tue Mar 01 01:47:10 SGT 2016
> [INFO] Final Memory: 185M/1085M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 39576: LENS-833 : Limit number of open sessions
per user on session service
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39576/#review121388
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Feb. 29, 2016, 11:10 p.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39576/
> -----------------------------------------------------------
>
> (Updated Feb. 29, 2016, 11:10 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
>
>
> Bugs: LENS-833
> https://issues.apache.org/jira/browse/LENS-833
>
>
> Repository: lens
>
>
> Description
> -------
>
> Failing the open session operation if user creates more sessions than configured limit.
>
> Created LensHttpStatus for adding new status codes in the Response class. Both Status from Response class and LensHttpStatus implements StatusType interface.
> Changed teh parameter type to StatusType to make it generic
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/ErrorCollectionFactory.java 741630b
> lens-api/src/main/java/org/apache/lens/api/error/LensError.java 1cb7409
> lens-api/src/main/java/org/apache/lens/api/error/LensHttpStatus.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/result/LensAPIResult.java 238f9e6
> lens-api/src/main/resources/lens-errors.conf 09b221f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 558e97f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 97ca2c8
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 32ed7b0
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 45555f4
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java bea128b
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 1454e5f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 9fce233
> lens-cli/src/test/java/org/apache/lens/cli/TestLensLogResourceCommands.java f4b043e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java e5f11f2
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java a178296
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 1b7d0f9
> lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java a1ffeb6
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 0821fe7
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java dc20f0f
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java ac77418
> lens-server/src/main/resources/lensserver-default.xml a711d03
> lens-server/src/test/java/org/apache/lens/server/TestServerMode.java caf968a
> lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java 8e22837
> lens-server/src/test/java/org/apache/lens/server/common/ErrorResponseExpectedData.java 4d4f137
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java a541e9b
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 30f7aff
> lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java a5ee5cc
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java bde7b9b
> lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java be87e65
> lens-server/src/test/resources/lens-site.xml c3187a8
> src/site/apt/admin/config.apt fb15d83
>
> Diff: https://reviews.apache.org/r/39576/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.737s]
> [INFO] Lens .............................................. SUCCESS [3.140s]
> [INFO] Lens API .......................................... SUCCESS [22.188s]
> [INFO] Lens API for server and extensions ................ SUCCESS [16.051s]
> [INFO] Lens Cube ......................................... SUCCESS [9:34.494s]
> [INFO] Lens DB storage ................................... SUCCESS [17.660s]
> [INFO] Lens Query Library ................................ SUCCESS [19.226s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:55.805s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [49.269s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [23.175s]
> [INFO] Lens Server ....................................... SUCCESS [20:34.425s]
> [INFO] Lens client ....................................... SUCCESS [30.663s]
> [INFO] Lens CLI .......................................... SUCCESS [47.568s]
> [INFO] Lens Examples ..................................... SUCCESS [11.947s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.749s]
> [INFO] Lens Distribution ................................. SUCCESS [8.793s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:10.207s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.813s]
> [INFO] Lens Regression ................................... SUCCESS [13.033s]
> [INFO] Lens UI ........................................... SUCCESS [0.157s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 38:42.684s
> [INFO] Finished at: Tue Mar 01 01:47:10 SGT 2016
> [INFO] Final Memory: 185M/1085M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 39576: LENS-833 : Limit number of open sessions
per user on session service
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39576/
-----------------------------------------------------------
(Updated Feb. 29, 2016, 11:10 p.m.)
Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
Bugs: LENS-833
https://issues.apache.org/jira/browse/LENS-833
Repository: lens
Description
-------
Failing the open session operation if user creates more sessions than configured limit.
Created LensHttpStatus for adding new status codes in the Response class. Both Status from Response class and LensHttpStatus implements StatusType interface.
Changed teh parameter type to StatusType to make it generic
Diffs
-----
lens-api/src/main/java/org/apache/lens/api/error/ErrorCollectionFactory.java 741630b
lens-api/src/main/java/org/apache/lens/api/error/LensError.java 1cb7409
lens-api/src/main/java/org/apache/lens/api/error/LensHttpStatus.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/result/LensAPIResult.java 238f9e6
lens-api/src/main/resources/lens-errors.conf 09b221f
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 558e97f
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 97ca2c8
lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 32ed7b0
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 45555f4
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java bea128b
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 1454e5f
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 9fce233
lens-cli/src/test/java/org/apache/lens/cli/TestLensLogResourceCommands.java f4b043e
lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java e5f11f2
lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java a178296
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 1b7d0f9
lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java a1ffeb6
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 0821fe7
lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java dc20f0f
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java ac77418
lens-server/src/main/resources/lensserver-default.xml a711d03
lens-server/src/test/java/org/apache/lens/server/TestServerMode.java caf968a
lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java 8e22837
lens-server/src/test/java/org/apache/lens/server/common/ErrorResponseExpectedData.java 4d4f137
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java a541e9b
lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 30f7aff
lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java a5ee5cc
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java bde7b9b
lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java be87e65
lens-server/src/test/resources/lens-site.xml c3187a8
src/site/apt/admin/config.apt fb15d83
Diff: https://reviews.apache.org/r/39576/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.737s]
[INFO] Lens .............................................. SUCCESS [3.140s]
[INFO] Lens API .......................................... SUCCESS [22.188s]
[INFO] Lens API for server and extensions ................ SUCCESS [16.051s]
[INFO] Lens Cube ......................................... SUCCESS [9:34.494s]
[INFO] Lens DB storage ................................... SUCCESS [17.660s]
[INFO] Lens Query Library ................................ SUCCESS [19.226s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:55.805s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [49.269s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [23.175s]
[INFO] Lens Server ....................................... SUCCESS [20:34.425s]
[INFO] Lens client ....................................... SUCCESS [30.663s]
[INFO] Lens CLI .......................................... SUCCESS [47.568s]
[INFO] Lens Examples ..................................... SUCCESS [11.947s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.749s]
[INFO] Lens Distribution ................................. SUCCESS [8.793s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:10.207s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.813s]
[INFO] Lens Regression ................................... SUCCESS [13.033s]
[INFO] Lens UI ........................................... SUCCESS [0.157s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 38:42.684s
[INFO] Finished at: Tue Mar 01 01:47:10 SGT 2016
[INFO] Final Memory: 185M/1085M
[INFO] ------------------------------------------------------------------------
Thanks,
Raju Bairishetti
Re: Review Request 39576: LENS-833 : Limit number of open sessions
per user on session service
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39576/
-----------------------------------------------------------
(Updated Feb. 29, 2016, 11:09 p.m.)
Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
Bugs: LENS-833
https://issues.apache.org/jira/browse/LENS-833
Repository: lens
Description
-------
Failing the open session operation if user creates more sessions than configured limit.
Created LensHttpStatus for adding new status codes in the Response class. Both Status from Response class and LensHttpStatus implements StatusType interface.
Changed teh parameter type to StatusType to make it generic
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/error/ErrorCollectionFactory.java 741630b
lens-api/src/main/java/org/apache/lens/api/error/LensError.java 1cb7409
lens-api/src/main/java/org/apache/lens/api/error/LensHttpStatus.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/result/LensAPIResult.java 238f9e6
lens-api/src/main/resources/lens-errors.conf 09b221f
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 558e97f
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 97ca2c8
lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 32ed7b0
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 45555f4
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java bea128b
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 1454e5f
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 9fce233
lens-cli/src/test/java/org/apache/lens/cli/TestLensLogResourceCommands.java f4b043e
lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java e5f11f2
lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java a178296
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 1b7d0f9
lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java a1ffeb6
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 0821fe7
lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java dc20f0f
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java ac77418
lens-server/src/main/resources/lensserver-default.xml a711d03
lens-server/src/test/java/org/apache/lens/server/TestServerMode.java caf968a
lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java 8e22837
lens-server/src/test/java/org/apache/lens/server/common/ErrorResponseExpectedData.java 4d4f137
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java a541e9b
lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 30f7aff
lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java a5ee5cc
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java bde7b9b
lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java be87e65
lens-server/src/test/resources/lens-site.xml c3187a8
src/site/apt/admin/config.apt fb15d83
Diff: https://reviews.apache.org/r/39576/diff/
Testing
-------
Thanks,
Raju Bairishetti
Re: Review Request 39576: LENS-833 : Limit number of open sessions
per user on session service
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39576/
-----------------------------------------------------------
(Updated Feb. 28, 2016, 11:43 p.m.)
Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
Changes
-------
Updated to master branch and fixed review comments and tests
Bugs: LENS-833
https://issues.apache.org/jira/browse/LENS-833
Repository: lens
Description
-------
Failing the open session operation if user creates more sessions than configured limit.
Created LensHttpStatus for adding new status codes in the Response class. Both Status from Response class and LensHttpStatus implements StatusType interface.
Changed teh parameter type to StatusType to make it generic
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/error/ErrorCollectionFactory.java 741630b
lens-api/src/main/java/org/apache/lens/api/error/LensError.java 1cb7409
lens-api/src/main/java/org/apache/lens/api/error/LensHttpStatus.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/result/LensAPIResult.java 238f9e6
lens-api/src/main/resources/lens-errors.conf 09b221f
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 558e97f
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 97ca2c8
lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 32ed7b0
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 45555f4
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java bea128b
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 1454e5f
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 9fce233
lens-cli/src/test/java/org/apache/lens/cli/TestLensLogResourceCommands.java f4b043e
lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java e5f11f2
lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java a178296
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 1b7d0f9
lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java a1ffeb6
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 0821fe7
lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java dc20f0f
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java ac77418
lens-server/src/main/resources/lensserver-default.xml a711d03
lens-server/src/test/java/org/apache/lens/server/TestServerMode.java caf968a
lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java 8e22837
lens-server/src/test/java/org/apache/lens/server/common/ErrorResponseExpectedData.java 4d4f137
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java a541e9b
lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 30f7aff
lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java a5ee5cc
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 699fa68
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java bde7b9b
lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java be87e65
lens-server/src/test/resources/lens-site.xml c3187a8
src/site/apt/admin/config.apt fb15d83
Diff: https://reviews.apache.org/r/39576/diff/
Testing
-------
Thanks,
Raju Bairishetti
Re: Review Request 39576: LENS-833 : Limit number of open sessions
per user on session service
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39576/
-----------------------------------------------------------
(Updated Feb. 23, 2016, 2:38 p.m.)
Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
Changes
-------
Addressed review comments
Bugs: LENS-833
https://issues.apache.org/jira/browse/LENS-833
Repository: lens
Description
-------
Failing the open session operation if user creates more sessions than configured limit.
Created LensHttpStatus for adding new status codes in the Response class. Both Status from Response class and LensHttpStatus implements StatusType interface.
Changed teh parameter type to StatusType to make it generic
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/error/ErrorCollectionFactory.java 741630b
lens-api/src/main/java/org/apache/lens/api/error/LensError.java 1cb7409
lens-api/src/main/java/org/apache/lens/api/error/LensHttpStatus.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/result/LensAPIResult.java 238f9e6
lens-api/src/main/resources/lens-errors.conf 9087fcd
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 558e97f
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 43d0722
lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 32ed7b0
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 160699b
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 30f4ec1
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 448d0f6
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 9fce233
lens-cli/src/test/java/org/apache/lens/cli/TestLensLogResourceCommands.java f4b043e
lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java e5f11f2
lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 8bccac2
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java a3dbfc0
lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java a1ffeb6
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 0821fe7
lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java dc20f0f
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 3ba5edd
lens-server/src/main/resources/lensserver-default.xml cac641a
lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 75f21e1
lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java 8e22837
lens-server/src/test/java/org/apache/lens/server/common/ErrorResponseExpectedData.java 4d4f137
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 925fc86
lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 6f8886c
lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 01e846a
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java c5d75de
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 3055ce5
lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java 6f7c216
lens-server/src/test/resources/lens-site.xml 9cb4a6f
src/site/apt/admin/config.apt 54f827e
src/site/apt/admin/session-config.apt 05a2c2c
Diff: https://reviews.apache.org/r/39576/diff/
Testing
-------
Thanks,
Raju Bairishetti
Re: Review Request 39576: LENS-833 : Limit number of open sessions
per user on session service
Posted by Raju Bairishetti <ra...@gmail.com>.
> On Feb. 23, 2016, 9:25 a.m., Puneet Gupta wrote:
> > lens-api/src/main/java/org/apache/lens/api/error/LensHttpStatus.java, lines 64-66
> > <https://reviews.apache.org/r/39576/diff/8/?file=1203170#file1203170line64>
> >
> > Can we delegate every call to “javax.ws.rs.core.Response.Status” methods first and wherever that delegation fails we can resolve the extra status codes form LensHttpStatus. That way we won’t be copying the code of Response.Status here.
Sure. I will make changes accrodingly
- Raju
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39576/#review120280
-----------------------------------------------------------
On Jan. 20, 2016, 3:11 p.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39576/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2016, 3:11 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
>
>
> Bugs: LENS-833
> https://issues.apache.org/jira/browse/LENS-833
>
>
> Repository: lens
>
>
> Description
> -------
>
> Failing the open session operation if user creates more sessions than configured limit.
>
> Created LensHttpStatus for adding new status codes in the Response class. Both Status from Response class and LensHttpStatus implements StatusType interface.
> Changed teh parameter type to StatusType to make it generic
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/ErrorCollectionFactory.java 741630b
> lens-api/src/main/java/org/apache/lens/api/error/LensError.java 1cb7409
> lens-api/src/main/java/org/apache/lens/api/error/LensHttpStatus.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/result/LensAPIResult.java 238f9e6
> lens-api/src/main/resources/lens-errors.conf 9087fcd
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 558e97f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 43d0722
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 32ed7b0
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 160699b
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 30f4ec1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 448d0f6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 9fce233
> lens-cli/src/test/java/org/apache/lens/cli/TestLensLogResourceCommands.java f4b043e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java e5f11f2
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 8bccac2
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java a3dbfc0
> lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java a1ffeb6
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 0821fe7
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java dc20f0f
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 3ba5edd
> lens-server/src/main/resources/lensserver-default.xml cac641a
> lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 75f21e1
> lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java 8e22837
> lens-server/src/test/java/org/apache/lens/server/common/ErrorResponseExpectedData.java 4d4f137
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 925fc86
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 6f8886c
> lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 01e846a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java c5d75de
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 3055ce5
> lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java 6f7c216
> lens-server/src/test/resources/lens-site.xml 9cb4a6f
> src/site/apt/admin/config.apt 54f827e
> src/site/apt/admin/session-config.apt 05a2c2c
>
> Diff: https://reviews.apache.org/r/39576/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 39576: LENS-833 : Limit number of open sessions
per user on session service
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39576/#review120280
-----------------------------------------------------------
lens-api/src/main/java/org/apache/lens/api/error/LensHttpStatus.java (lines 64 - 66)
<https://reviews.apache.org/r/39576/#comment181713>
Can we delegate every call to “javax.ws.rs.core.Response.Status” methods first and wherever that delegation fails we can resolve the extra status codes form LensHttpStatus. That way we won’t be copying the code of Response.Status here.
- Puneet Gupta
On Jan. 20, 2016, 3:11 p.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39576/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2016, 3:11 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
>
>
> Bugs: LENS-833
> https://issues.apache.org/jira/browse/LENS-833
>
>
> Repository: lens
>
>
> Description
> -------
>
> Failing the open session operation if user creates more sessions than configured limit.
>
> Created LensHttpStatus for adding new status codes in the Response class. Both Status from Response class and LensHttpStatus implements StatusType interface.
> Changed teh parameter type to StatusType to make it generic
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/ErrorCollectionFactory.java 741630b
> lens-api/src/main/java/org/apache/lens/api/error/LensError.java 1cb7409
> lens-api/src/main/java/org/apache/lens/api/error/LensHttpStatus.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/result/LensAPIResult.java 238f9e6
> lens-api/src/main/resources/lens-errors.conf 9087fcd
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 558e97f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 43d0722
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 32ed7b0
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 160699b
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 30f4ec1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 448d0f6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 9fce233
> lens-cli/src/test/java/org/apache/lens/cli/TestLensLogResourceCommands.java f4b043e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java e5f11f2
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 8bccac2
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java a3dbfc0
> lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java a1ffeb6
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 0821fe7
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java dc20f0f
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 3ba5edd
> lens-server/src/main/resources/lensserver-default.xml cac641a
> lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 75f21e1
> lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java 8e22837
> lens-server/src/test/java/org/apache/lens/server/common/ErrorResponseExpectedData.java 4d4f137
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 925fc86
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 6f8886c
> lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 01e846a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java c5d75de
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 3055ce5
> lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java 6f7c216
> lens-server/src/test/resources/lens-site.xml 9cb4a6f
> src/site/apt/admin/config.apt 54f827e
> src/site/apt/admin/session-config.apt 05a2c2c
>
> Diff: https://reviews.apache.org/r/39576/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 39576: LENS-833 : Limit number of open sessions
per user on session service
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39576/#review120275
-----------------------------------------------------------
lens-api/src/main/java/org/apache/lens/api/error/LensHttpStatus.java (line 25)
<https://reviews.apache.org/r/39576/#comment181710>
Can't this contain just the extra status codes?
- Rajat Khandelwal
On Jan. 20, 2016, 8:41 p.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39576/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2016, 8:41 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
>
>
> Bugs: LENS-833
> https://issues.apache.org/jira/browse/LENS-833
>
>
> Repository: lens
>
>
> Description
> -------
>
> Failing the open session operation if user creates more sessions than configured limit.
>
> Created LensHttpStatus for adding new status codes in the Response class. Both Status from Response class and LensHttpStatus implements StatusType interface.
> Changed teh parameter type to StatusType to make it generic
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/ErrorCollectionFactory.java 741630b
> lens-api/src/main/java/org/apache/lens/api/error/LensError.java 1cb7409
> lens-api/src/main/java/org/apache/lens/api/error/LensHttpStatus.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/result/LensAPIResult.java 238f9e6
> lens-api/src/main/resources/lens-errors.conf 9087fcd
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 558e97f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 43d0722
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 32ed7b0
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 160699b
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 30f4ec1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 448d0f6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 9fce233
> lens-cli/src/test/java/org/apache/lens/cli/TestLensLogResourceCommands.java f4b043e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java e5f11f2
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 8bccac2
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java a3dbfc0
> lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java a1ffeb6
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 0821fe7
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java dc20f0f
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 3ba5edd
> lens-server/src/main/resources/lensserver-default.xml cac641a
> lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 75f21e1
> lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java 8e22837
> lens-server/src/test/java/org/apache/lens/server/common/ErrorResponseExpectedData.java 4d4f137
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 925fc86
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 6f8886c
> lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 01e846a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java c5d75de
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 3055ce5
> lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java 6f7c216
> lens-server/src/test/resources/lens-site.xml 9cb4a6f
> src/site/apt/admin/config.apt 54f827e
> src/site/apt/admin/session-config.apt 05a2c2c
>
> Diff: https://reviews.apache.org/r/39576/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 39576: LENS-833 : Limit number of open sessions
per user on session service
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39576/
-----------------------------------------------------------
(Updated Jan. 20, 2016, 3:11 p.m.)
Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
Changes
-------
Addressed review comments
Bugs: LENS-833
https://issues.apache.org/jira/browse/LENS-833
Repository: lens
Description
-------
Failing the open session operation if user creates more sessions than configured limit.
Created LensHttpStatus for adding new status codes in the Response class. Both Status from Response class and LensHttpStatus implements StatusType interface.
Changed teh parameter type to StatusType to make it generic
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/error/ErrorCollectionFactory.java 741630b
lens-api/src/main/java/org/apache/lens/api/error/LensError.java 1cb7409
lens-api/src/main/java/org/apache/lens/api/error/LensHttpStatus.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/result/LensAPIResult.java 238f9e6
lens-api/src/main/resources/lens-errors.conf 9087fcd
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 558e97f
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 43d0722
lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 32ed7b0
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 160699b
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 30f4ec1
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 448d0f6
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 9fce233
lens-cli/src/test/java/org/apache/lens/cli/TestLensLogResourceCommands.java f4b043e
lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java e5f11f2
lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 8bccac2
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java a3dbfc0
lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java a1ffeb6
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 0821fe7
lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java dc20f0f
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 3ba5edd
lens-server/src/main/resources/lensserver-default.xml cac641a
lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 75f21e1
lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java 8e22837
lens-server/src/test/java/org/apache/lens/server/common/ErrorResponseExpectedData.java 4d4f137
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 925fc86
lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 6f8886c
lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 01e846a
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java c5d75de
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 3055ce5
lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java 6f7c216
lens-server/src/test/resources/lens-site.xml 9cb4a6f
src/site/apt/admin/config.apt 54f827e
src/site/apt/admin/session-config.apt 05a2c2c
Diff: https://reviews.apache.org/r/39576/diff/
Testing
-------
Thanks,
Raju Bairishetti
Re: Review Request 39576: LENS-833 : Limit number of open sessions
per user on session service
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39576/
-----------------------------------------------------------
(Updated Jan. 13, 2016, 12:11 p.m.)
Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
Bugs: LENS-833
https://issues.apache.org/jira/browse/LENS-833
Repository: lens
Description
-------
Failing the open session operation if user creates more sessions than configured limit.
Created LensHttpStatus for adding new status codes in the Response class. Both Status from Response class and LensHttpStatus implements StatusType interface.
Changed teh parameter type to StatusType to make it generic
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/error/ErrorCollectionFactory.java 741630b
lens-api/src/main/java/org/apache/lens/api/error/LensError.java 1cb7409
lens-api/src/main/java/org/apache/lens/api/error/LensHttpStatus.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/result/LensAPIResult.java 238f9e6
lens-api/src/main/resources/lens-errors.conf 9087fcd
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 558e97f
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 43d0722
lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 32ed7b0
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 160699b
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 30f4ec1
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 448d0f6
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 9fce233
lens-cli/src/test/java/org/apache/lens/cli/TestLensLogResourceCommands.java f4b043e
lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java e5f11f2
lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 8bccac2
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java a3dbfc0
lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java a1ffeb6
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 0821fe7
lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java dc20f0f
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 3ba5edd
lens-server/src/main/resources/lensserver-default.xml cac641a
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 8f52ddd
lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 75f21e1
lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java 8e22837
lens-server/src/test/java/org/apache/lens/server/common/ErrorResponseExpectedData.java 4d4f137
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 925fc86
lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 6f8886c
lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 01e846a
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java c5d75de
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 3055ce5
lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java 6f7c216
lens-server/src/test/resources/lens-site.xml 9cb4a6f
src/site/apt/admin/config.apt 54f827e
src/site/apt/admin/session-config.apt 05a2c2c
Diff: https://reviews.apache.org/r/39576/diff/
Testing
-------
Thanks,
Raju Bairishetti
Re: Review Request 39576: LENS-833 : Limit number of open sessions
per user on session service
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39576/
-----------------------------------------------------------
(Updated Jan. 13, 2016, 11:58 a.m.)
Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
Bugs: LENS-833
https://issues.apache.org/jira/browse/LENS-833
Repository: lens
Description (updated)
-------
Failing the open session operation if user creates more sessions than configured limit.
Created LensHttpStatus for adding new status codes in the Response class. Both Status from Response class and LensHttpStatus implements StatusType interface.
Changed teh parameter type to StatusType to make it generic
Diffs
-----
lens-api/src/main/java/org/apache/lens/api/error/ErrorCollectionFactory.java 741630b
lens-api/src/main/java/org/apache/lens/api/error/LensError.java 1cb7409
lens-api/src/main/java/org/apache/lens/api/error/LensHttpStatus.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/result/LensAPIResult.java 238f9e6
lens-api/src/main/resources/lens-errors.conf 9087fcd
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 558e97f
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 43d0722
lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 32ed7b0
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 160699b
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 30f4ec1
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 448d0f6
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 9fce233
lens-cli/src/test/java/org/apache/lens/cli/TestLensLogResourceCommands.java f4b043e
lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java e5f11f2
lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 8bccac2
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java a3dbfc0
lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java a1ffeb6
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 0821fe7
lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java dc20f0f
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 3ba5edd
lens-server/src/main/resources/lensserver-default.xml cac641a
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 8f52ddd
lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 75f21e1
lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java 8e22837
lens-server/src/test/java/org/apache/lens/server/common/ErrorResponseExpectedData.java 4d4f137
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 925fc86
lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 6f8886c
lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 01e846a
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java c5d75de
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 3055ce5
lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java 6f7c216
lens-server/src/test/resources/lens-site.xml 9cb4a6f
src/site/apt/admin/config.apt 54f827e
src/site/apt/admin/session-config.apt 05a2c2c
Diff: https://reviews.apache.org/r/39576/diff/
Testing
-------
Thanks,
Raju Bairishetti
Re: Review Request 39576: LENS-833 : Limit number of open sessions
per user on session service
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39576/
-----------------------------------------------------------
(Updated Jan. 13, 2016, 11:51 a.m.)
Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
Bugs: LENS-833
https://issues.apache.org/jira/browse/LENS-833
Repository: lens
Description
-------
Failing the open session operation if user creates more sessions than configured limit.
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/error/ErrorCollectionFactory.java 741630b
lens-api/src/main/java/org/apache/lens/api/error/LensError.java 1cb7409
lens-api/src/main/java/org/apache/lens/api/error/LensHttpStatus.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/result/LensAPIResult.java 238f9e6
lens-api/src/main/resources/lens-errors.conf 9087fcd
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 558e97f
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 43d0722
lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 32ed7b0
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 160699b
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 30f4ec1
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 448d0f6
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 9fce233
lens-cli/src/test/java/org/apache/lens/cli/TestLensLogResourceCommands.java f4b043e
lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java e5f11f2
lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 8bccac2
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java a3dbfc0
lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java a1ffeb6
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 0821fe7
lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java dc20f0f
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 3ba5edd
lens-server/src/main/resources/lensserver-default.xml cac641a
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 8f52ddd
lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 75f21e1
lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java 8e22837
lens-server/src/test/java/org/apache/lens/server/common/ErrorResponseExpectedData.java 4d4f137
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 925fc86
lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 6f8886c
lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 01e846a
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java c5d75de
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 3055ce5
lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java 6f7c216
lens-server/src/test/resources/lens-site.xml 9cb4a6f
src/site/apt/admin/config.apt 54f827e
src/site/apt/admin/session-config.apt 05a2c2c
Diff: https://reviews.apache.org/r/39576/diff/
Testing
-------
Thanks,
Raju Bairishetti
Re: Review Request 39576: LENS-833 : Limit number of open sessions
per user on session service
Posted by Raju Bairishetti <ra...@gmail.com>.
> On Jan. 9, 2016, 2:18 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/test/resources/lens-site.xml, line 192
> > <https://reviews.apache.org/r/39576/diff/5/?file=1181363#file1181363line192>
> >
> > Why 20? It should be lesser than the default as well.
Tests are failing with too many open sessions. Almost all of the opened sessions are getting clsoed in every unit test. Test failures were because of running multiple unit tests in parallel. Increased num sessions to 20 to avoid **timing issues** in test cases
> On Jan. 9, 2016, 2:18 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java, lines 290-293
> > <https://reviews.apache.org/r/39576/diff/5/?file=1181352#file1181352line290>
> >
> > Not synchronized?
Syncronizing inside the decrementSessionCountForUser()
> On Jan. 9, 2016, 2:18 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java, lines 200-203
> > <https://reviews.apache.org/r/39576/diff/5/?file=1181352#file1181352line200>
> >
> > Not inside synchronized block ?
It is in syncronized block. Syncronized on SessionUser instance.
> On Jan. 9, 2016, 2:18 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java, line 108
> > <https://reviews.apache.org/r/39576/diff/5/?file=1181352#file1181352line108>
> >
> > Why is this class required?
Added this class to get a user instance for acuiring lock on User instance while opening & closing sessions. I can remove the class and creting a new String instance with the user and store it in SESSION_USER_INSTANCE_MAP.
```
My earlier comment:
There are some race codnition issues if the following operations are not in atomic operation(i.e. not in single syncronized block).
1) Check if user can eligible to open a session
2) Open a new session
3) Update session count for user
All the three operations should be done in a single step(i.e. in synchronized block) to make sure only one thread gets access to session count of user.
Two approaches to solve this issue:
1) We can take lock on SESSIONS_PER_USER (i.e. syncronized(SESSIONS_PER_USER)). But taking lock on entire map is not a good idea as other user threads also will get blocked. Lock/syncronization should be within user level
2) Right now, User is a String instance. Syncronizing on String object is not a good idea. We can create a user instance and syncronize on user instance Let to fix it.
I am thinking to go ahead with second approach. Please let me know your suggestions/concerns
```
> On Jan. 9, 2016, 2:18 a.m., Amareshwari Sriramadasu wrote:
> > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java, line 118
> > <https://reviews.apache.org/r/39576/diff/5/?file=1181347#file1181347line118>
> >
> > Arent both the commands using the same client?
No. Commands are using two diffrent client instances.
- Raju
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39576/#review113594
-----------------------------------------------------------
On Jan. 5, 2016, 12:42 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39576/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 12:42 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
>
>
> Bugs: LENS-833
> https://issues.apache.org/jira/browse/LENS-833
>
>
> Repository: lens
>
>
> Description
> -------
>
> Failing the open session operation if user creates more sessions than configured limit.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/ErrorCollectionFactory.java 741630b
> lens-api/src/main/resources/lens-errors.conf 06960a0
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 558e97f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 43d0722
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 32ed7b0
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 42c6bae
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 30f4ec1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 448d0f6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 9fce233
> lens-cli/src/test/java/org/apache/lens/cli/TestLensLogResourceCommands.java f4b043e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java d453803
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 8bccac2
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 88e5a01
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 0821fe7
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java dc20f0f
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 3ba5edd
> lens-server/src/main/resources/lensserver-default.xml cac641a
> lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 75f21e1
> lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java 8e22837
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java e0c0923
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 69c3f46
> lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 01e846a
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 3055ce5
> lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java 6f7c216
> lens-server/src/test/resources/lens-site.xml 9cb4a6f
> src/site/apt/admin/config.apt 54f827e
>
> Diff: https://reviews.apache.org/r/39576/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 39576: LENS-833 : Limit number of open sessions
per user on session service
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Jan. 9, 2016, 2:18 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java, lines 290-293
> > <https://reviews.apache.org/r/39576/diff/5/?file=1181352#file1181352line290>
> >
> > Not synchronized?
>
> Raju Bairishetti wrote:
> Syncronizing inside the decrementSessionCountForUser()
removing from SESSION_MAP and decrementing are not atomic. Is that OK ?
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39576/#review113594
-----------------------------------------------------------
On Jan. 13, 2016, 12:11 p.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39576/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2016, 12:11 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
>
>
> Bugs: LENS-833
> https://issues.apache.org/jira/browse/LENS-833
>
>
> Repository: lens
>
>
> Description
> -------
>
> Failing the open session operation if user creates more sessions than configured limit.
>
> Created LensHttpStatus for adding new status codes in the Response class. Both Status from Response class and LensHttpStatus implements StatusType interface.
> Changed teh parameter type to StatusType to make it generic
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/ErrorCollectionFactory.java 741630b
> lens-api/src/main/java/org/apache/lens/api/error/LensError.java 1cb7409
> lens-api/src/main/java/org/apache/lens/api/error/LensHttpStatus.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/result/LensAPIResult.java 238f9e6
> lens-api/src/main/resources/lens-errors.conf 9087fcd
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 558e97f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 43d0722
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 32ed7b0
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 160699b
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 30f4ec1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 448d0f6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 9fce233
> lens-cli/src/test/java/org/apache/lens/cli/TestLensLogResourceCommands.java f4b043e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java e5f11f2
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 8bccac2
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java a3dbfc0
> lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java a1ffeb6
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 0821fe7
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java dc20f0f
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 3ba5edd
> lens-server/src/main/resources/lensserver-default.xml cac641a
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 8f52ddd
> lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 75f21e1
> lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java 8e22837
> lens-server/src/test/java/org/apache/lens/server/common/ErrorResponseExpectedData.java 4d4f137
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 925fc86
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 6f8886c
> lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 01e846a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java c5d75de
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 3055ce5
> lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java 6f7c216
> lens-server/src/test/resources/lens-site.xml 9cb4a6f
> src/site/apt/admin/config.apt 54f827e
> src/site/apt/admin/session-config.apt 05a2c2c
>
> Diff: https://reviews.apache.org/r/39576/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 39576: LENS-833 : Limit number of open sessions
per user on session service
Posted by Raju Bairishetti <ra...@gmail.com>.
> On Jan. 9, 2016, 2:18 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java, lines 290-293
> > <https://reviews.apache.org/r/39576/diff/5/?file=1181352#file1181352line290>
> >
> > Not synchronized?
>
> Raju Bairishetti wrote:
> Syncronizing inside the decrementSessionCountForUser()
>
> Amareshwari Sriramadasu wrote:
> removing from SESSION_MAP and decrementing are not atomic. Is that OK ?
Need not be atomic as decrementSessionCountForUser does not depend on SESSION_MAP for updating operations.
- Raju
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39576/#review113594
-----------------------------------------------------------
On Jan. 13, 2016, 12:11 p.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39576/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2016, 12:11 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
>
>
> Bugs: LENS-833
> https://issues.apache.org/jira/browse/LENS-833
>
>
> Repository: lens
>
>
> Description
> -------
>
> Failing the open session operation if user creates more sessions than configured limit.
>
> Created LensHttpStatus for adding new status codes in the Response class. Both Status from Response class and LensHttpStatus implements StatusType interface.
> Changed teh parameter type to StatusType to make it generic
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/ErrorCollectionFactory.java 741630b
> lens-api/src/main/java/org/apache/lens/api/error/LensError.java 1cb7409
> lens-api/src/main/java/org/apache/lens/api/error/LensHttpStatus.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/result/LensAPIResult.java 238f9e6
> lens-api/src/main/resources/lens-errors.conf 9087fcd
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 558e97f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 43d0722
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 32ed7b0
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 160699b
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 30f4ec1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 448d0f6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 9fce233
> lens-cli/src/test/java/org/apache/lens/cli/TestLensLogResourceCommands.java f4b043e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java e5f11f2
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 8bccac2
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java a3dbfc0
> lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java a1ffeb6
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 0821fe7
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java dc20f0f
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 3ba5edd
> lens-server/src/main/resources/lensserver-default.xml cac641a
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 8f52ddd
> lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 75f21e1
> lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java 8e22837
> lens-server/src/test/java/org/apache/lens/server/common/ErrorResponseExpectedData.java 4d4f137
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 925fc86
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 6f8886c
> lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 01e846a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java c5d75de
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 3055ce5
> lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java 6f7c216
> lens-server/src/test/resources/lens-site.xml 9cb4a6f
> src/site/apt/admin/config.apt 54f827e
> src/site/apt/admin/session-config.apt 05a2c2c
>
> Diff: https://reviews.apache.org/r/39576/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 39576: LENS-833 : Limit number of open sessions
per user on session service
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39576/#review113594
-----------------------------------------------------------
lens-api/src/main/java/org/apache/lens/api/error/ErrorCollectionFactory.java (line 66)
<https://reviews.apache.org/r/39576/#comment174334>
Let us fill this TODO. Seems anything greater than 417 cannot be created from Status.fromStatusCode, let us create explicitly for them.
lens-api/src/main/resources/lens-errors.conf (line 102)
<https://reviews.apache.org/r/39576/#comment174335>
Should we pass user name as param here?
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java (line 118)
<https://reviews.apache.org/r/39576/#comment174336>
Arent both the commands using the same client?
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java (line 91)
<https://reviews.apache.org/r/39576/#comment174337>
Can you add on what each map is doing?
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java (line 107)
<https://reviews.apache.org/r/39576/#comment174338>
Why is this class required?
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java (line 155)
<https://reviews.apache.org/r/39576/#comment174339>
Add constructor with username, instead of setter.
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java (lines 199 - 202)
<https://reviews.apache.org/r/39576/#comment174340>
Not inside synchronized block ?
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java (lines 289 - 292)
<https://reviews.apache.org/r/39576/#comment174341>
Not synchronized?
lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java (line 28)
<https://reviews.apache.org/r/39576/#comment174342>
Typo in error code
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java (line 519)
<https://reviews.apache.org/r/39576/#comment174343>
Add test at resource level as well.
lens-server/src/test/resources/lens-site.xml (line 192)
<https://reviews.apache.org/r/39576/#comment174344>
Why 20? It should be lesser than the default as well.
- Amareshwari Sriramadasu
On Jan. 5, 2016, 12:42 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39576/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 12:42 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
>
>
> Bugs: LENS-833
> https://issues.apache.org/jira/browse/LENS-833
>
>
> Repository: lens
>
>
> Description
> -------
>
> Failing the open session operation if user creates more sessions than configured limit.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/ErrorCollectionFactory.java 741630b
> lens-api/src/main/resources/lens-errors.conf 06960a0
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 558e97f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 43d0722
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 32ed7b0
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 42c6bae
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 30f4ec1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 448d0f6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 9fce233
> lens-cli/src/test/java/org/apache/lens/cli/TestLensLogResourceCommands.java f4b043e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java d453803
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 8bccac2
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 88e5a01
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 0821fe7
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java dc20f0f
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 3ba5edd
> lens-server/src/main/resources/lensserver-default.xml cac641a
> lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 75f21e1
> lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java 8e22837
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java e0c0923
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 69c3f46
> lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 01e846a
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 3055ce5
> lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java 6f7c216
> lens-server/src/test/resources/lens-site.xml 9cb4a6f
> src/site/apt/admin/config.apt 54f827e
>
> Diff: https://reviews.apache.org/r/39576/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 39576: LENS-833 : Limit number of open sessions
per user on session service
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39576/
-----------------------------------------------------------
(Updated Jan. 5, 2016, 12:42 a.m.)
Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
Changes
-------
Acquie lock only on user as limiting sessions only user level(not at server level)
Bugs: LENS-833
https://issues.apache.org/jira/browse/LENS-833
Repository: lens
Description
-------
Failing the open session operation if user creates more sessions than configured limit.
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/error/ErrorCollectionFactory.java 741630b
lens-api/src/main/resources/lens-errors.conf 06960a0
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 558e97f
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 43d0722
lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 32ed7b0
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 42c6bae
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 30f4ec1
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 448d0f6
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 9fce233
lens-cli/src/test/java/org/apache/lens/cli/TestLensLogResourceCommands.java f4b043e
lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java d453803
lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 8bccac2
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 88e5a01
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 0821fe7
lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java dc20f0f
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 3ba5edd
lens-server/src/main/resources/lensserver-default.xml cac641a
lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 75f21e1
lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java 8e22837
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java e0c0923
lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 69c3f46
lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 01e846a
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 3055ce5
lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java 6f7c216
lens-server/src/test/resources/lens-site.xml 9cb4a6f
src/site/apt/admin/config.apt 54f827e
Diff: https://reviews.apache.org/r/39576/diff/
Testing
-------
Thanks,
Raju Bairishetti