[jira] [Resolved] (NIFI-6365) Creation of Controller Services should handle empty strings as it does nulls

["Otto Fowler (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/NIFI-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Otto Fowler resolved NIFI-6365.
-------------------------------
    Resolution: Won't Fix

This is working correctly. [~bbende] explained the reasoning behind it, as well as the generic structure of the way it is logically setup.

My concern is mainly with this being "known" behavior to the nifi developers, but not documented in the rest api's, or apparent to api  developers and sdks.  Counting on json to be well formed wrt nulls or "" etc, can be a mistake.

> Creation of Controller Services should handle empty strings as it does nulls
> ----------------------------------------------------------------------------
>
>                 Key: NIFI-6365
>                 URL: https://issues.apache.org/jira/browse/NIFI-6365
>             Project: Apache NiFi
>          Issue Type: Task
>            Reporter: Otto Fowler
>            Assignee: Otto Fowler
>            Priority: Major
>
> If the web api is passed service ids as empty strings instead of nulls, the result is an error that the service could not be found with id "".  This can be confusing, especially since the service id may not be the one being created, but rather something referenced.
> the api should treat empty strings the same as if they were nulls, either through a test, logically 
> {code:java}
> if ( controllerService.id() != null) {
>  ...
> }
> // should be 
> if ( !StringUtils.isNullOrEmpty(controllerService.id()) {
>  ...
> }
> {code}
> or something that explicitly cleans up the DTOs



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)