[GitHub] [airflow] dstandish commented on a diff in pull request #26739: Added Istio support to KubernetesPodOperator

[GitBox <gi...@apache.org>]

dstandish commented on code in PR #26739:
URL: https://github.com/apache/airflow/pull/26739#discussion_r1006188366


##########
airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py:
##########
@@ -453,7 +455,7 @@ def cleanup(self, pod: k8s.V1Pod, remote_pod: k8s.V1Pod):
         if not self.is_delete_operator_pod:
             with _suppress(Exception):
                 self.patch_already_checked(remote_pod)
-        if pod_phase != PodPhase.SUCCEEDED:
+        if (not self.istio_enabled and pod_phase != PodPhase.SUCCEEDED) or (self.istio_enabled and pod_phase != PodPhase.SUCCEEDED and not self.pod_manager.container_is_succeeded(pod, 'base')):

Review Comment:
   you will need to enable pre-commit locally see https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org