You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by we...@apache.org on 2021/02/22 13:30:33 UTC
[spark] branch branch-3.1 updated: [MINOR][SQL] Fix the comment for
CalendarIntervalType about comparability
This is an automated email from the ASF dual-hosted git repository.
wenchen pushed a commit to branch branch-3.1
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-3.1 by this push:
new 847c40a [MINOR][SQL] Fix the comment for CalendarIntervalType about comparability
847c40a is described below
commit 847c40af62d6704250c0ac6361e49cc555a99ad0
Author: Max Gekk <ma...@gmail.com>
AuthorDate: Mon Feb 22 21:29:14 2021 +0800
[MINOR][SQL] Fix the comment for CalendarIntervalType about comparability
### What changes were proposed in this pull request?
In the PR, I propose to revert https://github.com/apache/spark/pull/26659 partially regarding to comparability of interval values. The comment became incorrect after https://github.com/apache/spark/pull/27262.
### Why are the changes needed?
The comment is incorrect, and it might confuse Spark's devs/users.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
By checking scala coding style `./dev/scalastyle`.
Closes #31610 from MaxGekk/doc-interval-not-comparable.
Authored-by: Max Gekk <ma...@gmail.com>
Signed-off-by: Wenchen Fan <we...@databricks.com>
(cherry picked from commit 7df4fed420c1164e5e025ebce525850c025d9400)
Signed-off-by: Wenchen Fan <we...@databricks.com>
---
.../main/scala/org/apache/spark/sql/types/CalendarIntervalType.scala | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/types/CalendarIntervalType.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/types/CalendarIntervalType.scala
index 35ad864..d506a15 100644
--- a/sql/catalyst/src/main/scala/org/apache/spark/sql/types/CalendarIntervalType.scala
+++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/types/CalendarIntervalType.scala
@@ -28,7 +28,7 @@ import org.apache.spark.annotation.Stable
*
* Please use the singleton `DataTypes.CalendarIntervalType` to refer the type.
*
- * @note Calendar intervals support comparison and ordering since 3.0.0.
+ * @note Calendar intervals are not comparable.
*
* @since 1.5.0
*/
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org