You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@logging.apache.org by gg...@apache.org on 2013/10/10 19:36:05 UTC

svn commit: r1531054 - /logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/SystemPropertiesLookup.java

Author: ggregory
Date: Thu Oct 10 17:36:04 2013
New Revision: 1531054

URL: http://svn.apache.org/r1531054
Log:
Comment: shouldn't we log exceptions here?

Modified:
    logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/SystemPropertiesLookup.java

Modified: logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/SystemPropertiesLookup.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/SystemPropertiesLookup.java?rev=1531054&r1=1531053&r2=1531054&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/SystemPropertiesLookup.java (original)
+++ logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/SystemPropertiesLookup.java Thu Oct 10 17:36:04 2013
@@ -35,6 +35,7 @@ public class SystemPropertiesLookup impl
         try {
             return System.getProperty(key);
         } catch (final Exception ex) {
+            // Should this be logged?
             return null;
         }
     }
@@ -50,6 +51,7 @@ public class SystemPropertiesLookup impl
         try {
             return System.getProperty(key);
         } catch (final Exception ex) {
+            // Should this be logged?
             return null;
         }
     }