You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/18 01:57:30 UTC

[GitHub] [camel-website] djencks opened a new pull request #230: Resolves camel-14731. Rearrange sources to use Antora structure more effectively

djencks opened a new pull request #230: Resolves camel-14731. Rearrange sources to use Antora structure more effectively
URL: https://github.com/apache/camel-website/pull/230
 
 
   This renames the playbook to current standard name "antora-playbook.yml" and adjusts the sources to find the components as they are in the other 3 PRs in this set of tasks.  This playbook will only work after the other three PRs are merged.  Before that, use the antora-playbook.yml from https://github.com/djencks/camel-website.git branch issue-14698-rearrange-adocs.  Because of this, this PR is untested. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] oscerd commented on issue #230: Resolves camel-14731. Rearrange sources to use Antora structure more effectively

Posted by GitBox <gi...@apache.org>.
oscerd commented on issue #230: Resolves camel-14731. Rearrange sources to use Antora structure more effectively
URL: https://github.com/apache/camel-website/pull/230#issuecomment-601254373
 
 
   The preview is here https://builds.apache.org/job/Camel.website/job/PR-230/Preview @davsclaus @djencks @zregvart 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] oscerd commented on issue #230: Resolves camel-14731. Rearrange sources to use Antora structure more effectively

Posted by GitBox <gi...@apache.org>.
oscerd commented on issue #230: Resolves camel-14731. Rearrange sources to use Antora structure more effectively
URL: https://github.com/apache/camel-website/pull/230#issuecomment-601275761
 
 
   Eventually we can rework this, let me try to deploy the new site. Thanks @djencks 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] davsclaus commented on issue #230: Resolves camel-14731. Rearrange sources to use Antora structure more effectively

Posted by GitBox <gi...@apache.org>.
davsclaus commented on issue #230: Resolves camel-14731. Rearrange sources to use Antora structure more effectively
URL: https://github.com/apache/camel-website/pull/230#issuecomment-601275174
 
 
   +1

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] oscerd commented on issue #230: Resolves camel-14731. Rearrange sources to use Antora structure more effectively

Posted by GitBox <gi...@apache.org>.
oscerd commented on issue #230: Resolves camel-14731. Rearrange sources to use Antora structure more effectively
URL: https://github.com/apache/camel-website/pull/230#issuecomment-601222400
 
 
   ok to test

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] oscerd commented on issue #230: Resolves camel-14731. Rearrange sources to use Antora structure more effectively

Posted by GitBox <gi...@apache.org>.
oscerd commented on issue #230: Resolves camel-14731. Rearrange sources to use Antora structure more effectively
URL: https://github.com/apache/camel-website/pull/230#issuecomment-601274376
 
 
   Looks good to me. Waiting for @davsclaus and @zregvart comment

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] oscerd commented on a change in pull request #230: Resolves camel-14731. Rearrange sources to use Antora structure more effectively

Posted by GitBox <gi...@apache.org>.
oscerd commented on a change in pull request #230: Resolves camel-14731. Rearrange sources to use Antora structure more effectively
URL: https://github.com/apache/camel-website/pull/230#discussion_r395102827
 
 

 ##########
 File path: antora-playbook.yml
 ##########
 @@ -1,14 +1,23 @@
 site:
   title: Apache Camel
   url: https://camel.apache.org
-  start_page: manual::index.adoc
+  start_page: latest@manual::index.adoc
 
 content:
   sources:
-    - url: git@github.com:apache/camel.git
+    - url: https://github.com/djencks/camel.git
 
 Review comment:
   fixed here https://github.com/apache/camel-website/pull/240

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] oscerd commented on issue #230: Resolves camel-14731. Rearrange sources to use Antora structure more effectively

Posted by GitBox <gi...@apache.org>.
oscerd commented on issue #230: Resolves camel-14731. Rearrange sources to use Antora structure more effectively
URL: https://github.com/apache/camel-website/pull/230#issuecomment-601054791
 
 
   @djencks this doesn't seem to work actually 
   
   [2020-03-18T18:44:20.210Z] + cd /home/jenkins/jenkins-slave/workspace/Camel.website_PR-230/camel-website
   [2020-03-18T18:44:20.210Z] + yarn --non-interactive --frozen-lockfile build
   [2020-03-18T18:44:20.795Z] yarn run v1.22.0
   [2020-03-18T18:44:20.795Z] $ run-s build:*
   [2020-03-18T18:44:21.382Z] $ antora --require ./menu.js --clean --fetch antora-playbook.yml
   [2020-03-18T18:45:58.129Z] error: core/camel-core-languages/src/main/docs/antora.yml not found in https://github.com/djencks/camel.git [ref: remotes/origin/master]
   [2020-03-18T18:45:58.130Z] Add the --stacktrace option to see the cause.
   [2020-03-18T18:45:58.130Z] error Command failed with exit code 1.
   [2020-03-18T18:45:58.130Z] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
   [2020-03-18T18:45:58.130Z] ERROR: "build:antora" exited with 1.
   [2020-03-18T18:45:58.130Z] error Command failed with exit code 1.
   [2020-03-18T18:45:58.130Z] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
   
   I suppose this is because it is pointing to your fork of camel and it's not up-to-date

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] djencks commented on a change in pull request #230: Resolves camel-14731. Rearrange sources to use Antora structure more effectively

Posted by GitBox <gi...@apache.org>.
djencks commented on a change in pull request #230: Resolves camel-14731. Rearrange sources to use Antora structure more effectively
URL: https://github.com/apache/camel-website/pull/230#discussion_r395084569
 
 

 ##########
 File path: antora-playbook.yml
 ##########
 @@ -1,14 +1,23 @@
 site:
   title: Apache Camel
   url: https://camel.apache.org
-  start_page: manual::index.adoc
+  start_page: latest@manual::index.adoc
 
 content:
   sources:
-    - url: git@github.com:apache/camel.git
+    - url: https://github.com/djencks/camel.git
 
 Review comment:
   OOPS!  I pushed a fix that works OK for me locally.
   
   BTW when I run mvn clean install and then git status there are an enormous number of files deleted from static.  Is this expected?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] oscerd commented on issue #230: Resolves camel-14731. Rearrange sources to use Antora structure more effectively

Posted by GitBox <gi...@apache.org>.
oscerd commented on issue #230: Resolves camel-14731. Rearrange sources to use Antora structure more effectively
URL: https://github.com/apache/camel-website/pull/230#issuecomment-601223259
 
 
   Started the job by hand.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] oscerd commented on a change in pull request #230: Resolves camel-14731. Rearrange sources to use Antora structure more effectively

Posted by GitBox <gi...@apache.org>.
oscerd commented on a change in pull request #230: Resolves camel-14731. Rearrange sources to use Antora structure more effectively
URL: https://github.com/apache/camel-website/pull/230#discussion_r395093627
 
 

 ##########
 File path: antora-playbook.yml
 ##########
 @@ -1,14 +1,23 @@
 site:
   title: Apache Camel
   url: https://camel.apache.org
-  start_page: manual::index.adoc
+  start_page: latest@manual::index.adoc
 
 content:
   sources:
-    - url: git@github.com:apache/camel.git
+    - url: https://github.com/djencks/camel.git
 
 Review comment:
   No, this shouldn't happen. I can reproduce it locally and I don't know why. The schemas must be there as all the static content.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] oscerd commented on a change in pull request #230: Resolves camel-14731. Rearrange sources to use Antora structure more effectively

Posted by GitBox <gi...@apache.org>.
oscerd commented on a change in pull request #230: Resolves camel-14731. Rearrange sources to use Antora structure more effectively
URL: https://github.com/apache/camel-website/pull/230#discussion_r395094336
 
 

 ##########
 File path: antora-playbook.yml
 ##########
 @@ -1,14 +1,23 @@
 site:
   title: Apache Camel
   url: https://camel.apache.org
-  start_page: manual::index.adoc
+  start_page: latest@manual::index.adoc
 
 content:
   sources:
-    - url: git@github.com:apache/camel.git
+    - url: https://github.com/djencks/camel.git
 
 Review comment:
   So please don't push that part and otherwise open an issue for this, so we can double check why

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] oscerd commented on a change in pull request #230: Resolves camel-14731. Rearrange sources to use Antora structure more effectively

Posted by GitBox <gi...@apache.org>.
oscerd commented on a change in pull request #230: Resolves camel-14731. Rearrange sources to use Antora structure more effectively
URL: https://github.com/apache/camel-website/pull/230#discussion_r394871690
 
 

 ##########
 File path: antora-playbook.yml
 ##########
 @@ -1,14 +1,23 @@
 site:
   title: Apache Camel
   url: https://camel.apache.org
-  start_page: manual::index.adoc
+  start_page: latest@manual::index.adoc
 
 content:
   sources:
-    - url: git@github.com:apache/camel.git
+    - url: https://github.com/djencks/camel.git
 
 Review comment:
   We need to change the repository to have a full test. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] oscerd merged pull request #230: Resolves camel-14731. Rearrange sources to use Antora structure more effectively

Posted by GitBox <gi...@apache.org>.
oscerd merged pull request #230: Resolves camel-14731. Rearrange sources to use Antora structure more effectively
URL: https://github.com/apache/camel-website/pull/230
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services