You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/05/18 00:56:48 UTC
[GitHub] [iceberg] kbendick opened a new pull request, #4798: Build - Add an explicit workflow for API binary compatibility checks
kbendick opened a new pull request, #4798:
URL: https://github.com/apache/iceberg/pull/4798
The API / ABI compatibility checking tool, `revapi`, is supposed to run whenever we run `./gradlew build` or `./gradlew check`.
However, for some reason - likely due to caching, this is getting skipped as can be verified in this example PR: https://github.com/apache/iceberg/pull/4796
That PR shows that the output of `./gradlew -DflinkVersions=1.13,1.14,1.15 -DsparkVersions=2.4,3.0,3.1,3.2 -DhiveVersions=2,3 build -x test -x javadoc -x integrationTest`, which is run during `Java CI`, should run `revapi`. However, `revapi` is being skipped in that step per the log output.
For the moment, I'm adding an explicit `API Binary Compatibility` workflow to circumvent this issue.
cc @rdblue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #4798: Infra - Add an explicit workflow for API binary compatibility checks
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #4798:
URL: https://github.com/apache/iceberg/pull/4798#discussion_r878897250
##########
.github/workflows/api-binary-compatibility.yml:
##########
@@ -0,0 +1,61 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: "API Binary Compatibility Checks"
+on:
+ push:
+ branches:
+ - 'master'
+ - '0.**'
+ tags:
+ - 'apache-iceberg-**'
+ pull_request:
+ paths:
+ - 'api/**'
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}
+ cancel-in-progress: ${{ github.event_name == 'pull_request' }}
+
+jobs:
+ revapi:
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ jvm: [8, 11]
+ env:
+ SPARK_LOCAL_IP: localhost
+ steps:
+ - uses: actions/checkout@v2
+ - uses: actions/setup-java@v1
+ with:
+ java-version: ${{ matrix.jvm }}
+ - uses: actions/cache@v2
+ with:
+ path: ~/.gradle/caches
+ key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle') }}
+ restore-keys: ${{ runner.os }}-gradle
+ - run: echo -e "$(ip addr show eth0 | grep "inet\b" | awk '{print $2}' | cut -d/ -f1)\t$(hostname -f) $(hostname -s)" | sudo tee -a /etc/hosts
Review Comment:
This looks like it was probably pasted from another workflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #4798: Infra - Add an explicit workflow for API binary compatibility checks
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #4798:
URL: https://github.com/apache/iceberg/pull/4798#discussion_r878897073
##########
.github/workflows/api-binary-compatibility.yml:
##########
@@ -0,0 +1,61 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: "API Binary Compatibility Checks"
+on:
+ push:
+ branches:
+ - 'master'
+ - '0.**'
+ tags:
+ - 'apache-iceberg-**'
+ pull_request:
+ paths:
+ - 'api/**'
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}
+ cancel-in-progress: ${{ github.event_name == 'pull_request' }}
+
+jobs:
+ revapi:
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ jvm: [8, 11]
Review Comment:
Is this necessary? I don't think that binary compatibility changes that much across JVM versions. It should be fine to run with just 11.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #4798: Infra - Add an explicit workflow for API binary compatibility checks
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #4798:
URL: https://github.com/apache/iceberg/pull/4798#discussion_r878897105
##########
.github/workflows/api-binary-compatibility.yml:
##########
@@ -0,0 +1,61 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: "API Binary Compatibility Checks"
+on:
+ push:
+ branches:
+ - 'master'
+ - '0.**'
+ tags:
+ - 'apache-iceberg-**'
+ pull_request:
+ paths:
+ - 'api/**'
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}
+ cancel-in-progress: ${{ github.event_name == 'pull_request' }}
+
+jobs:
+ revapi:
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ jvm: [8, 11]
+ env:
+ SPARK_LOCAL_IP: localhost
Review Comment:
This shouldn't run any Spark jobs. Is this needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a diff in pull request #4798: Infra - Add an explicit workflow for API binary compatibility checks
Posted by GitBox <gi...@apache.org>.
kbendick commented on code in PR #4798:
URL: https://github.com/apache/iceberg/pull/4798#discussion_r884032107
##########
.github/workflows/api-binary-compatibility.yml:
##########
@@ -0,0 +1,61 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: "API Binary Compatibility Checks"
+on:
+ push:
+ branches:
+ - 'master'
+ - '0.**'
+ tags:
+ - 'apache-iceberg-**'
+ pull_request:
+ paths:
+ - 'api/**'
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}
+ cancel-in-progress: ${{ github.event_name == 'pull_request' }}
+
+jobs:
+ revapi:
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ jvm: [8, 11]
+ env:
+ SPARK_LOCAL_IP: localhost
Review Comment:
No it's not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #4798: Infra - Add an explicit workflow for API binary compatibility checks
Posted by GitBox <gi...@apache.org>.
rdblue merged PR #4798:
URL: https://github.com/apache/iceberg/pull/4798
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #4798: Infra - Add an explicit workflow for API binary compatibility checks
Posted by GitBox <gi...@apache.org>.
rdblue commented on PR #4798:
URL: https://github.com/apache/iceberg/pull/4798#issuecomment-1140487409
Thanks, @kbendick! Do we also need to remove the checks from running in another workflow?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a diff in pull request #4798: Infra - Add an explicit workflow for API binary compatibility checks
Posted by GitBox <gi...@apache.org>.
kbendick commented on code in PR #4798:
URL: https://github.com/apache/iceberg/pull/4798#discussion_r884032204
##########
.github/workflows/api-binary-compatibility.yml:
##########
@@ -0,0 +1,61 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: "API Binary Compatibility Checks"
+on:
+ push:
+ branches:
+ - 'master'
+ - '0.**'
+ tags:
+ - 'apache-iceberg-**'
+ pull_request:
+ paths:
+ - 'api/**'
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}
+ cancel-in-progress: ${{ github.event_name == 'pull_request' }}
+
+jobs:
+ revapi:
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ jvm: [8, 11]
+ env:
+ SPARK_LOCAL_IP: localhost
+ steps:
+ - uses: actions/checkout@v2
+ - uses: actions/setup-java@v1
+ with:
+ java-version: ${{ matrix.jvm }}
+ - uses: actions/cache@v2
+ with:
+ path: ~/.gradle/caches
+ key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle') }}
+ restore-keys: ${{ runner.os }}-gradle
+ - run: echo -e "$(ip addr show eth0 | grep "inet\b" | awk '{print $2}' | cut -d/ -f1)\t$(hostname -f) $(hostname -s)" | sudo tee -a /etc/hosts
Review Comment:
This is in pretty much _every_ workflow that we have that I've checked. But I don't think it's needed. Let's try without and see. We can always add it in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org