You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by wu...@apache.org on 2019/04/09 10:18:18 UTC
[incubator-skywalking] branch master updated: Support shutdown the
trace analysis. (#2463)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new 9ab568f Support shutdown the trace analysis. (#2463)
9ab568f is described below
commit 9ab568faf240713e8c8ce07787ddbad922d08d7c
Author: 吴晟 Wu Sheng <wu...@foxmail.com>
AuthorDate: Tue Apr 9 18:18:13 2019 +0800
Support shutdown the trace analysis. (#2463)
---
.../server/receiver/trace/provider/TraceModuleProvider.java | 12 ++++++++----
.../receiver/trace/provider/TraceServiceModuleConfig.java | 8 ++++++++
2 files changed, 16 insertions(+), 4 deletions(-)
diff --git a/oap-server/server-receiver-plugin/skywalking-trace-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/trace/provider/TraceModuleProvider.java b/oap-server/server-receiver-plugin/skywalking-trace-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/trace/provider/TraceModuleProvider.java
index e346503..a47ec32 100644
--- a/oap-server/server-receiver-plugin/skywalking-trace-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/trace/provider/TraceModuleProvider.java
+++ b/oap-server/server-receiver-plugin/skywalking-trace-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/trace/provider/TraceModuleProvider.java
@@ -63,15 +63,19 @@ public class TraceModuleProvider extends ModuleProvider {
moduleConfig.setDbLatencyThresholds(new DBLatencyThresholds(moduleConfig.getSlowDBAccessThreshold()));
SegmentParserListenerManager listenerManager = new SegmentParserListenerManager();
- listenerManager.add(new MultiScopesSpanListener.Factory());
- listenerManager.add(new ServiceMappingSpanListener.Factory());
+ if (moduleConfig.isTraceAnalysis()) {
+ listenerManager.add(new MultiScopesSpanListener.Factory());
+ listenerManager.add(new ServiceMappingSpanListener.Factory());
+ }
listenerManager.add(new SegmentSpanListener.Factory(moduleConfig.getSampleRate()));
segmentProducer = new SegmentParse.Producer(getManager(), listenerManager, moduleConfig);
listenerManager = new SegmentParserListenerManager();
- listenerManager.add(new MultiScopesSpanListener.Factory());
- listenerManager.add(new ServiceMappingSpanListener.Factory());
+ if (moduleConfig.isTraceAnalysis()) {
+ listenerManager.add(new MultiScopesSpanListener.Factory());
+ listenerManager.add(new ServiceMappingSpanListener.Factory());
+ }
listenerManager.add(new SegmentSpanListener.Factory(moduleConfig.getSampleRate()));
segmentProducerV2 = new SegmentParseV2.Producer(getManager(), listenerManager, moduleConfig);
diff --git a/oap-server/server-receiver-plugin/skywalking-trace-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/trace/provider/TraceServiceModuleConfig.java b/oap-server/server-receiver-plugin/skywalking-trace-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/trace/provider/TraceServiceModuleConfig.java
index 8ebeec6..fce1ca7 100644
--- a/oap-server/server-receiver-plugin/skywalking-trace-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/trace/provider/TraceServiceModuleConfig.java
+++ b/oap-server/server-receiver-plugin/skywalking-trace-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/trace/provider/TraceServiceModuleConfig.java
@@ -39,4 +39,12 @@ public class TraceServiceModuleConfig extends ModuleConfig {
*/
@Setter @Getter private String slowDBAccessThreshold = "default:200";
@Setter @Getter private DBLatencyThresholds dbLatencyThresholds;
+ /**
+ * Analysis trace status.
+ *
+ * 1. Default(YES) means analysis all metric from trace.
+ *
+ * 2. NO means, only save trace, but metrics come other places, such as service mesh.
+ */
+ @Setter @Getter private boolean traceAnalysis = true;
}