You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@incubator.apache.org by Seetharam Venkatesh <ve...@innerzeal.com> on 2014/05/19 23:09:56 UTC

[VOTE] Release Apache Falcon version 0.5-incubating

Hello folks,

This is a call for a vote on Apache Falcon 0.5 incubating release.

A vote was held on developer mailing list and it passed with 8 +1's.

Vote thread: http://s.apache.org/xtf
Results thread: Apache mail is slow and do not see it in archives after 2
days.

The source tarball (*.tar.gz), signature (*.asc), checksum (*.md5, *.sha):
http://people.apache.org/~venkatesh/falcon-0.5-incubating-rc2/source/

The SHA1 checksum of the archive is cf076dba0c3eea436916dbe10846dfeac471c183

The release has been signed through key(42C7A5EA):
http://pgp.mit.edu:11371/pks/lookup?op=vindex&search=0x1B16738C42C7A5EA

The tag to be voted upon:
https://git-wip-us.apache.org/repos/asf?p=incubator-falcon
.git;a=tag;h=refs/tags/release-0.5-rc2

The list of fixed issues:
https://git-wip-us.apache.org/repos/asf?p=incubator-falcon
.git;a=blob;f=CHANGES.txt;h=34ec2893b666c22f2a5977ca08b966b751e37e21;hb=refs/tags/release-0.5-rc2

Keys to verify the signature of the release artifact are available at:
http://www.apache.org/dist/incubator/falcon/KEYS
PGP release keys:
http://pgp.mit.edu/pks/lookup?op=vindex&search=0x1B16738C42C7A5EA

Note that this is a source only release and we are voting on the source.
Checksums:

SHA1 (release-0.5-incubating-rc2 / SHA:
cf076dba0c3eea436916dbe10846dfeac471c183)
MD5 (falcon-0.5-incubating-sources.tar.gz) =
6f6b57d1185e96e67ff628f4cb021455

Vote will be open for 72 hours.

[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove (and reason why)

-- 
Regards,
Venkatesh

“Perfection (in design) is achieved not when there is nothing more to add,
but rather when there is nothing more to take away.”
- Antoine de Saint-Exupéry

Re: [VOTE] Release Apache Falcon version 0.5-incubating

Posted by sebb <se...@gmail.com>.
On 19 May 2014 22:09, Seetharam Venkatesh <ve...@innerzeal.com> wrote:
> Hello folks,
>
> This is a call for a vote on Apache Falcon 0.5 incubating release.
>
> A vote was held on developer mailing list and it passed with 8 +1's.
>
> Vote thread: http://s.apache.org/xtf
> Results thread: Apache mail is slow and do not see it in archives after 2
> days.
>
> The source tarball (*.tar.gz), signature (*.asc), checksum (*.md5, *.sha):
> http://people.apache.org/~venkatesh/falcon-0.5-incubating-rc2/source/
>
> The SHA1 checksum of the archive is cf076dba0c3eea436916dbe10846dfeac471c183
>
> The release has been signed through key(42C7A5EA):
> http://pgp.mit.edu:11371/pks/lookup?op=vindex&search=0x1B16738C42C7A5EA
>
> The tag to be voted upon:
> https://git-wip-us.apache.org/repos/asf?p=incubator-falcon
> .git;a=tag;h=refs/tags/release-0.5-rc2

NOTICE file is incorrect; it must not have the following header:

=========================================================================
==  NOTICE file corresponding to the section 4 d of                    ==
==  the Apache License, Version 2.0,                                   ==
==  in this case for the Apache Falcon distribution.                   ==
=========================================================================

Also the NOTICE file must ONLY contain required notices for files that
are actually in the enclosing distribution.
As such, the entries headed "This product includes/uses" are wrong;
only *included* bits are relevant when determining what must go in the
NOTICE file.

The LICENSE file should specify the versions of the included software,
because licenses may change between versions.
Again, only included code should be referenced.

> The list of fixed issues:
> https://git-wip-us.apache.org/repos/asf?p=incubator-falcon
> .git;a=blob;f=CHANGES.txt;h=34ec2893b666c22f2a5977ca08b966b751e37e21;hb=refs/tags/release-0.5-rc2
>
> Keys to verify the signature of the release artifact are available at:
> http://www.apache.org/dist/incubator/falcon/KEYS

It would be helpful to include a header for each key entry, as per

http://www.apache.org/dist/incubator/amber/KEYS

> PGP release keys:
> http://pgp.mit.edu/pks/lookup?op=vindex&search=0x1B16738C42C7A5EA
>
> Note that this is a source only release and we are voting on the source.
> Checksums:
>
> SHA1 (release-0.5-incubating-rc2 / SHA:
> cf076dba0c3eea436916dbe10846dfeac471c183)
> MD5 (falcon-0.5-incubating-sources.tar.gz) =
> 6f6b57d1185e96e67ff628f4cb021455
>
> Vote will be open for 72 hours.
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
>
> --
> Regards,
> Venkatesh
>
> “Perfection (in design) is achieved not when there is nothing more to add,
> but rather when there is nothing more to take away.”
> - Antoine de Saint-Exupéry

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Re: [VOTE] Release Apache Falcon version 0.5-incubating

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

> We will take care of this for the next release. Is this a blocker for the
> release?
I'm willing to see other people thoughts on it - but it's likely to be so.

I am also willing to change my vote if someone with more experience than me says it's OK for now.

>> There's a binary in the release
> This is in test source and is used to run a workflow which only uses jar
> files. Again, since this is part of test code, is this a blocker for the
> release?
IMO yes having a jar in a source release is a blocker - even if it is used for testing.

It there anyway you can include the source and/or compile it?

> You mean the file names in the release should have apache as the prefix?
It's not mandated but does give some extra legal protection.[1]

> Maven Doxia plugin fails to convert to html if we add the headers. Will
> explore.
Perhaps add a README or similar that states all files in this directory are under ALv2 and the reason why the headers can't be added?

Thanks,
Justin

1. http://incubator.apache.org/guides/releasemanagement.html#best-practice
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Re: [VOTE] Release Apache Falcon version 0.5-incubating

Posted by Seetharam Venkatesh <ve...@innerzeal.com>.
Hi Justin,

Thanks for reviewing the release artifacts.

> NOTICE and LICENCE seem to contain too much (see believe)
We will take care of this for the next release. Is this a blocker for the
release?

> There's a binary in the release
This is in test source and is used to run a workflow which only uses jar
files. Again, since this is part of test code, is this a blocker for the
release?

Some minor issues:
> - release is missing "apache" in it filename
You mean the file names in the release should have apache as the prefix?

> - DISCLAIMER, CHANGES, LICENSE, NOTICE etc don't usually have .txt suffix
Will fix.

> - Seems that you can only compile with Java 1.6 and not 1.7  this should
be mentioned in the release notes
Will add.

> - The compile instructions assume you are checking out from version
control rather than compiling the source release
Will add

> - .twik documentation files may need ALv2 headers
Maven Doxia plugin fails to convert to html if we add the headers. Will
explore.

Thanks for your time!



On Fri, May 23, 2014 at 9:37 AM, Justin Mclean <ju...@classsoftware.com>wrote:

> Hi,
>
> Sorry for to mention the binary in question is:
> webapp/src/test/resources/org/apache/falcon/logging/java-test.jar
>
> Thanks,
> Justin
>
>


-- 
Regards,
Venkatesh

“Perfection (in design) is achieved not when there is nothing more to add,
but rather when there is nothing more to take away.”
- Antoine de Saint-Exupéry

Re: [VOTE] Release Apache Falcon version 0.5-incubating

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

Sorry for to mention the binary in question is:
webapp/src/test/resources/org/apache/falcon/logging/java-test.jar

Thanks,
Justin


Re: [VOTE] Release Apache Falcon version 0.5-incubating

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

-1 (binding) due to binary in the release + possible LICENSE/NOTICE issues

Signature + hashes good
DISCLAIMER correct
NOTICE and LICENCE seem to contain too much (see believe)
All source files  have correct headers
There's a binary in the release
Can compile from source
Test pass

What external code has been bundled with the source? To me it look like the NOTICE file may be referring to a binary release not the source release? For example it mentions antlr in the NOTICE file but I can't find any antlr code in the source release. As antlr is BSD does it even need to be in NOTICE file?  It's may be that all source files have had their headers changed to ALv2?

I also not the use of some fonts (from http://glyphicons.com?) and while they are included in the NOTICE but I'm not sure how they have been licensed. If it the free version and if so have the terms of the license met? [1]

Some minor issues:
- release is missing "apache" in it filename
- DISCLAIMER, CHANGES, LICENSE, NOTICE etc don't usually have .txt suffix
- Seems that you can only compile with Java 1.6 and not 1.7  this should be mentioned in the release notes 
- The compile instructions assume you are checking out from version control rather than compiling the source release
- .twik documentation files may need ALv2 headers

Thanks,
Justin

1. http://glyphicons.com/license/
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org