You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/06/14 13:24:43 UTC

[GitHub] [systemds] sebwrede commented on a change in pull request #1314: [SYSTEMDS-2982] Federated instructions w/ multiple aligned matrices

sebwrede commented on a change in pull request #1314:
URL: https://github.com/apache/systemds/pull/1314#discussion_r650943547



##########
File path: src/main/java/org/apache/sysds/runtime/instructions/cp/SpoofCPInstruction.java
##########
@@ -138,34 +136,6 @@ public boolean isFederated(ExecutionContext ec) {
 	}
 	
 	public boolean isFederated(ExecutionContext ec, FType type) {

Review comment:
       It seems a bit counter-intuitive that a CP instruction has an `isFederated` method. Could we move this to `FedInstructionUtils.checkAndReplaceCP` which I believe is the only place where a call to `isFederated` is needed. Now that you cut the internals of the method to a single line this should be easy. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org