You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@apr.apache.org by jo...@apache.org on 2024/08/08 13:17:14 UTC

svn commit: r1919740 - /apr/apr/trunk/shmem/unix/shm.c

Author: jorton
Date: Thu Aug  8 13:17:14 2024
New Revision: 1919740

URL: http://svn.apache.org/viewvc?rev=1919740&view=rev
Log:
* shmem/unix/shm.c (apr_shm_perms_set): Omit the POSIX shm
  implementation on MacOS (falling through to ENOTIMPL instead), since
  it is either failing or hanging in testing.

See https://lists.apache.org/thread/1gj7j8h0nxlly2j2gnrbh6m7sy4o0fob

Modified:
    apr/apr/trunk/shmem/unix/shm.c

Modified: apr/apr/trunk/shmem/unix/shm.c
URL: http://svn.apache.org/viewvc/apr/apr/trunk/shmem/unix/shm.c?rev=1919740&r1=1919739&r2=1919740&view=diff
==============================================================================
--- apr/apr/trunk/shmem/unix/shm.c (original)
+++ apr/apr/trunk/shmem/unix/shm.c Thu Aug  8 13:17:14 2024
@@ -706,7 +706,9 @@ APR_PERMS_SET_IMPLEMENT(shm)
         return errno;
     }
     return APR_SUCCESS;
-#elif APR_USE_SHMEM_MMAP_SHM
+#elif APR_USE_SHMEM_MMAP_SHM && !defined(DARWIN)
+    /* ### This hangs or fails on MacOS, so skipping this for the
+     * ENOTIMPL case there - unclear why or if that's fixable. */
     apr_shm_t *shm = (apr_shm_t *)theshm;
     const char *shm_name;
     int fd;