You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/02/25 13:20:24 UTC
[GitHub] [hive] kgyrtkirk commented on a change in pull request #2020: [WIP] HIVE-24445: Non blocking DROP table implementation
kgyrtkirk commented on a change in pull request #2020:
URL: https://github.com/apache/hive/pull/2020#discussion_r582821814
##########
File path: standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
##########
@@ -585,8 +585,8 @@ struct Table {
22: optional byte accessType,
23: optional list<string> requiredReadCapabilities,
24: optional list<string> requiredWriteCapabilities
- 25: optional i64 id, // id of the table. It will be ignored if set. It's only for
- // read purposed
+ 25: optional i64 id, // id of the table. It will be ignored if set. It's only for read purposed
Review comment:
nit: didn't this should be `purposes`?
##########
File path: standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
##########
@@ -585,8 +585,8 @@ struct Table {
22: optional byte accessType,
23: optional list<string> requiredReadCapabilities,
24: optional list<string> requiredWriteCapabilities
- 25: optional i64 id, // id of the table. It will be ignored if set. It's only for
- // read purposed
+ 25: optional i64 id, // id of the table. It will be ignored if set. It's only for read purposed
+ 26: optional i64 txnid,
Review comment:
this interface seems to follow `camelCase` naming - I think this field should be named `txnId`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org