You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Tobias Bocanegra (JIRA)" <ji...@apache.org> on 2008/01/26 18:51:34 UTC
[jira] Created: (SLING-205) launcher/app and
launchpad/launchpad-webapp delete 'sling' directory when invoking from
sling-builder
launcher/app and launchpad/launchpad-webapp delete 'sling' directory when invoking from sling-builder
-----------------------------------------------------------------------------------------------------
Key: SLING-205
URL: https://issues.apache.org/jira/browse/SLING-205
Project: Sling
Issue Type: Bug
Reporter: Tobias Bocanegra
the clean plugin does not correctly handle relative paths in the additional fileset configuration and uses them PWD relative. the launcher/app and the launchpad-webapp have an additional fileset config to delete the 'sling' working directory.
when invoking a mvn clean inside the builder removes the 'sling' code directory if those modules are not excluded from build.
the fix is to add the ${basedir} explicitly in the config:
Index: launcher/app/pom.xml
===================================================================
--- launcher/app/pom.xml (revision 615464)
+++ launcher/app/pom.xml (working copy)
@@ -61,7 +61,7 @@
<configuration>
<filesets>
<fileset>
- <directory>sling</directory>
+ <directory>${basedir}/sling</directory>
</fileset>
</filesets>
</configuration>
Index: launchpad/launchpad-webapp/pom.xml
===================================================================
--- launchpad/launchpad-webapp/pom.xml (revision 615464)
+++ launchpad/launchpad-webapp/pom.xml (working copy)
@@ -79,7 +79,7 @@
<configuration>
<filesets>
<fileset>
- <directory>sling</directory>
+ <directory>${basedir}/sling</directory>
</fileset>
</filesets>
</configuration>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-205) launcher/app and
launchpad/launchpad-webapp delete 'sling' directory when invoking from
sling-builder
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler updated SLING-205:
-----------------------------------
Assignee: Carsten Ziegeler
Remaining Estimate: 0h
Original Estimate: 0h
> launcher/app and launchpad/launchpad-webapp delete 'sling' directory when invoking from sling-builder
> -----------------------------------------------------------------------------------------------------
>
> Key: SLING-205
> URL: https://issues.apache.org/jira/browse/SLING-205
> Project: Sling
> Issue Type: Bug
> Reporter: Tobias Bocanegra
> Assignee: Carsten Ziegeler
> Attachments: lp-webapp-it-fix.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> the clean plugin does not correctly handle relative paths in the additional fileset configuration and uses them PWD relative. the launcher/app and the launchpad-webapp have an additional fileset config to delete the 'sling' working directory.
> when invoking a mvn clean inside the builder removes the 'sling' code directory if those modules are not excluded from build.
> the fix is to add the ${basedir} explicitly in the config:
> Index: launcher/app/pom.xml
> ===================================================================
> --- launcher/app/pom.xml (revision 615464)
> +++ launcher/app/pom.xml (working copy)
> @@ -61,7 +61,7 @@
> <configuration>
> <filesets>
> <fileset>
> - <directory>sling</directory>
> + <directory>${basedir}/sling</directory>
> </fileset>
> </filesets>
> </configuration>
> Index: launchpad/launchpad-webapp/pom.xml
> ===================================================================
> --- launchpad/launchpad-webapp/pom.xml (revision 615464)
> +++ launchpad/launchpad-webapp/pom.xml (working copy)
> @@ -79,7 +79,7 @@
> <configuration>
> <filesets>
> <fileset>
> - <directory>sling</directory>
> + <directory>${basedir}/sling</directory>
> </fileset>
> </filesets>
> </configuration>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-205) launcher/app and
launchpad/launchpad-webapp delete 'sling' directory when invoking from
sling-builder
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler resolved SLING-205.
------------------------------------
Resolution: Fixed
> launcher/app and launchpad/launchpad-webapp delete 'sling' directory when invoking from sling-builder
> -----------------------------------------------------------------------------------------------------
>
> Key: SLING-205
> URL: https://issues.apache.org/jira/browse/SLING-205
> Project: Sling
> Issue Type: Bug
> Reporter: Tobias Bocanegra
> Assignee: Carsten Ziegeler
> Attachments: lp-webapp-it-fix.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> the clean plugin does not correctly handle relative paths in the additional fileset configuration and uses them PWD relative. the launcher/app and the launchpad-webapp have an additional fileset config to delete the 'sling' working directory.
> when invoking a mvn clean inside the builder removes the 'sling' code directory if those modules are not excluded from build.
> the fix is to add the ${basedir} explicitly in the config:
> Index: launcher/app/pom.xml
> ===================================================================
> --- launcher/app/pom.xml (revision 615464)
> +++ launcher/app/pom.xml (working copy)
> @@ -61,7 +61,7 @@
> <configuration>
> <filesets>
> <fileset>
> - <directory>sling</directory>
> + <directory>${basedir}/sling</directory>
> </fileset>
> </filesets>
> </configuration>
> Index: launchpad/launchpad-webapp/pom.xml
> ===================================================================
> --- launchpad/launchpad-webapp/pom.xml (revision 615464)
> +++ launchpad/launchpad-webapp/pom.xml (working copy)
> @@ -79,7 +79,7 @@
> <configuration>
> <filesets>
> <fileset>
> - <directory>sling</directory>
> + <directory>${basedir}/sling</directory>
> </fileset>
> </filesets>
> </configuration>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-205) launcher/app and
launchpad/launchpad-webapp delete 'sling' directory when invoking from
sling-builder
Posted by "Tobias Bocanegra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tobias Bocanegra updated SLING-205:
-----------------------------------
Attachment: lp-webapp-it-fix.patch
fix uses ${basedir}/target/it/sling as sling.home directory for integration tests.
also works in multi-module environment.
> launcher/app and launchpad/launchpad-webapp delete 'sling' directory when invoking from sling-builder
> -----------------------------------------------------------------------------------------------------
>
> Key: SLING-205
> URL: https://issues.apache.org/jira/browse/SLING-205
> Project: Sling
> Issue Type: Bug
> Reporter: Tobias Bocanegra
> Attachments: lp-webapp-it-fix.patch
>
>
> the clean plugin does not correctly handle relative paths in the additional fileset configuration and uses them PWD relative. the launcher/app and the launchpad-webapp have an additional fileset config to delete the 'sling' working directory.
> when invoking a mvn clean inside the builder removes the 'sling' code directory if those modules are not excluded from build.
> the fix is to add the ${basedir} explicitly in the config:
> Index: launcher/app/pom.xml
> ===================================================================
> --- launcher/app/pom.xml (revision 615464)
> +++ launcher/app/pom.xml (working copy)
> @@ -61,7 +61,7 @@
> <configuration>
> <filesets>
> <fileset>
> - <directory>sling</directory>
> + <directory>${basedir}/sling</directory>
> </fileset>
> </filesets>
> </configuration>
> Index: launchpad/launchpad-webapp/pom.xml
> ===================================================================
> --- launchpad/launchpad-webapp/pom.xml (revision 615464)
> +++ launchpad/launchpad-webapp/pom.xml (working copy)
> @@ -79,7 +79,7 @@
> <configuration>
> <filesets>
> <fileset>
> - <directory>sling</directory>
> + <directory>${basedir}/sling</directory>
> </fileset>
> </filesets>
> </configuration>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-205) launcher/app and
launchpad/launchpad-webapp delete 'sling' directory when invoking from
sling-builder
Posted by "Tobias Bocanegra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12562894#action_12562894 ]
Tobias Bocanegra commented on SLING-205:
----------------------------------------
this just fixes the integration-test issue halfway. the 'sling' directory is still used as work directory during the tests...but i couldn't find any documentation how to set the CWD during the tests. maybe the sling config needs to be adapter to use the ${basedir}/sling as well. or even better ${basedir}/target/sling
> launcher/app and launchpad/launchpad-webapp delete 'sling' directory when invoking from sling-builder
> -----------------------------------------------------------------------------------------------------
>
> Key: SLING-205
> URL: https://issues.apache.org/jira/browse/SLING-205
> Project: Sling
> Issue Type: Bug
> Reporter: Tobias Bocanegra
>
> the clean plugin does not correctly handle relative paths in the additional fileset configuration and uses them PWD relative. the launcher/app and the launchpad-webapp have an additional fileset config to delete the 'sling' working directory.
> when invoking a mvn clean inside the builder removes the 'sling' code directory if those modules are not excluded from build.
> the fix is to add the ${basedir} explicitly in the config:
> Index: launcher/app/pom.xml
> ===================================================================
> --- launcher/app/pom.xml (revision 615464)
> +++ launcher/app/pom.xml (working copy)
> @@ -61,7 +61,7 @@
> <configuration>
> <filesets>
> <fileset>
> - <directory>sling</directory>
> + <directory>${basedir}/sling</directory>
> </fileset>
> </filesets>
> </configuration>
> Index: launchpad/launchpad-webapp/pom.xml
> ===================================================================
> --- launchpad/launchpad-webapp/pom.xml (revision 615464)
> +++ launchpad/launchpad-webapp/pom.xml (working copy)
> @@ -79,7 +79,7 @@
> <configuration>
> <filesets>
> <fileset>
> - <directory>sling</directory>
> + <directory>${basedir}/sling</directory>
> </fileset>
> </filesets>
> </configuration>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-205) launcher/app and
launchpad/launchpad-webapp delete 'sling' directory when invoking from
sling-builder
Posted by "Tobias Bocanegra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tobias Bocanegra closed SLING-205.
----------------------------------
> launcher/app and launchpad/launchpad-webapp delete 'sling' directory when invoking from sling-builder
> -----------------------------------------------------------------------------------------------------
>
> Key: SLING-205
> URL: https://issues.apache.org/jira/browse/SLING-205
> Project: Sling
> Issue Type: Bug
> Reporter: Tobias Bocanegra
> Assignee: Carsten Ziegeler
> Attachments: lp-webapp-it-fix.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> the clean plugin does not correctly handle relative paths in the additional fileset configuration and uses them PWD relative. the launcher/app and the launchpad-webapp have an additional fileset config to delete the 'sling' working directory.
> when invoking a mvn clean inside the builder removes the 'sling' code directory if those modules are not excluded from build.
> the fix is to add the ${basedir} explicitly in the config:
> Index: launcher/app/pom.xml
> ===================================================================
> --- launcher/app/pom.xml (revision 615464)
> +++ launcher/app/pom.xml (working copy)
> @@ -61,7 +61,7 @@
> <configuration>
> <filesets>
> <fileset>
> - <directory>sling</directory>
> + <directory>${basedir}/sling</directory>
> </fileset>
> </filesets>
> </configuration>
> Index: launchpad/launchpad-webapp/pom.xml
> ===================================================================
> --- launchpad/launchpad-webapp/pom.xml (revision 615464)
> +++ launchpad/launchpad-webapp/pom.xml (working copy)
> @@ -79,7 +79,7 @@
> <configuration>
> <filesets>
> <fileset>
> - <directory>sling</directory>
> + <directory>${basedir}/sling</directory>
> </fileset>
> </filesets>
> </configuration>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.