You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/06 06:25:53 UTC

[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #17481: [fix][cpp] Use weak ptr avoid circular references.

BewareMyPower commented on code in PR #17481:
URL: https://github.com/apache/pulsar/pull/17481#discussion_r963298315


##########
pulsar-client-cpp/lib/MultiTopicsConsumerImpl.cc:
##########
@@ -577,7 +577,7 @@ void MultiTopicsConsumerImpl::negativeAcknowledge(const MessageId& msgId) {
     }
 }
 
-MultiTopicsConsumerImpl::~MultiTopicsConsumerImpl() {}
+MultiTopicsConsumerImpl::~MultiTopicsConsumerImpl() { LOG_DEBUG(getName() << "~MultiTopicsConsumerImpl"); }

Review Comment:
   This debug log is meaningless, please remove it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org