You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "Kevin Risden (Jira)" <ji...@apache.org> on 2023/02/06 15:31:00 UTC
[jira] [Assigned] (SOLR-16647) Circuit breaker examples are wrong and don't match documentation
[ https://issues.apache.org/jira/browse/SOLR-16647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Risden reassigned SOLR-16647:
-----------------------------------
Assignee: Kevin Risden
> Circuit breaker examples are wrong and don't match documentation
> ----------------------------------------------------------------
>
> Key: SOLR-16647
> URL: https://issues.apache.org/jira/browse/SOLR-16647
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Colvin Cowie
> Assignee: Kevin Risden
> Priority: Trivial
> Attachments: image-2023-02-04-12-08-26-407.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I was diffing the solrconfig.xml in _default and sample_techproducts_configs and saw that they had different circuitBreaker config. The one in _default uses invalid tags according to [https://solr.apache.org/guide/solr/latest/deployment-guide/circuit-breakers.html#circuit-breaker-configurations]
> The default config attempts to enable circuit breakers, but I don't think they actually are enabled given the apparently invalid XML tags
> [https://github.com/apache/solr/blob/92b376a17482496a197ce9c20b5b757f9b354724/solr/server/solr/configsets/_default/conf/solrconfig.xml#L578]
>
> The sample techproducts config has them commented out, but uses the correct tags
> [https://github.com/apache/solr/blob/c96c78132d77974adaec62ffaaf4b819f76f49a9/solr/server/solr/configsets/sample_techproducts_configs/conf/solrconfig.xml#L600]
>
> !image-2023-02-04-12-08-26-407.png!
>
> Also the documentation says to configure the breakers like this:
> {code:java}
> <str name="memEnabled">true</str>
> <str name="memThreshold">75</str>
> <str name="cpuEnabled">true</str>
> <str name="cpuThreshold">75</str>{code}
> But the example configs use
> {code:java}
> <memoryCircuitBreakerThresholdPct>100</memoryCircuitBreakerThresholdPct>
> <cpuBreaker enabled="true" threshold="75"/>{code}
> Looks like documentation is correct and the examples are wrong: [https://github.com/apache/solr/blob/c99af207c761ec34812ef1cc3054eb2804b7448b/solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerManager.java#L160:L163]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org