You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2018/03/13 18:07:30 UTC
Review Request 66043: Renamed a variable in allocator to be
consistent with others.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66043/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description
-------
Renamed `getQuotaRoleAllocatedResources` to
`getQuotaRoleAllocatedScalarQuantities` to be consistent with
other naming.
Diffs
-----
src/master/allocator/mesos/hierarchical.cpp 0e8c2c4a52969448f99bd5f42252a84cc52b9271
Diff: https://reviews.apache.org/r/66043/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 66043: Renamed a variable in allocator to be
consistent with others.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66043/#review199210
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On March 13, 2018, 6:07 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66043/
> -----------------------------------------------------------
>
> (Updated March 13, 2018, 6:07 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Renamed `getQuotaRoleAllocatedResources` to
> `getQuotaRoleAllocatedScalarQuantities` to be consistent with
> other naming.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp 0e8c2c4a52969448f99bd5f42252a84cc52b9271
>
>
> Diff: https://reviews.apache.org/r/66043/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 66043: Renamed a variable in allocator to be
consistent with others.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66043/#review199111
-----------------------------------------------------------
PASS: Mesos patch 66043 was successfully built and tested.
Reviews applied: `['66043']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66043
- Mesos Reviewbot Windows
On March 13, 2018, 6:07 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66043/
> -----------------------------------------------------------
>
> (Updated March 13, 2018, 6:07 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Renamed `getQuotaRoleAllocatedResources` to
> `getQuotaRoleAllocatedScalarQuantities` to be consistent with
> other naming.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp 0e8c2c4a52969448f99bd5f42252a84cc52b9271
>
>
> Diff: https://reviews.apache.org/r/66043/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>