[jira] [Commented] (FLINK-9304) Timer service shutdown should not be interrupted

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-9304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465827#comment-16465827 ] 

ASF GitHub Bot commented on FLINK-9304:
---------------------------------------

GitHub user StefanRRichter opened a pull request:

    https://github.com/apache/flink/pull/5962

    [FLINK-9304] Timer service shutdown should not stop if interrupted

    ## What is the purpose of the change
    
    This PR prevents that interruption prematurely stops the shutdown of the timer service.
    
    
    ## Brief change log
    
    We catch `InterruptedException` around the shutdown call and repeat the attempt while there is still time left w.r.t. to the shutdown grace period.
    
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/StefanRRichter/flink FLINK-9304-timer-service

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5962.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5962
    
----
commit 962bf06a531ea484bc43e453c3c93a793765cad5
Author: Stefan Richter <s....@...>
Date:   2018-05-07T09:55:35Z

    [FLINK-9304] Timer service shutdown should not stop if interrupted

----


> Timer service shutdown should not be interrupted
> ------------------------------------------------
>
>                 Key: FLINK-9304
>                 URL: https://issues.apache.org/jira/browse/FLINK-9304
>             Project: Flink
>          Issue Type: Bug
>          Components: Streaming
>    Affects Versions: 1.5.0, 1.4.2, 1.6.0
>            Reporter: Stefan Richter
>            Assignee: Stefan Richter
>            Priority: Major
>
> Shutting down the timer service in {{StreamTask::invoke}} can be interrupted by the cancellation thread and make waiting for the shutdown exit prematurely.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)