You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@airavata.apache.org by GitBox <gi...@apache.org> on 2022/08/25 12:30:36 UTC

[GitHub] [airavata-mft] PatrickPradier opened a new pull request, #49: Add docker mode

PatrickPradier opened a new pull request, #49:
URL: https://github.com/apache/airavata-mft/pull/49

   - Add a Dockerfile to build a docker image based on master branch
   - Add a docker-compose.yml to launch multiple mft agents


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@airavata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airavata-mft] PatrickPradier commented on a diff in pull request #49: Add docker mode

Posted by GitBox <gi...@apache.org>.
PatrickPradier commented on code in PR #49:
URL: https://github.com/apache/airavata-mft/pull/49#discussion_r955040170


##########
docker/Dockerfile:
##########
@@ -0,0 +1,31 @@
+FROM maven:3.8.6-jdk-11
+
+RUN apt-get update -y
+RUN apt-get install git -y
+
+RUN mkdir airavata
+WORKDIR /airavata
+
+RUN git clone https://github.com/apache/airavata-custos.git
+RUN git clone https://github.com/apache/airavata-data-lake.git
+RUN git clone https://github.com/apache/airavata-mft.git
+
+WORKDIR /airavata/airavata-custos
+RUN git checkout develop
+RUN mvn install
+
+WORKDIR /airavata/airavata-mft/
+RUN ! mvn install --fail-at-end
+
+WORKDIR /airavata/airavata-data-lake/
+RUN ! mvn install --fail-at-end
+
+WORKDIR /airavata/airavata-mft/scripts
+RUN ["./build.sh"]
+
+RUN touch ../airavata-mft/MFT-Agent-0.01/logs/airavata.log
+RUN printf '#!/bin/bash\n_term() {\n./stop-consul.sh\n./stop-mft.sh\n}\ntrap _term SIGTERM\nif [[ "$1"  == consul ]];then\n  ./start-consul.sh linux\nfi\n./start-mft.sh\n./log.sh agent &\nchild=$!\nwait "$child"' > run.sh

Review Comment:
   This part is a bit ugly, I could replace it by adding a run.sh script in the repository and .



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@airavata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airavata-mft] DImuthuUpe merged pull request #49: Add docker mode

Posted by GitBox <gi...@apache.org>.
DImuthuUpe merged PR #49:
URL: https://github.com/apache/airavata-mft/pull/49


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@airavata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airavata-mft] PatrickPradier commented on a diff in pull request #49: Add docker mode

Posted by GitBox <gi...@apache.org>.
PatrickPradier commented on code in PR #49:
URL: https://github.com/apache/airavata-mft/pull/49#discussion_r955040170


##########
docker/Dockerfile:
##########
@@ -0,0 +1,31 @@
+FROM maven:3.8.6-jdk-11
+
+RUN apt-get update -y
+RUN apt-get install git -y
+
+RUN mkdir airavata
+WORKDIR /airavata
+
+RUN git clone https://github.com/apache/airavata-custos.git
+RUN git clone https://github.com/apache/airavata-data-lake.git
+RUN git clone https://github.com/apache/airavata-mft.git
+
+WORKDIR /airavata/airavata-custos
+RUN git checkout develop
+RUN mvn install
+
+WORKDIR /airavata/airavata-mft/
+RUN ! mvn install --fail-at-end
+
+WORKDIR /airavata/airavata-data-lake/
+RUN ! mvn install --fail-at-end
+
+WORKDIR /airavata/airavata-mft/scripts
+RUN ["./build.sh"]
+
+RUN touch ../airavata-mft/MFT-Agent-0.01/logs/airavata.log
+RUN printf '#!/bin/bash\n_term() {\n./stop-consul.sh\n./stop-mft.sh\n}\ntrap _term SIGTERM\nif [[ "$1"  == consul ]];then\n  ./start-consul.sh linux\nfi\n./start-mft.sh\n./log.sh agent &\nchild=$!\nwait "$child"' > run.sh

Review Comment:
   This part is a bit ugly, I could replace it by adding a run.sh script in the repository.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@airavata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airavata-mft] smarru commented on pull request #49: Add docker mode

Posted by GitBox <gi...@apache.org>.
smarru commented on PR #49:
URL: https://github.com/apache/airavata-mft/pull/49#issuecomment-1227310165

   Thanks for your contribution Patrick, the PR says work in progress, please let us know when it is ready for review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@airavata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org