Re: [PR] HDDS-15409. SCM Pipeline Add SupportedStorageTier Field [ozone]

["ivandika3 (via GitHub)" <gi...@apache.org>]

ivandika3 commented on code in PR #10573:
URL: https://github.com/apache/ozone/pull/10573#discussion_r3510879837


##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/pipeline/Pipeline.java:
##########
@@ -170,6 +178,32 @@ public DatanodeID getSuggestedLeaderId() {
     return suggestedLeaderId;
   }
 
+  /**
+   * Return the Pipeline supported StorageTier.
+   *
+   * @return Supported StorageTier
+   */
+  public List<StorageTier> getSupportedStorageTier() {
+    lock.readLock().lock();
+    try {
+      return supportedStorageTier;
+    } finally {
+      lock.readLock().unlock();
+    }
+  }
+
+  /**
+   * Set the storageTier supported by the pipeline.
+   */
+  public void setSupportedStorageTier(List<StorageTier> supportedStorageTier) {

Review Comment:
   @xichen01 let's remove this `setSupportedStorageTier` and also the `updateStorageTier` logic in the node report since as we discovered the updating storage tiers from the node and pipeline report will cause issues. 
   
   One pipeline should only own StorageTier.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org