You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by Patrik Karlström <pa...@gmail.com> on 2024/08/22 14:04:48 UTC
Janitor cleans other platform apps caches
I was curious to see if the janitor is supposed to clean abandoned cache
dirs for other apps than the current one so I had a look at the code and
while doing so I found this line.
https://github.com/apache/netbeans/blob/c1ee059fa5772440986a5e51384c20fcfbcd04ce/platform/janitor/src/org/netbeans/modules/janitor/Janitor.java#L250
Should that be a test for cacheDir instead of user dir?
/Patrik
Re: Janitor cleans other platform apps caches
Posted by Patrik Karlström <pa...@gmail.com>.
Ok, I just created https://github.com/apache/netbeans/pull/7693
/Patrik
Den tors 22 aug. 2024 kl 20:15 skrev Patrik Karlström <
pata.karlstrom@gmail.com>:
> Thanks, I will try.
>
> Den tors 22 aug. 2024 kl 20:12 skrev Michael Bien <mb...@gmail.com>:
>
>> if you open a PR, please base it on the "delivery" branch. There is a
>> chance to get fixes like this into NB 23 still if they are reviewed in
>> time.
>>
>> -mbien
>>
>>
>> On 22.08.24 16:04, Patrik Karlström wrote:
>> > I was curious to see if the janitor is supposed to clean abandoned cache
>> > dirs for other apps than the current one so I had a look at the code and
>> > while doing so I found this line.
>> >
>> >
>> https://github.com/apache/netbeans/blob/c1ee059fa5772440986a5e51384c20fcfbcd04ce/platform/janitor/src/org/netbeans/modules/janitor/Janitor.java#L250
>> >
>> > Should that be a test for cacheDir instead of user dir?
>> >
>> > /Patrik
>> >
>>
>>
Re: Janitor cleans other platform apps caches
Posted by Patrik Karlström <pa...@gmail.com>.
Thanks, I will try.
Den tors 22 aug. 2024 kl 20:12 skrev Michael Bien <mb...@gmail.com>:
> if you open a PR, please base it on the "delivery" branch. There is a
> chance to get fixes like this into NB 23 still if they are reviewed in
> time.
>
> -mbien
>
>
> On 22.08.24 16:04, Patrik Karlström wrote:
> > I was curious to see if the janitor is supposed to clean abandoned cache
> > dirs for other apps than the current one so I had a look at the code and
> > while doing so I found this line.
> >
> >
> https://github.com/apache/netbeans/blob/c1ee059fa5772440986a5e51384c20fcfbcd04ce/platform/janitor/src/org/netbeans/modules/janitor/Janitor.java#L250
> >
> > Should that be a test for cacheDir instead of user dir?
> >
> > /Patrik
> >
>
>
Re: Janitor cleans other platform apps caches
Posted by Michael Bien <mb...@gmail.com>.
if you open a PR, please base it on the "delivery" branch. There is a
chance to get fixes like this into NB 23 still if they are reviewed in time.
-mbien
On 22.08.24 16:04, Patrik Karlström wrote:
> I was curious to see if the janitor is supposed to clean abandoned cache
> dirs for other apps than the current one so I had a look at the code and
> while doing so I found this line.
>
> https://github.com/apache/netbeans/blob/c1ee059fa5772440986a5e51384c20fcfbcd04ce/platform/janitor/src/org/netbeans/modules/janitor/Janitor.java#L250
>
> Should that be a test for cacheDir instead of user dir?
>
> /Patrik
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Janitor cleans other platform apps caches
Posted by Michael Bien <mb...@gmail.com>.
Hi Patrik,
this looks indeed like it should check the cacheDir - possibly a
copy/paste mistake from the block above.
would you like to open a PR for this?
best regards,
-mbien
On 22.08.24 16:04, Patrik Karlström wrote:
> I was curious to see if the janitor is supposed to clean abandoned cache
> dirs for other apps than the current one so I had a look at the code and
> while doing so I found this line.
>
> https://github.com/apache/netbeans/blob/c1ee059fa5772440986a5e51384c20fcfbcd04ce/platform/janitor/src/org/netbeans/modules/janitor/Janitor.java#L250
>
> Should that be a test for cacheDir instead of user dir?
>
> /Patrik
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists