You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/28 11:30:09 UTC
[GitHub] [airflow] eladkal opened a new pull request, #24702: Remove `hook-class-names` from provider.yaml
eladkal opened a new pull request, #24702:
URL: https://github.com/apache/airflow/pull/24702
now that providers>=2.2 there is no need for the hook-class-names any longer.
refrence to https://github.com/apache/airflow/pull/17775
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #24702: Remove `hook-class-names` from provider.yaml
Posted by GitBox <gi...@apache.org>.
eladkal commented on PR #24702:
URL: https://github.com/apache/airflow/pull/24702#issuecomment-1168740919
@potiuk I think we are ready here :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24702: Remove `hook-class-names` from provider.yaml
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24702:
URL: https://github.com/apache/airflow/pull/24702#issuecomment-1168692578
As discussed on slack:
* we should only remove hook-class-names from provider.yaml.schema and our provider.yamls
* we should leave it in provider_info.schema and continue raising deprecation warnings if a 3rd-party provider uses hook-class-names
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #24702: Remove `hook-class-names` from provider.yaml
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24702:
URL: https://github.com/apache/airflow/pull/24702#issuecomment-1168637947
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #24702: Remove `hook-class-names` from provider.yaml
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #24702:
URL: https://github.com/apache/airflow/pull/24702
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24702: Remove `hook-class-names` from provider.yaml
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24702:
URL: https://github.com/apache/airflow/pull/24702#issuecomment-1168636191
One more thing - hook-class-names should also be removed from `airflow/provider.yaml.schema.json` and `provider_info.schema.json`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #24702: Remove `hook-class-names` from provider.yaml
Posted by GitBox <gi...@apache.org>.
eladkal commented on PR #24702:
URL: https://github.com/apache/airflow/pull/24702#issuecomment-1168695291
**Update:**
After talking to @potiuk
We are not looking to remove the feature but only remove the usage of the feature from Airflow provider.
Thus i'm changing `airflow/provider.yaml.schema.json` but not `provider_info.schema.json` since users may still use it should they want to create 3rd party custom providers for Airflow<2.2 - This is why I'm also not removing documentation of the feature from rst files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24702: Remove `hook-class-names` from provider.yaml
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24702:
URL: https://github.com/apache/airflow/pull/24702#issuecomment-1168894803
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24702: Remove `hook-class-names` from provider.yaml
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24702:
URL: https://github.com/apache/airflow/pull/24702#issuecomment-1168894093
I :heart: code removal !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org