[GitHub] [arrow] kszucs commented on a change in pull request #10690: ARROW-13283: [Developer Tools] Support passing CPU/memory limits to Docker

[GitBox <gi...@apache.org>]

kszucs commented on a change in pull request #10690:
URL: https://github.com/apache/arrow/pull/10690#discussion_r668798568



##########
File path: docker-compose.yml
##########
@@ -62,6 +62,14 @@ x-ccache: &ccache
   CCACHE_MAXSIZE: 500M
   CCACHE_DIR: /ccache
 
+# CPU/memory limits to pass to Docker. These values emulate GitHub Actions:
+# https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners
+x-limits:
+  # Note we use cpuset and not cpus since Ninja only detects and limits parallelism

Review comment:
       If I understand correctly we can't set the limits manually, just use preset(s) defined in the compose file?
   If so we may want to define multiple presets in the future, e.g. big-memory, small-memory, travis, etc. 
   
   How about a `--resource-limit=github` or `--limit-preset=github` or something similar on the CLI and a mapping under `x-limit-presets` in the compose file?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org