[GitHub] [incubator-superset] etr2460 commented on a change in pull request #10061: fix: caching on viz with relative time ranges and time compare

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #10061:
URL: https://github.com/apache/incubator-superset/pull/10061#discussion_r440617662



##########
File path: superset/viz.py
##########
@@ -396,8 +396,9 @@ def cache_key(self, query_obj: QueryObjectDict, **extra: Any) -> str:
         cache_dict = copy.copy(query_obj)
         cache_dict.update(extra)
 
-        for k in ["from_dttm", "to_dttm"]:
-            del cache_dict[k]
+        for k in ["from_dttm", "to_dttm", "inner_from_dttm", "inner_to_dttm"]:

Review comment:
       According to @villebro he'd pull any viz changes into viz_sip38 sometime in the future. is that still the case? will update the comment




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org