You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Krisztian Kasa <kk...@hortonworks.com> on 2020/04/01 14:16:57 UTC
Review Request 72301: HIVE-23089
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72301/
-----------------------------------------------------------
Review request for hive, Jesús Camacho Rodríguez and Vineet Garg.
Bugs: HIVE-23089
https://issues.apache.org/jira/browse/HIVE-23089
Repository: hive-git
Description
-------
Add constraint checks to CBO plan
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 9c39cb20bb
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java c87f2d2292
ql/src/test/results/clientnegative/update_notnull_constraint.q.out 32905378e7
ql/src/test/results/clientpositive/llap/check_constraint.q.out 3ef0744c7b
Diff: https://reviews.apache.org/r/72301/diff/1/
Testing
-------
mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestMiniLlapLocalCliDriver -Dqfile=check_constraint.q,sort_acid.q -pl itests/qtest -Pitests
mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestNegativeCliDriver -Dqfile=update_notnull_constraint.q -pl itests/qtest -Pitests
Thanks,
Krisztian Kasa
Re: Review Request 72301: HIVE-23089
Posted by Krisztian Kasa <kk...@hortonworks.com>.
> On April 1, 2020, 3:10 p.m., Jesús Camacho Rodríguez wrote:
> > Krisztian, could we hold pushing this patch? HIVE-23100 changes the way that the expressions are generated in Calcite planner (directly as RexNode from the AST) so we cannot rely on method from SemanticAnalyzer + RexConverter. Since this is a non-blocking optimization, it seems we do not need to push it immediately. Please, let me know what you think.
Sure. It can be hold.
- Krisztian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72301/#review220172
-----------------------------------------------------------
On April 1, 2020, 2:16 p.m., Krisztian Kasa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72301/
> -----------------------------------------------------------
>
> (Updated April 1, 2020, 2:16 p.m.)
>
>
> Review request for hive, Jesús Camacho Rodríguez and Vineet Garg.
>
>
> Bugs: HIVE-23089
> https://issues.apache.org/jira/browse/HIVE-23089
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Add constraint checks to CBO plan
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 9c39cb20bb
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java c87f2d2292
> ql/src/test/results/clientnegative/update_notnull_constraint.q.out 32905378e7
> ql/src/test/results/clientpositive/llap/check_constraint.q.out 3ef0744c7b
>
>
> Diff: https://reviews.apache.org/r/72301/diff/1/
>
>
> Testing
> -------
>
> mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestMiniLlapLocalCliDriver -Dqfile=check_constraint.q,sort_acid.q -pl itests/qtest -Pitests
> mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestNegativeCliDriver -Dqfile=update_notnull_constraint.q -pl itests/qtest -Pitests
>
>
> Thanks,
>
> Krisztian Kasa
>
>
Re: Review Request 72301: HIVE-23089
Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72301/#review220172
-----------------------------------------------------------
Krisztian, could we hold pushing this patch? HIVE-23100 changes the way that the expressions are generated in Calcite planner (directly as RexNode from the AST) so we cannot rely on method from SemanticAnalyzer + RexConverter. Since this is a non-blocking optimization, it seems we do not need to push it immediately. Please, let me know what you think.
- Jesús Camacho Rodríguez
On April 1, 2020, 2:16 p.m., Krisztian Kasa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72301/
> -----------------------------------------------------------
>
> (Updated April 1, 2020, 2:16 p.m.)
>
>
> Review request for hive, Jesús Camacho Rodríguez and Vineet Garg.
>
>
> Bugs: HIVE-23089
> https://issues.apache.org/jira/browse/HIVE-23089
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Add constraint checks to CBO plan
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 9c39cb20bb
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java c87f2d2292
> ql/src/test/results/clientnegative/update_notnull_constraint.q.out 32905378e7
> ql/src/test/results/clientpositive/llap/check_constraint.q.out 3ef0744c7b
>
>
> Diff: https://reviews.apache.org/r/72301/diff/1/
>
>
> Testing
> -------
>
> mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestMiniLlapLocalCliDriver -Dqfile=check_constraint.q,sort_acid.q -pl itests/qtest -Pitests
> mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestNegativeCliDriver -Dqfile=update_notnull_constraint.q -pl itests/qtest -Pitests
>
>
> Thanks,
>
> Krisztian Kasa
>
>