[GitHub] [dubbo-go] Mulavar commented on a change in pull request #1467: Config enhance

[GitBox <gi...@apache.org>]

Mulavar commented on a change in pull request #1467:
URL: https://github.com/apache/dubbo-go/pull/1467#discussion_r715385127



##########
File path: config/config_center_config.go
##########
@@ -72,19 +71,31 @@ type CenterConfig struct {
 	Params    map[string]string `yaml:"params"  json:"parameters,omitempty"`
 }
 
+// Prefix dubbo.config-center
+func (CenterConfig) Prefix() string {
+	return constant.ConfigCenterPrefix
+}

Review comment:
       结构名是 CenterConfig，但实际方法名常量名都是 ConfigCenter，需不需要调整一下呢？




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org