You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "michael-s-molina (via GitHub)" <gi...@apache.org> on 2023/02/28 15:27:46 UTC
[GitHub] [superset] michael-s-molina commented on a diff in pull request #23228: chore: Deprecate show_native_filters
michael-s-molina commented on code in PR #23228:
URL: https://github.com/apache/superset/pull/23228#discussion_r1120253591
##########
superset-frontend/src/dashboard/components/DashboardBuilder/state.ts:
##########
@@ -30,11 +30,6 @@ import {
// eslint-disable-next-line import/prefer-default-export
export const useNativeFilters = () => {
const [isInitialized, setIsInitialized] = useState(false);
- const showNativeFilters = useSelector<RootState, boolean>(
- state =>
- (getUrlParam(URL_PARAMS.showFilters) ?? true) &&
Review Comment:
Can you remove `showFilters` from `URL_PARAMS` or use JSDoc [@deprecated](https://jsdoc.app/tags-deprecated.html)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org