You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/11/26 13:06:18 UTC

[GitHub] [camel-quarkus] zbendhiba opened a new pull request #3339: :memo: Set documentation version to Camel Quarkus 2.5.x

zbendhiba opened a new pull request #3339:
URL: https://github.com/apache/camel-quarkus/pull/3339


   <!-- Uncomment and fill this section if your PR is not trivial
   [ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
   [ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
   [ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
   [ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
   [ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
   [ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] zbendhiba commented on pull request #3339: :memo: Set documentation version to Camel Quarkus 2.5.x

Posted by GitBox <gi...@apache.org>.
zbendhiba commented on pull request #3339:
URL: https://github.com/apache/camel-quarkus/pull/3339#issuecomment-980040345


   I fixed the `qute.json` file
   But I'm skeptical that this could work. Every time I build the project, the antora.yaml file is updated. The version goes from **2.5.x** to **next**. So I'm expecting the `mvn install` to fail.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga commented on pull request #3339: :memo: Set documentation version to Camel Quarkus 2.5.x

Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #3339:
URL: https://github.com/apache/camel-quarkus/pull/3339#issuecomment-985055434


   For the record, the issue is here: https://github.com/apache/camel-quarkus/issues/3350


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] zbendhiba commented on pull request #3339: :memo: Set documentation version to Camel Quarkus 2.5.x

Posted by GitBox <gi...@apache.org>.
zbendhiba commented on pull request #3339:
URL: https://github.com/apache/camel-quarkus/pull/3339#issuecomment-979966439


   I wonder if this one works as this https://github.com/apache/camel-website/pull/691 not merged yet 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] djencks commented on pull request #3339: :memo: Set documentation version to Camel Quarkus 2.5.x

Posted by GitBox <gi...@apache.org>.
djencks commented on pull request #3339:
URL: https://github.com/apache/camel-quarkus/pull/3339#issuecomment-980495533


   For 2.4.x I updated the groovy scripts to not update antora.yml: https://github.com/apache/camel-quarkus/commit/efda8ea4d5d29e0a9808187384f4c9627286284e
   
   I'd recommend doing that here too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] jamesnetherton commented on pull request #3339: :memo: Set documentation version to Camel Quarkus 2.5.x

Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on pull request #3339:
URL: https://github.com/apache/camel-quarkus/pull/3339#issuecomment-980044140


   > The version goes from **2.5.x** to **next**.
   
   Ah yeah the update script sees `SNAPSHOT` in the project version and will use `next`.
   
   I think we should just merge this PR. It's pretty unlikely anyone is going to do a full build the 2.5.x anyway. We can fix up the antora update script and try to make it smarter later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] zbendhiba commented on pull request #3339: :memo: Set documentation version to Camel Quarkus 2.5.x

Posted by GitBox <gi...@apache.org>.
zbendhiba commented on pull request #3339:
URL: https://github.com/apache/camel-quarkus/pull/3339#issuecomment-980526272


   I don't know how we could address this in the release process. Is there a way to change automagically those files ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga commented on pull request #3339: :memo: Set documentation version to Camel Quarkus 2.5.x

Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #3339:
URL: https://github.com/apache/camel-quarkus/pull/3339#issuecomment-981499767


   Could please somebody create an issue describing what should happen on release?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] zbendhiba merged pull request #3339: :memo: Set documentation version to Camel Quarkus 2.5.x

Posted by GitBox <gi...@apache.org>.
zbendhiba merged pull request #3339:
URL: https://github.com/apache/camel-quarkus/pull/3339


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] djencks commented on pull request #3339: :memo: Set documentation version to Camel Quarkus 2.5.x

Posted by GitBox <gi...@apache.org>.
djencks commented on pull request #3339:
URL: https://github.com/apache/camel-quarkus/pull/3339#issuecomment-980638920


   I couldn't think of an automated way of detecting a non-next branch.
   
   Would it be possible for the release process to add a pom property saying "released" and the groovy script not update the Antora stuff on a released branch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] zbendhiba commented on pull request #3339: :memo: Set documentation version to Camel Quarkus 2.5.x

Posted by GitBox <gi...@apache.org>.
zbendhiba commented on pull request #3339:
URL: https://github.com/apache/camel-quarkus/pull/3339#issuecomment-980547740


   I guess I can merge this. Thanks for reviews


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] zbendhiba commented on pull request #3339: :memo: Set documentation version to Camel Quarkus 2.5.x

Posted by GitBox <gi...@apache.org>.
zbendhiba commented on pull request #3339:
URL: https://github.com/apache/camel-quarkus/pull/3339#issuecomment-981503973


   @ppalaga Yes, I'd create one to explain all I did. on my TODO list


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org