You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Joseph Toth (JIRA)" <ji...@apache.org> on 2007/03/20 03:08:32 UTC
[jira] Created: (WICKET-409) Page constructed twice when a
BookmarkableLink has PopupSettings
Page constructed twice when a BookmarkableLink has PopupSettings
----------------------------------------------------------------
Key: WICKET-409
URL: https://issues.apache.org/jira/browse/WICKET-409
Project: Wicket
Issue Type: Bug
Affects Versions: 1.2.5
Reporter: Joseph Toth
If PopupSettings are set on a BookmarkableLink the target Class of the BookmarkableLink is constructed twice.
If I change the following code to just use Link instead of BookmarkableLink, it works fine.
abstract public class LiveHelpStatusPanel extends Panel {
@SpringBean
LiveHelpService liveHelpService;
public LiveHelpStatusPanel(String id) {
super(id);
PopupSettings settings = new PopupSettings();
settings.setHeight(225);
settings.setWidth(350);
BookmarkablePageLink link = new BookmarkablePageLink("liveHelpLink",
getLiveHelpPage()) {
boolean isSupportOnline = true;
@Override
protected void onAttach() {
List<Buddy> staff = liveHelpService.getSupportStaff();
for (Buddy buddy : staff) {
if (buddy.isOnline() && !buddy.isAway()) {
isSupportOnline = true;
}
}
}
@Override
public boolean isVisible() {
return isSupportOnline;
}
};
link.setPopupSettings(settings);
add(link);
}
public abstract Class getLiveHelpPage();
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-409) Page constructed twice when a
BookmarkableLink has PopupSettings
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alastair Maw updated WICKET-409:
--------------------------------
Fix Version/s: 1.3.0-rc1
Should verify this is fixed in 1.3.x
> Page constructed twice when a BookmarkableLink has PopupSettings
> ----------------------------------------------------------------
>
> Key: WICKET-409
> URL: https://issues.apache.org/jira/browse/WICKET-409
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.2.5
> Reporter: Joseph Toth
> Fix For: 1.3.0-rc1
>
>
> If PopupSettings are set on a BookmarkableLink the target Class of the BookmarkableLink is constructed twice if the Link is from a super class. Here is an example of how to reproduce with the examples.
> wicket.examples.WicketExamplePage add after line 53...
> BookmarkablePageLink link = new BookmarkablePageLink("link", HelloWorld.class);
> link.setPopupSettings(new PopupSettings());
> add(link);
> wicket.examples.helloworld.HelloWorld.html add...
> <a wicket:id="link">popup link</a>
> Then in HelloWorld's constructor set a breakpoint and you will see it being called twice.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-409) Page constructed twice when a
BookmarkableLink has PopupSettings
Posted by "Joseph Toth (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joseph Toth updated WICKET-409:
-------------------------------
Description:
If PopupSettings are set on a BookmarkableLink the target Class of the BookmarkableLink is constructed twice.
abstract public class LiveHelpStatusPanel extends Panel {
@SpringBean
LiveHelpService liveHelpService;
public LiveHelpStatusPanel(String id) {
super(id);
PopupSettings settings = new PopupSettings();
settings.setHeight(225);
settings.setWidth(350);
BookmarkablePageLink link = new BookmarkablePageLink("liveHelpLink",
getLiveHelpPage()) {
boolean isSupportOnline = true;
@Override
protected void onAttach() {
List<Buddy> staff = liveHelpService.getSupportStaff();
for (Buddy buddy : staff) {
if (buddy.isOnline() && !buddy.isAway()) {
isSupportOnline = true;
}
}
}
@Override
public boolean isVisible() {
return isSupportOnline;
}
};
link.setPopupSettings(settings);
add(link);
}
public abstract Class getLiveHelpPage();
}
was:
If PopupSettings are set on a BookmarkableLink the target Class of the BookmarkableLink is constructed twice.
If I change the following code to just use Link instead of BookmarkableLink, it works fine.
abstract public class LiveHelpStatusPanel extends Panel {
@SpringBean
LiveHelpService liveHelpService;
public LiveHelpStatusPanel(String id) {
super(id);
PopupSettings settings = new PopupSettings();
settings.setHeight(225);
settings.setWidth(350);
BookmarkablePageLink link = new BookmarkablePageLink("liveHelpLink",
getLiveHelpPage()) {
boolean isSupportOnline = true;
@Override
protected void onAttach() {
List<Buddy> staff = liveHelpService.getSupportStaff();
for (Buddy buddy : staff) {
if (buddy.isOnline() && !buddy.isAway()) {
isSupportOnline = true;
}
}
}
@Override
public boolean isVisible() {
return isSupportOnline;
}
};
link.setPopupSettings(settings);
add(link);
}
public abstract Class getLiveHelpPage();
}
> Page constructed twice when a BookmarkableLink has PopupSettings
> ----------------------------------------------------------------
>
> Key: WICKET-409
> URL: https://issues.apache.org/jira/browse/WICKET-409
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.2.5
> Reporter: Joseph Toth
>
> If PopupSettings are set on a BookmarkableLink the target Class of the BookmarkableLink is constructed twice.
> abstract public class LiveHelpStatusPanel extends Panel {
> @SpringBean
> LiveHelpService liveHelpService;
> public LiveHelpStatusPanel(String id) {
> super(id);
> PopupSettings settings = new PopupSettings();
> settings.setHeight(225);
> settings.setWidth(350);
> BookmarkablePageLink link = new BookmarkablePageLink("liveHelpLink",
> getLiveHelpPage()) {
> boolean isSupportOnline = true;
> @Override
> protected void onAttach() {
> List<Buddy> staff = liveHelpService.getSupportStaff();
> for (Buddy buddy : staff) {
> if (buddy.isOnline() && !buddy.isAway()) {
> isSupportOnline = true;
> }
> }
> }
> @Override
> public boolean isVisible() {
> return isSupportOnline;
> }
> };
> link.setPopupSettings(settings);
> add(link);
> }
> public abstract Class getLiveHelpPage();
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-409) Page constructed twice when a
BookmarkableLink has PopupSettings
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alastair Maw updated WICKET-409:
--------------------------------
Description: If PopupSettings are set on a BookmarkableLink the target Class of the BookmarkableLink is constructed twice. (was: If PopupSettings are set on a BookmarkableLink the target Class of the BookmarkableLink is constructed twice.
abstract public class LiveHelpStatusPanel extends Panel {
@SpringBean
LiveHelpService liveHelpService;
public LiveHelpStatusPanel(String id) {
super(id);
PopupSettings settings = new PopupSettings();
settings.setHeight(225);
settings.setWidth(350);
BookmarkablePageLink link = new BookmarkablePageLink("liveHelpLink",
getLiveHelpPage()) {
boolean isSupportOnline = true;
@Override
protected void onAttach() {
List<Buddy> staff = liveHelpService.getSupportStaff();
for (Buddy buddy : staff) {
if (buddy.isOnline() && !buddy.isAway()) {
isSupportOnline = true;
}
}
}
@Override
public boolean isVisible() {
return isSupportOnline;
}
};
link.setPopupSettings(settings);
add(link);
}
public abstract Class getLiveHelpPage();
}
)
> Page constructed twice when a BookmarkableLink has PopupSettings
> ----------------------------------------------------------------
>
> Key: WICKET-409
> URL: https://issues.apache.org/jira/browse/WICKET-409
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.2.5
> Reporter: Joseph Toth
>
> If PopupSettings are set on a BookmarkableLink the target Class of the BookmarkableLink is constructed twice.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-409) Page constructed twice when a
BookmarkableLink has PopupSettings
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alastair Maw resolved WICKET-409.
---------------------------------
Resolution: Fixed
Fix Version/s: (was: 1.3.0-rc1)
1.3.0-beta2
This doesn't happen in 1.3.x.
> Page constructed twice when a BookmarkableLink has PopupSettings
> ----------------------------------------------------------------
>
> Key: WICKET-409
> URL: https://issues.apache.org/jira/browse/WICKET-409
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.2.5
> Reporter: Joseph Toth
> Assignee: Alastair Maw
> Fix For: 1.3.0-beta2
>
>
> If PopupSettings are set on a BookmarkableLink the target Class of the BookmarkableLink is constructed twice if the Link is from a super class. Here is an example of how to reproduce with the examples.
> wicket.examples.WicketExamplePage add after line 53...
> BookmarkablePageLink link = new BookmarkablePageLink("link", HelloWorld.class);
> link.setPopupSettings(new PopupSettings());
> add(link);
> wicket.examples.helloworld.HelloWorld.html add...
> <a wicket:id="link">popup link</a>
> Then in HelloWorld's constructor set a breakpoint and you will see it being called twice.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-409) Page constructed twice when a
BookmarkableLink has PopupSettings
Posted by "Joseph Toth (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joseph Toth updated WICKET-409:
-------------------------------
Description:
If PopupSettings are set on a BookmarkableLink the target Class of the BookmarkableLink is constructed twice if the Link is from a super class. Here is an example of how to reproduce with the examples.
wicket.examples.WicketExamplePage add after line 53...
BookmarkablePageLink link = new BookmarkablePageLink("link", HelloWorld.class);
link.setPopupSettings(new PopupSettings());
add(link);
wicket.examples.helloworld.HelloWorld.html add...
<a wicket:id="link">popup link</a>
Then in HelloWorld's constructor set a breakpoint and you will see it being called twice.
was:If PopupSettings are set on a BookmarkableLink the target Class of the BookmarkableLink is constructed twice.
> Page constructed twice when a BookmarkableLink has PopupSettings
> ----------------------------------------------------------------
>
> Key: WICKET-409
> URL: https://issues.apache.org/jira/browse/WICKET-409
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.2.5
> Reporter: Joseph Toth
>
> If PopupSettings are set on a BookmarkableLink the target Class of the BookmarkableLink is constructed twice if the Link is from a super class. Here is an example of how to reproduce with the examples.
> wicket.examples.WicketExamplePage add after line 53...
> BookmarkablePageLink link = new BookmarkablePageLink("link", HelloWorld.class);
> link.setPopupSettings(new PopupSettings());
> add(link);
> wicket.examples.helloworld.HelloWorld.html add...
> <a wicket:id="link">popup link</a>
> Then in HelloWorld's constructor set a breakpoint and you will see it being called twice.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-409) Page constructed twice when a
BookmarkableLink has PopupSettings
Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Baptiste Quenot updated WICKET-409:
----------------------------------------
Component/s: wicket
> Page constructed twice when a BookmarkableLink has PopupSettings
> ----------------------------------------------------------------
>
> Key: WICKET-409
> URL: https://issues.apache.org/jira/browse/WICKET-409
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.2.5
> Reporter: Joseph Toth
>
> If PopupSettings are set on a BookmarkableLink the target Class of the BookmarkableLink is constructed twice if the Link is from a super class. Here is an example of how to reproduce with the examples.
> wicket.examples.WicketExamplePage add after line 53...
> BookmarkablePageLink link = new BookmarkablePageLink("link", HelloWorld.class);
> link.setPopupSettings(new PopupSettings());
> add(link);
> wicket.examples.helloworld.HelloWorld.html add...
> <a wicket:id="link">popup link</a>
> Then in HelloWorld's constructor set a breakpoint and you will see it being called twice.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-409) Page constructed twice when a
BookmarkableLink has PopupSettings
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alastair Maw reassigned WICKET-409:
-----------------------------------
Assignee: Alastair Maw
> Page constructed twice when a BookmarkableLink has PopupSettings
> ----------------------------------------------------------------
>
> Key: WICKET-409
> URL: https://issues.apache.org/jira/browse/WICKET-409
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.2.5
> Reporter: Joseph Toth
> Assignee: Alastair Maw
> Fix For: 1.3.0-rc1
>
>
> If PopupSettings are set on a BookmarkableLink the target Class of the BookmarkableLink is constructed twice if the Link is from a super class. Here is an example of how to reproduce with the examples.
> wicket.examples.WicketExamplePage add after line 53...
> BookmarkablePageLink link = new BookmarkablePageLink("link", HelloWorld.class);
> link.setPopupSettings(new PopupSettings());
> add(link);
> wicket.examples.helloworld.HelloWorld.html add...
> <a wicket:id="link">popup link</a>
> Then in HelloWorld's constructor set a breakpoint and you will see it being called twice.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.