You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/12/14 22:10:16 UTC

[GitHub] [tvm] zhiics commented on a change in pull request #7108: [RUNTIME] Add function name to PackedFunc and TypedPackedFunc

zhiics commented on a change in pull request #7108:
URL: https://github.com/apache/tvm/pull/7108#discussion_r542854713



##########
File path: include/tvm/runtime/packed_func.h
##########
@@ -293,6 +304,8 @@ class TypedPackedFunc<R(Args...)> {
   friend class TVMRetValue;
   /*! \brief The internal packed function */
   PackedFunc packed_;
+  /*! \brief The name identifying this function */
+  String name_;

Review comment:
       should we just use the `name_` of packed_?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org