You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Erin Noe-Payne (JIRA)" <ji...@apache.org> on 2012/08/13 17:26:37 UTC
[jira] [Created] (SHINDIG-1855) Gadgets feature list does not
traverse dependencies
Erin Noe-Payne created SHINDIG-1855:
---------------------------------------
Summary: Gadgets feature list does not traverse dependencies
Key: SHINDIG-1855
URL: https://issues.apache.org/jira/browse/SHINDIG-1855
Project: Shindig
Issue Type: Bug
Components: Java, Javascript
Affects Versions: 2.5.0-beta3
Reporter: Erin Noe-Payne
Priority: Minor
When the list of gadget features is processed, only features that are required directly from the module prefs are taken into account - the dependency tree is not traversed.
This will cause an issue for the following example:
- MyGadget requires myCustomFeature.
- myCustomFeature requires pubsub-2 as a dependency.
- pubsub-2 is not added the MyGadget's features list
- When the container checks has_feature('pubsub-2'), it will return false
- The gadget does not properly implement pubsub-2.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1855) Gadgets feature list does not
traverse dependencies
Posted by "Stanton Sievers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466487#comment-13466487 ]
Stanton Sievers commented on SHINDIG-1855:
------------------------------------------
Erin, can you please review my comments/questions above?
> Gadgets feature list does not traverse dependencies
> ---------------------------------------------------
>
> Key: SHINDIG-1855
> URL: https://issues.apache.org/jira/browse/SHINDIG-1855
> Project: Shindig
> Issue Type: Bug
> Components: Java, Javascript
> Affects Versions: 2.5.0-beta3
> Reporter: Erin Noe-Payne
> Priority: Minor
> Labels: features
>
> When the list of gadget features is processed, only features that are required directly from the module prefs are taken into account - the dependency tree is not traversed.
> This will cause an issue for the following example:
> - MyGadget requires myCustomFeature.
> - myCustomFeature requires pubsub-2 as a dependency.
> - pubsub-2 is not added the MyGadget's features list
> - When the container checks has_feature('pubsub-2'), it will return false
> - The gadget does not properly implement pubsub-2.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1855) Gadgets feature list does not
traverse dependencies
Posted by "Stanton Sievers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13437099#comment-13437099 ]
Stanton Sievers commented on SHINDIG-1855:
------------------------------------------
Hi Erin,
Two things:
1) Is this only a problem with custom features? Do you see this issue in the scenario above when "myCustomFeature" is replaced with a feature built into Shindig? If it is only a problem with a custom feature, how are you contributing it?
2) Is this only an issue with pubsub-2 and other features within extras? For instance, if myCustomFeature requires settitle, will has_feature('settitle') return true?
Also, was this something you were investigating and planning on posting a patch for? If not, I can certainly assign this JIRA to myself and have a look.
> Gadgets feature list does not traverse dependencies
> ---------------------------------------------------
>
> Key: SHINDIG-1855
> URL: https://issues.apache.org/jira/browse/SHINDIG-1855
> Project: Shindig
> Issue Type: Bug
> Components: Java, Javascript
> Affects Versions: 2.5.0-beta3
> Reporter: Erin Noe-Payne
> Priority: Minor
> Labels: features
>
> When the list of gadget features is processed, only features that are required directly from the module prefs are taken into account - the dependency tree is not traversed.
> This will cause an issue for the following example:
> - MyGadget requires myCustomFeature.
> - myCustomFeature requires pubsub-2 as a dependency.
> - pubsub-2 is not added the MyGadget's features list
> - When the container checks has_feature('pubsub-2'), it will return false
> - The gadget does not properly implement pubsub-2.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira