[GitHub] [incubator-apisix] sshniro commented on a change in pull request #1355: Updating the UDP logger to use the batch processor util

[GitBox <gi...@apache.org>]

sshniro commented on a change in pull request #1355: Updating the UDP logger to use the batch processor util
URL: https://github.com/apache/incubator-apisix/pull/1355#discussion_r400666937
 
 

 ##########
 File path: doc/plugins/udp-logger.md
 ##########
 @@ -33,15 +33,21 @@ This will provide the ability to send Log data requests as JSON objects to Monit
 
 ## Attributes
 
-|Name          |Requirement  |Description|
-|---------     |--------|-----------|
-| host |required| IP address or the Hostname of the UDP server.|
-| port |required| Target upstream port.|
-| timeout |optional|Timeout for the upstream to send data.|
+|Name           |Requirement    |Description|
+|---------      |--------       |-----------|
+|host           |required       | IP address or the Hostname of the UDP server.|
+|port           |required       | Target upstream port.|
+|timeout        |optional       |Timeout for the upstream to send data.|
+|name           |optional       |A unique identifier to identity the batch processor|
+|batch_max_size |optional       |Max size of each batch, default is 1000|
+|inactive_timeout|optional      |Maximum age in seconds when the buffer will be flushed if inactive, default is 5s|
+|buffer_duration|optional       |Maximum age in seconds of the oldest entry in a batch before the batch must be processed, default is 60|
+|max_retry_count|optional       |Maximum number of retries before removing from the processing pipe line; default is zero|
+|retry_delay    |optional       |Number of seconds the process execution should be delayed if the execution fails; default is 1|
 
 Review comment:
   Do we need a retry attribute for UDP, because the UDP does not check for acks?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services