[GitHub] clintropolis commented on a change in pull request #6804: Fix num_replicas count in sys.segments table

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #6804: Fix num_replicas count in sys.segments table
URL: https://github.com/apache/incubator-druid/pull/6804#discussion_r246237672
 
 

 ##########
 File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/SegmentMetadataHolder.java
 ##########
 @@ -105,14 +112,14 @@ public Builder(
         long isPublished,
         long isAvailable,
         long isRealtime,
-        long numReplicas
+        Map<String, Set<String>> segmentServerMap
     )
     {
       this.segmentId = segmentId;
       this.isPublished = isPublished;
       this.isAvailable = isAvailable;
       this.isRealtime = isRealtime;
-      this.numReplicas = numReplicas;
+      this.segmentServerMap = segmentServerMap;
 
 Review comment:
   This should be stored as an immutable copy, e.g. `ImmutableMap<String, ImmutableSet<String>>` I think since `SegmentMetadataHolder` is supposed to be an immutable structure.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org