[GitHub] [wicket] martin-g commented on a change in pull request #440: WICKET-6807 Improve the check for the submitting component

[GitBox <gi...@apache.org>]

martin-g commented on a change in pull request #440:
URL: https://github.com/apache/wicket/pull/440#discussion_r466298364



##########
File path: wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java
##########
@@ -1711,7 +1725,7 @@ public final void writeHiddenFields()
 	{
 		// if it's a get, did put the parameters in the action attribute,
 		// and have to write the url parameters as hidden fields
-		if (encodeUrlInHiddenFields())
+		if (METHOD_POST.equalsIgnoreCase(getMethod()))

Review comment:
       Sven Meier comment from https://issues.apache.org/jira/browse/WICKET-6807?focusedCommentId=17172167&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17172167:
   
   That is not correct!
   
   Parameters **must** be written as hidden fields, when the Form is 'get' (because the browser would strip them from the form's action). For a 'post' Form the parameters **can** be either in hidden fields **or** in the form's action, both would work.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org