You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/05 20:08:11 UTC
[GitHub] [arrow-datafusion] andygrove opened a new issue, #3695: `OptimizerConfig::skip_failing_rules` should be false by default
andygrove opened a new issue, #3695:
URL: https://github.com/apache/arrow-datafusion/issues/3695
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
We currently default to `OptimizerConfig::skip_failing_rules` to true and this means that ignore all of the current bugs in the optimizer rules.
**Describe the solution you'd like**
I would like to default to true so that regressions are caught much sooner.
**Describe alternatives you've considered**
None
**Additional context**
None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] `OptimizerConfig::skip_failing_rules` should be false by default in sql tests [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #3695: `OptimizerConfig::skip_failing_rules` should be false by default in sql tests
URL: https://github.com/apache/datafusion/issues/3695
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
[GitHub] [arrow-datafusion] andygrove commented on issue #3695: `OptimizerConfig::skip_failing_rules` should be false by default in sql tests
Posted by GitBox <gi...@apache.org>.
andygrove commented on issue #3695:
URL: https://github.com/apache/arrow-datafusion/issues/3695#issuecomment-1265822134
These tests fail when we stop ignoring optimizer errors:
```
failures:
sql::group_by::csv_query_having_without_group_by
sql::joins::equijoin_implicit_syntax_with_filter
sql::joins::equijoin_left_and_condition_from_left
sql::joins::equijoin_right_and_condition_from_left
sql::joins::equijoin_right_and_condition_from_right
sql::joins::reduce_left_join_1
sql::joins::reduce_left_join_2
sql::joins::reduce_left_join_3
sql::joins::self_join_non_equijoin
sql::select::csv_select_nested
sql::select::csv_select_nested_without_aliases
sql::select::unprojected_filter
sql::timestamp::cast_string_to_time
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org