You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/12/15 08:36:04 UTC
[GitHub] [cloudstack] borisstoyanov opened a new issue, #6993: Root volume of system vms is being listed
borisstoyanov opened a new issue, #6993:
URL: https://github.com/apache/cloudstack/issues/6993
<!--
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release and main branch are affected too.
Always add information AFTER of these HTML comments, but no need to delete the comments.
-->
##### ISSUE TYPE
<!-- Pick one below and delete the rest -->
* Bug Report
##### COMPONENT NAME
<!--
Categorize the issue, e.g. API, VR, VPN, UI, etc.
-->
~~~
API/UI
~~~
##### CLOUDSTACK VERSION
<!--
New line separated list of affected versions, commit ID for issues on main branch.
-->
~~~
4.18 [main]
~~~
##### CONFIGURATION
<!--
Information about the configuration if relevant, e.g. basic network, advanced networking, etc. N/A otherwise
-->
##### OS / ENVIRONMENT
<!--
Information about the environment if relevant, N/A otherwise
-->
##### SUMMARY
<!-- Explain the problem/feature briefly -->
<!-- You can also paste gist.github.com links for larger files -->
##### EXPECTED RESULTS
<!-- What did you expect to happen when running the steps above? -->
~~~
Volumes of system VMs/routers should not be listed to admin/user in Volumes tab
~~~
##### ACTUAL RESULTS
<!-- What actually happened? -->
<!-- Paste verbatim command output between quotes below -->
~~~
they are
~~~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on issue #6993: Root volume of system vms is being listed
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on issue #6993:
URL: https://github.com/apache/cloudstack/issues/6993#issuecomment-1357297747
was this an improvement introduced by someone? if not it should be a regression?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on issue #6993: Root volume of system vms is being listed
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #6993:
URL: https://github.com/apache/cloudstack/issues/6993#issuecomment-1377003903
@borisstoyanov @DaanHoogland
I just checked this issue, it is caused by some changes in #6491
I will add a filter on UI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on issue #6993: Root volume of system vms is being listed
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #6993:
URL: https://github.com/apache/cloudstack/issues/6993#issuecomment-1377259708
@DaanHoogland
only root admin can list systemvm volumes.
I will add a filter only for root admins, which has two options:
- User: list only users' volumes. This is default
- All: list all volumes (users' volumes and systemvm volumes)
What do you think ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #6993: Root volume of system vms is being listed
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #6993:
URL: https://github.com/apache/cloudstack/issues/6993#issuecomment-1377268818
sounds good, but should resource/domain admins not also be able to see those, or at least VR volumes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #6993: Root volume of system vms is being listed
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #6993:
URL: https://github.com/apache/cloudstack/issues/6993#issuecomment-1377584563
> let's keep the same behaviour.
makes sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on issue #6993: Root volume of system vms is being listed
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #6993:
URL: https://github.com/apache/cloudstack/issues/6993#issuecomment-1377334035
> sounds good, but should resource/domain admins not also be able to see those, or at least VR volumes)
@DaanHoogland
The api parameter introduced in #6491 can only be used by root admin.
```
@Parameter(name = ApiConstants.LIST_SYSTEM_VMS, type = CommandType.BOOLEAN, description = "list system VMs; only ROOT admin is eligible to pass this parameter", since = "4.18",
authorized = { RoleType.Admin })
private Boolean listSystemVms;
```
let's keep the same behaviour.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #6993: Root volume of system vms is being listed
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #6993:
URL: https://github.com/apache/cloudstack/issues/6993#issuecomment-1357426975
are they shown to normal users, than yes. If not then I would call it an accidental improvement, if not planned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #6993: Root volume of system vms is being listed
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #6993:
URL: https://github.com/apache/cloudstack/issues/6993#issuecomment-1354700533
@borisstoyanov I agree these should not be listed to normal users, but why not to admin users?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland closed issue #6993: Root volume of system vms is being listed
Posted by GitBox <gi...@apache.org>.
DaanHoogland closed issue #6993: Root volume of system vms is being listed
URL: https://github.com/apache/cloudstack/issues/6993
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #6993: Root volume of system vms is being listed
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #6993:
URL: https://github.com/apache/cloudstack/issues/6993#issuecomment-1377246662
@weizhouapache will you filter it for everybody or only for normal users?
It seems valid to see it as an admin, to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org