[GitHub] [pulsar] AnonHxy commented on issue #16680: PIP-191: Support batched message using entry filter

[GitBox <gi...@apache.org>]

AnonHxy commented on issue #16680:
URL: https://github.com/apache/pulsar/issues/16680#issuecomment-1192619832

   > 1) It is not clear to me if you want to push all the messages metadata
   in the main header of the entry or only the metatadata of the first
   entry, or only the KEY.
   
   I just want to copy the partial message properties(we call it batch properties here) to the main header of the entry, without modifying the payload or single message metadata.  All messages in one batch must have the same batch properties (both key and value). 
   
   >  2) we have to clarify the new message format of the entry and update
   the protocol documents
   
   It seems that the protocol documents has not described the batch message main header. It just describes the `SingleMessageMetadata`. I agree with that It's better to update the protocol documents to describe the batch message main header.
   
   > 3) existing EntryFilters won't be able to work well with the new
   format, we must find a way to make them fail and not process garbage
   
   It seems that there is no compatibility problems. Because I just add properties to the main header , which is empty before,  and there is no modification for the payload and single message metadata. The existing EntryFilters can be able to work well with the new
   format, the same as the existing  Protocol Handlers. :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org