[GitHub] [accumulo] cshannon commented on a diff in pull request #3246: WIP - Prototype Ranged RFile Reader

["cshannon (via GitHub)" <gi...@apache.org>]

cshannon commented on code in PR #3246:
URL: https://github.com/apache/accumulo/pull/3246#discussion_r1166778039


##########
core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java:
##########
@@ -1553,4 +1565,256 @@ public void setCacheProvider(CacheProvider cacheProvider) {
       reader.setCacheProvider(cacheProvider);
     }
   }
+
+  public static class RangedReader extends HeapIterator implements RFileReader {

Review Comment:
   Sorry for the delayed response, was side tracked the last couple of weeks with some other things like #3286. #3259 definitely looks like an ideal place to hook into for creating the new ranged iterator as we will have access to the new ranges stored in DataFileValue that will be part of #3286. 
   
   I can also go ahead and update this PR to only implement the InterruptibleIterator and not FileSKVIterator and see how it goes. I had initially used FileSKVIterator as that is what RFile used and I wanted to kind of make it a drop in replacement for a standard RFile and for tests but it doesn't really work to implement it after trying to do that. Most of the methods only make sense for the entire file and not a partial subset of a file, like get/first last key, so there's no good way to implement them. Also it doesn't seem like we need those methods when doing the actual scans/compactions anyways.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org