[jira] [Comment Edited] (MESOS-2873) style hook prevent's valid markdown files from getting committed

["Alexander Rojas (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14596041#comment-14596041 ] 

Alexander Rojas edited comment on MESOS-2873 at 6/22/15 3:36 PM:
-----------------------------------------------------------------

Hey [~marco-mesos], I didn't set it as reviewable, since it wasn't accepted, and AFAIK we have to wait for the Accepted to set it to reviewable. However, I already had a fix. 

I wonder what the standard procedure is then? Hold the patch until it is accepted? publish it and set it to reviewable even if it was never accepted?


was (Author: arojas):
With all due respect [~marco-mesos], I didn't set it as reviewable, since it wasn't accepted. But I already had a fix. Should I then sit down and cry until someone decided to accept it before I either open the ticket or publish the patch?

> style hook prevent's valid markdown files from getting committed
> ----------------------------------------------------------------
>
>                 Key: MESOS-2873
>                 URL: https://issues.apache.org/jira/browse/MESOS-2873
>             Project: Mesos
>          Issue Type: Bug
>            Reporter: Alexander Rojas
>            Assignee: Alexander Rojas
>            Priority: Trivial
>              Labels: mesosphere
>             Fix For: 0.23.0
>
>
> According to the original [markdown specification|http://daringfireball.net/projects/markdown/syntax#p] and to the most [recent standarization|http://spec.commonmark.org/0.20/#hard-line-breaks] effort, two spaces at the end of a line create a hard line break (it breaks the line without starting a new paragraph), similar to the html code {{<br/>}}. 
> However, there's a hook in mesos which prevent files with trailing whitespace to be committed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)