[GitHub] [lucene] dweiss commented on pull request #803: LUCENE-10229: return -1 for unknown offsets in ExtendedIntervalsSource. Modify highlighting to work properly with or without offsets (depending on their availability).

[GitBox <gi...@apache.org>]

dweiss commented on PR #803:
URL: https://github.com/apache/lucene/pull/803#issuecomment-1093720565

   > I think we should always return -1 here? After all, we will always be extending things in at least one direction, so we will never be able to return correct offsets for the whole interval.
   
   I was thinking about it too. I think sometimes you could "correct" the unknown entire expressions you sometimes could compute the correct result, assuming position/offset pairs are correspondingly monotonic (where min/max offsets are computed from sub-intervals). I think it is (now) required that position(a).startOffset <= position(b).startOffset for a < b, right? 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org