You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/02/21 13:58:30 UTC
[GitHub] [lucene-solr] rmuir opened a new pull request #2409: Revert LUCENE-9491 changes for profiling.gradle, they totally break functionality
rmuir opened a new pull request #2409:
URL: https://github.com/apache/lucene-solr/pull/2409
currently in master `tests.profile` gives totally broken output. Reverting the last changes to `profiling.gradle` gets it working again
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] rmuir commented on pull request #2409: Revert LUCENE-9491 changes for profiling.gradle, they totally break functionality
Posted by GitBox <gi...@apache.org>.
rmuir commented on pull request #2409:
URL: https://github.com/apache/lucene-solr/pull/2409#issuecomment-782892686
and pls feel free to just cancel this PR if you know how to fix the real gradle logic issue with master that causes the crazy output... I needed a branch with this thing working to track down LUCENE-9795 perf regression, i figured tracking down the commit is better than just complaining that its broke :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] rmuir closed pull request #2409: Revert LUCENE-9491 changes for profiling.gradle, they totally break functionality
Posted by GitBox <gi...@apache.org>.
rmuir closed pull request #2409:
URL: https://github.com/apache/lucene-solr/pull/2409
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] rmuir commented on pull request #2409: Revert LUCENE-9491 changes for profiling.gradle, they totally break functionality
Posted by GitBox <gi...@apache.org>.
rmuir commented on pull request #2409:
URL: https://github.com/apache/lucene-solr/pull/2409#issuecomment-783873651
I figured out the issue. It is wrong nesting of the `buildFinished()` hook which causes it to run many times. Will toss up a better PR shortly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] rmuir commented on pull request #2409: Revert LUCENE-9491 changes for profiling.gradle, they totally break functionality
Posted by GitBox <gi...@apache.org>.
rmuir commented on pull request #2409:
URL: https://github.com/apache/lucene-solr/pull/2409#issuecomment-782863061
@dweiss i'm not sure what changes broke it here, maybe it was just a typo? I only know i was able to get her running again with a git checkout command :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org