You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicemix.apache.org by "Eoghan Glynn (JIRA)" <ji...@apache.org> on 2009/08/05 15:58:35 UTC

[jira] Created: (SMX4-332) Port SMX4 nmr and features over to karaf

Port SMX4 nmr and features over to karaf
----------------------------------------

                 Key: SMX4-332
                 URL: https://issues.apache.org/activemq/browse/SMX4-332
             Project: ServiceMix 4
          Issue Type: Task
    Affects Versions: 4.1.0
            Reporter: Eoghan Glynn
            Assignee: Eoghan Glynn
             Fix For: 4.1.0


Replace dependencies on the old SMX4 kernel with corresponding dependencies on Karaf. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SMX4-332) Port SMX4 nmr and features over to karaf

Posted by "Chris Custine (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/SMX4-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=53506#action_53506 ] 

Chris Custine commented on SMX4-332:
------------------------------------

Ok, patches applied and both builds are working.  If anyone else wants to check out and review Eoghan's Karaf integration work, here are the URLs.
http://svn.apache.org/repos/asf/servicemix/sandbox/karaf/nmr
http://svn.apache.org/repos/asf/servicemix/sandbox/karaf/features

Build NMR first, then Features.

Thanks to Eoghan Glynn for putting in so much work on this.

> Port SMX4 nmr and features over to karaf
> ----------------------------------------
>
>                 Key: SMX4-332
>                 URL: https://issues.apache.org/activemq/browse/SMX4-332
>             Project: ServiceMix 4
>          Issue Type: Task
>    Affects Versions: 4.1.0
>            Reporter: Eoghan Glynn
>            Assignee: Eoghan Glynn
>             Fix For: 4.1.0
>
>         Attachments: features_patch, nmr_create_patch, nmr_patch, nmr_patch2
>
>
> Replace dependencies on the old SMX4 kernel with corresponding dependencies on Karaf. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (SMX4-332) Port SMX4 nmr and features over to karaf

Posted by "Chris Custine (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SMX4-332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Custine reassigned SMX4-332:
----------------------------------

    Assignee: Chris Custine  (was: Eoghan Glynn)

> Port SMX4 nmr and features over to karaf
> ----------------------------------------
>
>                 Key: SMX4-332
>                 URL: https://issues.apache.org/activemq/browse/SMX4-332
>             Project: ServiceMix 4
>          Issue Type: Task
>    Affects Versions: 4.1.0
>            Reporter: Eoghan Glynn
>            Assignee: Chris Custine
>             Fix For: 4.1.0
>
>         Attachments: features_patch, nmr_create_patch, nmr_patch
>
>
> Replace dependencies on the old SMX4 kernel with corresponding dependencies on Karaf. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Work started: (SMX4-332) Port SMX4 nmr and features over to karaf

Posted by "Eoghan Glynn (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SMX4-332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on SMX4-332 started by Eoghan Glynn.

> Port SMX4 nmr and features over to karaf
> ----------------------------------------
>
>                 Key: SMX4-332
>                 URL: https://issues.apache.org/activemq/browse/SMX4-332
>             Project: ServiceMix 4
>          Issue Type: Task
>    Affects Versions: 4.1.0
>            Reporter: Eoghan Glynn
>            Assignee: Eoghan Glynn
>             Fix For: 4.1.0
>
>
> Replace dependencies on the old SMX4 kernel with corresponding dependencies on Karaf. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SMX4-332) Port SMX4 nmr and features over to karaf

Posted by "Eoghan Glynn (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SMX4-332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eoghan Glynn updated SMX4-332:
------------------------------

    Attachment: features_patch
                nmr_create_patch
                nmr_patch

Can some committer please create an integration branch for nmr and features and commit the attached patches to this branch? 

This will facilitate review and identification of any further work that may be necessary.

The NMR patch is supplied in two versions, the first created using the normal svn diff, the second via the svn-create-patch perl script in case you prefer to apply using svn-apply (this would be more convenient as there are a number of new elements). 



> Port SMX4 nmr and features over to karaf
> ----------------------------------------
>
>                 Key: SMX4-332
>                 URL: https://issues.apache.org/activemq/browse/SMX4-332
>             Project: ServiceMix 4
>          Issue Type: Task
>    Affects Versions: 4.1.0
>            Reporter: Eoghan Glynn
>            Assignee: Eoghan Glynn
>             Fix For: 4.1.0
>
>         Attachments: features_patch, nmr_create_patch, nmr_patch
>
>
> Replace dependencies on the old SMX4 kernel with corresponding dependencies on Karaf. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SMX4-332) Port SMX4 nmr and features over to karaf

Posted by "Chris Custine (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SMX4-332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Custine resolved SMX4-332.
--------------------------------

    Fix Version/s: 4.2.0
                       (was: 4.4.0)
       Resolution: Fixed

> Port SMX4 nmr and features over to karaf
> ----------------------------------------
>
>                 Key: SMX4-332
>                 URL: https://issues.apache.org/activemq/browse/SMX4-332
>             Project: ServiceMix 4
>          Issue Type: Task
>    Affects Versions: 4.2.0
>            Reporter: Eoghan Glynn
>            Assignee: Eoghan Glynn
>             Fix For: 4.2.0
>
>         Attachments: features_patch, nmr_create_patch, nmr_patch, nmr_patch2
>
>
> Replace dependencies on the old SMX4 kernel with corresponding dependencies on Karaf. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SMX4-332) Port SMX4 nmr and features over to karaf

Posted by "Eoghan Glynn (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SMX4-332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eoghan Glynn updated SMX4-332:
------------------------------

    Attachment: nmr_patch2

Thanks Chris,

I missed a few files in that first NMR patch, so I've attached another for you to apply (nmr_patch2). 

BTW the first nmr_patch and nmr_create_patch were intended to be either-or-but-not-both (depending on your preference for applying via the patch command or the svn-apply script).

All should build once the latest patch is applied, though I've seen some flakiness in the assembly phase (may be environment-specific).

While looking into this, I notice there are still dependencies in some of the META-INF/Spring configs on the old kernel-style gshell, so I'll have to figure out how to replace this with the Karaf-specific NamespaceHandler for command-bundles etc.  This looks blueprint-specific in Karaf, as opposed to the Spring BeanDefinitionParser-based mechanism in kernel.

This raises the general question of co-existance with Karaf's usage of blueprint service. IIRC Guillaume intended that co-existance with Spring-DM would be supported in Karaf, I just need confirmation that this is indeed the case and do the appropriate testing. In the longer term , I guess the goal would be to switch NMR and features over to blueprint also?

> Port SMX4 nmr and features over to karaf
> ----------------------------------------
>
>                 Key: SMX4-332
>                 URL: https://issues.apache.org/activemq/browse/SMX4-332
>             Project: ServiceMix 4
>          Issue Type: Task
>    Affects Versions: 4.1.0
>            Reporter: Eoghan Glynn
>            Assignee: Eoghan Glynn
>             Fix For: 4.1.0
>
>         Attachments: features_patch, nmr_create_patch, nmr_patch, nmr_patch2
>
>
> Replace dependencies on the old SMX4 kernel with corresponding dependencies on Karaf. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (SMX4-332) Port SMX4 nmr and features over to karaf

Posted by "Eoghan Glynn (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/SMX4-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=53476#action_53476 ] 

Eoghan Glynn edited comment on SMX4-332 at 8/5/09 7:09 AM:
-----------------------------------------------------------

Can some committer please create an integration branch for nmr and features and commit the attached patches to this branch? 

This will facilitate review and identification of any further work that may be necessary.

The NMR patch is supplied in two versions, the first (nmr_patch) created using the normal svn diff, the second (nmr_create_patch) created via the svn-create-patch perl script in case you prefer to apply using svn-apply - this would be more convenient as there are a number of new elements. 



      was (Author: eglynn):
    Can some committer please create an integration branch for nmr and features and commit the attached patches to this branch? 

This will facilitate review and identification of any further work that may be necessary.

The NMR patch is supplied in two versions, the first created using the normal svn diff, the second via the svn-create-patch perl script in case you prefer to apply using svn-apply (this would be more convenient as there are a number of new elements). 


  
> Port SMX4 nmr and features over to karaf
> ----------------------------------------
>
>                 Key: SMX4-332
>                 URL: https://issues.apache.org/activemq/browse/SMX4-332
>             Project: ServiceMix 4
>          Issue Type: Task
>    Affects Versions: 4.1.0
>            Reporter: Eoghan Glynn
>            Assignee: Eoghan Glynn
>             Fix For: 4.1.0
>
>         Attachments: features_patch, nmr_create_patch, nmr_patch
>
>
> Replace dependencies on the old SMX4 kernel with corresponding dependencies on Karaf. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SMX4-332) Port SMX4 nmr and features over to karaf

Posted by "Eoghan Glynn (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/SMX4-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=53477#action_53477 ] 

Eoghan Glynn commented on SMX4-332:
-----------------------------------

>From the dev list:

"As I mentioned on another thread, there was a problematic dependency between the NMR/features integration tests and the old kernel AbstractIntegrationTest framework. After discussing this issue with Guillaume last week, I took the pragmatic approach of moving a cut-down version of the testing support into the NMR repo. The problematic tests are now passing."


> Port SMX4 nmr and features over to karaf
> ----------------------------------------
>
>                 Key: SMX4-332
>                 URL: https://issues.apache.org/activemq/browse/SMX4-332
>             Project: ServiceMix 4
>          Issue Type: Task
>    Affects Versions: 4.1.0
>            Reporter: Eoghan Glynn
>            Assignee: Eoghan Glynn
>             Fix For: 4.1.0
>
>         Attachments: features_patch, nmr_create_patch, nmr_patch
>
>
> Replace dependencies on the old SMX4 kernel with corresponding dependencies on Karaf. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SMX4-332) Port SMX4 nmr and features over to karaf

Posted by "Chris Custine (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SMX4-332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Custine updated SMX4-332:
-------------------------------

    Assignee: Eoghan Glynn  (was: Chris Custine)

> Port SMX4 nmr and features over to karaf
> ----------------------------------------
>
>                 Key: SMX4-332
>                 URL: https://issues.apache.org/activemq/browse/SMX4-332
>             Project: ServiceMix 4
>          Issue Type: Task
>    Affects Versions: 4.1.0
>            Reporter: Eoghan Glynn
>            Assignee: Eoghan Glynn
>             Fix For: 4.1.0
>
>         Attachments: features_patch, nmr_create_patch, nmr_patch
>
>
> Replace dependencies on the old SMX4 kernel with corresponding dependencies on Karaf. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SMX4-332) Port SMX4 nmr and features over to karaf

Posted by "Chris Custine (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SMX4-332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Custine updated SMX4-332:
-------------------------------

    Fix Version/s: 4.4.0
                       (was: 4.2.0)

> Port SMX4 nmr and features over to karaf
> ----------------------------------------
>
>                 Key: SMX4-332
>                 URL: https://issues.apache.org/activemq/browse/SMX4-332
>             Project: ServiceMix 4
>          Issue Type: Task
>    Affects Versions: 4.2.0
>            Reporter: Eoghan Glynn
>            Assignee: Eoghan Glynn
>             Fix For: 4.4.0
>
>         Attachments: features_patch, nmr_create_patch, nmr_patch, nmr_patch2
>
>
> Replace dependencies on the old SMX4 kernel with corresponding dependencies on Karaf. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SMX4-332) Port SMX4 nmr and features over to karaf

Posted by "Chris Custine (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/SMX4-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=53488#action_53488 ] 

Chris Custine commented on SMX4-332:
------------------------------------

I created branches for NMR and Features in the sandbox here: https://svn.apache.org/repos/asf/servicemix/sandbox/karaf/ Both branches are from trunk as of tonight.

I applied the patches (I had trouble with the nmr_create_patch, it looks like it might be corrupt), but neither project compiles so I hope that was expected.  If there is something wrong I can easily do this over again so let me know if this should have been compiling.

> Port SMX4 nmr and features over to karaf
> ----------------------------------------
>
>                 Key: SMX4-332
>                 URL: https://issues.apache.org/activemq/browse/SMX4-332
>             Project: ServiceMix 4
>          Issue Type: Task
>    Affects Versions: 4.1.0
>            Reporter: Eoghan Glynn
>            Assignee: Eoghan Glynn
>             Fix For: 4.1.0
>
>         Attachments: features_patch, nmr_create_patch, nmr_patch
>
>
> Replace dependencies on the old SMX4 kernel with corresponding dependencies on Karaf. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.