You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/09/11 07:41:34 UTC

Review Request: Added a numify(const Option&) variant.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7006/
-----------------------------------------------------------

Review request for mesos and Ben Mahler.


Description
-------

See summary.


Diffs
-----

  src/master/slaves_manager.cpp 7a3f110 
  third_party/libprocess/include/stout/numify.hpp e13d710 

Diff: https://reviews.apache.org/r/7006/diff/


Testing
-------

make check


Thanks,

Benjamin Hindman

Re: Review Request: Added a numify(const Option&) variant.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7006/#review11314
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On Sept. 11, 2012, 5:41 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7006/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2012, 5:41 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/slaves_manager.cpp 7a3f110 
>   third_party/libprocess/include/stout/numify.hpp e13d710 
> 
> Diff: https://reviews.apache.org/r/7006/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Re: Review Request: Added a numify(const Option&) variant.

Posted by Benjamin Hindman <be...@berkeley.edu>.

> On Sept. 11, 2012, 5:43 p.m., Ben Mahler wrote:
> > looks great, feel free to change offset/length parsing in FilesProcess::read as well :)

Let's do that in another review. Thanks for taking a look!


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7006/#review11337
-----------------------------------------------------------


On Sept. 11, 2012, 5:41 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7006/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2012, 5:41 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/slaves_manager.cpp 7a3f110 
>   third_party/libprocess/include/stout/numify.hpp e13d710 
> 
> Diff: https://reviews.apache.org/r/7006/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Re: Review Request: Added a numify(const Option&) variant.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7006/#review11337
-----------------------------------------------------------


looks great, feel free to change offset/length parsing in FilesProcess::read as well :)


src/master/slaves_manager.cpp
<https://reviews.apache.org/r/7006/#comment24367>

    pass in the error string directly?



src/master/slaves_manager.cpp
<https://reviews.apache.org/r/7006/#comment24368>

    ditto



src/master/slaves_manager.cpp
<https://reviews.apache.org/r/7006/#comment24369>

    ditto



src/master/slaves_manager.cpp
<https://reviews.apache.org/r/7006/#comment24370>

    ditto



src/master/slaves_manager.cpp
<https://reviews.apache.org/r/7006/#comment24371>

    ditto



src/master/slaves_manager.cpp
<https://reviews.apache.org/r/7006/#comment24372>

    ditto



src/master/slaves_manager.cpp
<https://reviews.apache.org/r/7006/#comment24373>

    ditto



src/master/slaves_manager.cpp
<https://reviews.apache.org/r/7006/#comment24374>

    ditto



src/master/slaves_manager.cpp
<https://reviews.apache.org/r/7006/#comment24375>

    ditto



src/master/slaves_manager.cpp
<https://reviews.apache.org/r/7006/#comment24361>

    ditto



src/master/slaves_manager.cpp
<https://reviews.apache.org/r/7006/#comment24366>

    too bad we don't have tests for this stuff :)



src/master/slaves_manager.cpp
<https://reviews.apache.org/r/7006/#comment24364>

    ditto



src/master/slaves_manager.cpp
<https://reviews.apache.org/r/7006/#comment24365>

    ditto


- Ben Mahler


On Sept. 11, 2012, 5:41 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7006/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2012, 5:41 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/slaves_manager.cpp 7a3f110 
>   third_party/libprocess/include/stout/numify.hpp e13d710 
> 
> Diff: https://reviews.apache.org/r/7006/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>