You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2006/01/03 23:06:03 UTC
DO NOT REPLY [Bug 38113] New: - getQueryString returns null instead of empty-string
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38113>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38113
Summary: getQueryString returns null instead of empty-string
Product: Tomcat 5
Version: 5.5.12
Platform: All
OS/Version: other
Status: NEW
Severity: normal
Priority: P2
Component: Catalina
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: djacobs@modelobjects.com
The method getQueryString in class org.apache.catalina.connector.Request returns
null, instead of an empty string for a URL of the form http://foo/bar? as
required by the specification. A correct implementation of the method is as
follows:
/**
* Return the query string associated with this request.
*/
public String getQueryString() {
Object qStrObj = coyoteRequest.queryString();
return ((qStrObj == null) ? null : qStrObj.toString());
}
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 38113] - getQueryString returns null instead of empty-string
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38113>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38113
william.barker@wilshire.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From william.barker@wilshire.com 2006-03-04 03:59 -------
This is fixed in the SVN trunk, and will appear in 5.5.16
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 38113] - getQueryString returns null instead of empty-string
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38113>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38113
Michiel.Meeuwissen@omroep.nl changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |
------- Additional Comments From Michiel.Meeuwissen@omroep.nl 2006-03-28 19:23 -------
(In reply to comment #1)
> This is fixed in the SVN trunk, and will appear in 5.5.16
The fix is not correct.
Following jsp:
<jsp:expression>"" + request.getQueryString()</jsp:expression>
does not write 'null' to the page, even if not question mark on the url.
While javadoc of HttpServletRequest#getQueryString states:
public java.lang.String getQueryString()
Returns the query string that is contained in the request URL after the
path. This method returns null if the URL does not have a query string. Same as
the value of the CGI variable QUERY_STRING.
------- Additional Comments From cowwoc@bbs.darktech.org 2006-03-29 19:54 -------
(Sorry if this results in a duplicate post, BugZilla seems to be very flacky
today and commiting comments does not seem to work)
I agree. This "fix" breaks webapps: JForum, and maybe others.
The original assumption behind this change was incorrect, the specification
clearly states that getQueryString() *should* return null, not an empty string.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 38113] - getQueryString returns null instead of empty-string
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38113>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38113
remm@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution| |WONTFIX
------- Additional Comments From remm@apache.org 2006-03-30 18:46 -------
Ok, so I reverted the fix.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 38113] - getQueryString returns null instead of empty-string
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38113>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38113
cowwoc@bbs.darktech.org changed:
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO| |39130
nThis| |
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 38113] - getQueryString returns null instead of empty-string
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38113>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38113
------- Additional Comments From remm@apache.org 2006-03-29 23:50 -------
(In reply to comment #3)
> I agree. This "fix" breaks webapps: JForum, and maybe others.
>
> The original assumption behind this change was incorrect, the specification
> clearly states that getQueryString() *should* return null, not an empty string.
Most likely, this will be the one and only time I agree with you on something.
http://foo/bar? means there's no query String -> it should most likely return
null anyway (and if it shouldn't, it's not actually specified anywhere).
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org