[GitHub] [arrow-datafusion] alamb commented on a change in pull request #334: Add window expr

[GitBox <gi...@apache.org>]

alamb commented on a change in pull request #334:
URL: https://github.com/apache/arrow-datafusion/pull/334#discussion_r632720978



##########
File path: datafusion/src/logical_plan/builder.rs
##########
@@ -289,6 +289,14 @@ impl LogicalPlanBuilder {
         }))
     }
 
+    pub fn window(
+        &self,
+        group_expr: impl IntoIterator<Item = Expr>,
+        aggr_expr: impl IntoIterator<Item = Expr>,

Review comment:
       would eventually need sort_exprs too to handle the various window clauses
   
   Maybe worth taking a peek at how the `sqlparser` crate structures things so the API on the builder is "future proof" (aka we don't have to break backwards compatibility when we add support for non empty over clause)
   
   https://github.com/ballista-compute/sqlparser-rs/blob/35ef0eee3857c59827b2587bc813218a00dce264/src/ast/mod.rs#L372-L376




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org