You are viewing a plain text version of this content. The canonical link for it is here.
Posted to rivet-dev@tcl.apache.org by Massimo Manghi <ma...@unipr.it> on 2007/09/18 00:04:04 UTC
more patches for rivet
Hi everybody
Valery Matsiutsin and I have been working for a
while on the build system of Rivet to fix a few
things that made difficult to compile Rivet,
expecially for apache 2.
Valery contributed new variables and code
in configure.ac and in the hirarchy of
the Makefile.am files. I think this is making
the whole building process smoother and more
robust. I made myself some changes and bugfixes
to configure.ac and made some small changes to
code for the apache 1 module.
1. configure.ac: TEA_INIT argument was changed
to 3.6 to match the TEA version in
the new tcl.m4. Macro for --with-apache was
simplified. Macro for --with-apxs changed
in order to check for possible multiple
version of apxs installed.
Defined compilation parameters generated by apxs.
Same for apr-1-config that returns compilation
parameters for apr.
2. Makefile.am src/Makefile.am src/apache-[12]/Makefile.am:
changed to handle new symbols and parameters
3. src/apache-1/mod_rivet.[hc] rivet version logging enabled.
I enabled this to check if I was loading the expected module
but maybe can be used to generate, at least for the code in
trunk, more refined version numbers to be used in the
development cycle.
I also modified src/rivetCore.c to register the rivetWWW
module commands. Initialization for this (and also for the
Crypt and List modules) was in rivetPkgInit.c, but the
functions in this module were never called by mod_rivet.c.
This makes the whole set of documented commands available
to rivet scripts (a thread about this was discussed
in december 2006). I'm not sending this patch because
it seems to me more important to integrate the whole
set of commands in librivet, as rivetPkgInit.c was meant
to do.
regards
-- Massimo
Re: more patches for rivet
Posted by Massimo Manghi <ma...@unipr.it>.
Sorry David, I read your suggestion about sending
small patches as inline text after I sent this.
-- M
Massimo Manghi wrote:
>
>>
> ok if you want me to do it. I think this patch should be a temporary
> workaround to get rivetWWW.c commands into the interpreter.
>
> -- M
> ------------------------------------------------------------------------
>
> Index: rivetCore.c
> ===================================================================
> --- rivetCore.c (revision 574878)
> +++ rivetCore.c (working copy)
> @@ -995,5 +995,12 @@
> TCL_OBJ_CMD( "abort_page", Rivet_AbortPageCmd );
> TCL_OBJ_CMD( "virtual_filename", Rivet_VirtualFilenameCmd );
>
> +/*
> + * Temporary workaround to inizialize the commands
> + * in rivetWWW.c
> + */
> +
> + Rivet_InitWWW( interp );
> +
> return TCL_OK;
> }
>
>
> ------------------------------------------------------------------------
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.apache.org
> For additional commands, e-mail: rivet-dev-help@tcl.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.apache.org
For additional commands, e-mail: rivet-dev-help@tcl.apache.org
Re: more patches for rivet
Posted by Massimo Manghi <ma...@unipr.it>.
Valery Masiutsin wrote:
> Hello, lads !
>
> I am at the process of reviewing this stuff, i am going to change a bit
> CHECK_APXS function. But it is not critical. One more bit is still missing,
> Massimo, would you like to post your changes to rivetCore.c ? Once
> we'll see them and if they break nothing, go ahead and commit the
> stuff.
>
> Regards, Valery
>
>
>
ok if you want me to do it. I think this patch should be a temporary
workaround to get rivetWWW.c commands into the interpreter.
-- M
Re: more patches for rivet
Posted by Valery Masiutsin <va...@gmail.com>.
Hello, lads !
I am at the process of reviewing this stuff, i am going to change a bit
CHECK_APXS function. But it is not critical. One more bit is still missing,
Massimo, would you like to post your changes to rivetCore.c ? Once
we'll see them and if they break nothing, go ahead and commit the
stuff.
Regards, Valery
---------------------------------------------------------------------
To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.apache.org
For additional commands, e-mail: rivet-dev-help@tcl.apache.org
Re: more patches for rivet
Posted by Massimo Manghi <ma...@unipr.it>.
David Welton wrote:
>> svn: MKACTIVITY of '/repos/asf/!svn/act/5ad899cc-883a-4609-bf57-9362e65411d4':
>> 403 Forbidden (https://svn.apache.org)
>>
>> and found out that this problem is common for the apache
>> committers. A thread in the developers list of a project
>> called 'tuscany' doesn't explain why but suggest that
>> some people (project managers?) can or even must do
>> something to enable a commiter. Check this 3 message long
>> thread
>>
>> http://www.mail-archive.com/tuscany-dev@ws.apache.org/msg19286.html
>>
>
> Oops, my fault - sorry about that, but it's been a while since we've
> added anyone - try now.
>
>
>
it's ok now , the commit succeeded. Thank you.
-- Massimo
---------------------------------------------------------------------
To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.apache.org
For additional commands, e-mail: rivet-dev-help@tcl.apache.org
Re: more patches for rivet
Posted by David Welton <da...@gmail.com>.
> svn: MKACTIVITY of '/repos/asf/!svn/act/5ad899cc-883a-4609-bf57-9362e65411d4':
> 403 Forbidden (https://svn.apache.org)
>
> and found out that this problem is common for the apache
> committers. A thread in the developers list of a project
> called 'tuscany' doesn't explain why but suggest that
> some people (project managers?) can or even must do
> something to enable a commiter. Check this 3 message long
> thread
>
> http://www.mail-archive.com/tuscany-dev@ws.apache.org/msg19286.html
Oops, my fault - sorry about that, but it's been a while since we've
added anyone - try now.
--
David N. Welton
http://www.welton.it/davidw/
---------------------------------------------------------------------
To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.apache.org
For additional commands, e-mail: rivet-dev-help@tcl.apache.org
Re: more patches for rivet
Posted by Massimo Manghi <ma...@unipr.it>.
I can't commit because I'm forbidden to do so.
Before you ask: ** my working copy was checked out
with https **, so it's not that simple. I googled
part of the error message
svn: MKACTIVITY of '/repos/asf/!svn/act/5ad899cc-883a-4609-bf57-9362e65411d4':
403 Forbidden (https://svn.apache.org)
and found out that this problem is common for the apache
committers. A thread in the developers list of a project
called 'tuscany' doesn't explain why but suggest that
some people (project managers?) can or even must do
something to enable a commiter. Check this 3 message long
thread
http://www.mail-archive.com/tuscany-dev@ws.apache.org/msg19286.html
-- Massimo
On Tue, 18 Sep 2007 19:17:23 +0200, David Welton wrote
> > I'm going to commit soon. David, do you think that
> > the version of the docs in 1_0 can be merged with that in
> > trunk? For what I know there is no 1_0 specific documentation
> > there.
>
> Going from 1_0 to trunk is generally ok as long as it's not reverting
> something. Be more careful about moving something from trunk to 1_0,
> as 1_0 ought to be more or less 'releasable'.
>
> --
> David N. Welton
> http://www.welton.it/davidw/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.apache.org
> For additional commands, e-mail: rivet-dev-help@tcl.apache.org
--
Universita' degli Studi di Parma (http://www.unipr.it)
---------------------------------------------------------------------
To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.apache.org
For additional commands, e-mail: rivet-dev-help@tcl.apache.org
Re: more patches for rivet
Posted by David Welton <da...@gmail.com>.
> I'm going to commit soon. David, do you think that
> the version of the docs in 1_0 can be merged with that in
> trunk? For what I know there is no 1_0 specific documentation
> there.
Going from 1_0 to trunk is generally ok as long as it's not reverting
something. Be more careful about moving something from trunk to 1_0,
as 1_0 ought to be more or less 'releasable'.
--
David N. Welton
http://www.welton.it/davidw/
---------------------------------------------------------------------
To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.apache.org
For additional commands, e-mail: rivet-dev-help@tcl.apache.org
Re: more patches for rivet
Posted by Massimo Manghi <ma...@unipr.it>.
David Welton wrote:
> I'm generally ok with this stuff, as long as it works for you, go
> ahead and commit it.
>
> BTW, for small patches, posting them inline is perhaps better, if
> you're only putting them up for review (since you have commit access).
>
> Valery, did you try this, or do you want to just wait until they've
> been committed?
>
>
I'm going to commit soon. David, do you think that
the version of the docs in 1_0 can be merged with that in
trunk? For what I know there is no 1_0 specific documentation
there.
-- Massimo
---------------------------------------------------------------------
To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.apache.org
For additional commands, e-mail: rivet-dev-help@tcl.apache.org
Re: more patches for rivet
Posted by David Welton <da...@gmail.com>.
> Valery contributed new variables and code
> in configure.ac and in the hirarchy of
> the Makefile.am files. I think this is making
> the whole building process smoother and more
> robust. I made myself some changes and bugfixes
> to configure.ac and made some small changes to
> code for the apache 1 module.
I'm generally ok with this stuff, as long as it works for you, go
ahead and commit it.
BTW, for small patches, posting them inline is perhaps better, if
you're only putting them up for review (since you have commit access).
Valery, did you try this, or do you want to just wait until they've
been committed?
--
David N. Welton
http://www.welton.it/davidw/
---------------------------------------------------------------------
To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.apache.org
For additional commands, e-mail: rivet-dev-help@tcl.apache.org