You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/04/17 09:38:03 UTC

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #40820: [MINOR] Improve spark.sql.files.minPartitionNum's doc

HyukjinKwon commented on code in PR #40820:
URL: https://github.com/apache/spark/pull/40820#discussion_r1168433154


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -1740,8 +1740,10 @@ object SQLConf {
 
   val FILES_MIN_PARTITION_NUM = buildConf("spark.sql.files.minPartitionNum")
     .doc("The suggested (not guaranteed) minimum number of split file partitions. " +
-      "If not set, the default value is `spark.default.parallelism`. This configuration is " +
-      "effective only when using file-based sources such as Parquet, JSON and ORC.")

Review Comment:
   I think you can just simply replace `spark.default.parallelism` to `spark.sql.leafNodeDefaultParallelism`. If users are interested in, they will read `spark.sql.leafNodeDefaultParallelism`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org