You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Ryota Egashira <eg...@yahoo-inc.com> on 2015/04/15 17:02:17 UTC
Review Request 33221: OOZIE-2205 add option to load default/site.xml
to actionConf on compute node
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33221/
-----------------------------------------------------------
Review request for oozie.
Repository: oozie-git
Description
-------
https://issues.apache.org/jira/browse/OOZIE-2205
Diffs
-----
core/src/main/java/org/apache/oozie/action/hadoop/Hive2ActionExecutor.java 704b762
core/src/main/java/org/apache/oozie/action/hadoop/HiveActionExecutor.java dbb50ba
core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java cf22ed6
core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java 4d6a1b4
core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java 18de48a
core/src/main/resources/oozie-default.xml 3936fca
sharelib/hive/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java c28839c
sharelib/hive2/src/test/java/org/apache/oozie/action/hadoop/TestHive2ActionExecutor.java 16d0267
sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java 039bd84
Diff: https://reviews.apache.org/r/33221/diff/
Testing
-------
tested on real cluster.
Thanks,
Ryota Egashira
Re: Review Request 33221: OOZIE-2205 add option to load
default/site.xml to actionConf on compute node
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33221/#review80380
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/action/hadoop/Hive2ActionExecutor.java
<https://reviews.apache.org/r/33221/#comment130268>
I am not sure what is the behaviour as script execution is on Hive server 2 and removing them will not impact Hive server execution, but might impact connecting to hive server 2. Unless you can setup one and test the patch, please remove the code for hive server 2 action.
core/src/main/java/org/apache/oozie/action/hadoop/HiveActionExecutor.java
<https://reviews.apache.org/r/33221/#comment130262>
loadHadoopDefaultResources
core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
<https://reviews.apache.org/r/33221/#comment130257>
loadDefaultResources
core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java
<https://reviews.apache.org/r/33221/#comment130258>
ACTION_CONFS_LOAD_DEFAULT_RESOURCES = ACTION_CONFS + ".load.default.resources";
core/src/main/resources/oozie-default.xml
<https://reviews.apache.org/r/33221/#comment130260>
true means that default and site xml files of hadoop (core-default, core-site, hdfs-default, hdfs-site, mapred-default, mapred-site, yarn-default, yarn-site) ....
false means that site xml files are not loaded on server, instead loaded on launcher node. This is only done for pig and hive actions which handle loading those files automatically from the classpath on launcher task.
Please capitalize
- Oozie server
- It defaults to
sharelib/hive/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java
<https://reviews.apache.org/r/33221/#comment130263>
testActionConfLoadDefaultResources . Same in pig test.
sharelib/hive/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java
<https://reviews.apache.org/r/33221/#comment130266>
a is not used anywhere
- Rohini Palaniswamy
On April 15, 2015, 3:02 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33221/
> -----------------------------------------------------------
>
> (Updated April 15, 2015, 3:02 p.m.)
>
>
> Review request for oozie.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-2205
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/hadoop/Hive2ActionExecutor.java 704b762
> core/src/main/java/org/apache/oozie/action/hadoop/HiveActionExecutor.java dbb50ba
> core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java cf22ed6
> core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java 4d6a1b4
> core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java 18de48a
> core/src/main/resources/oozie-default.xml 3936fca
> sharelib/hive/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java c28839c
> sharelib/hive2/src/test/java/org/apache/oozie/action/hadoop/TestHive2ActionExecutor.java 16d0267
> sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java 039bd84
>
> Diff: https://reviews.apache.org/r/33221/diff/
>
>
> Testing
> -------
>
> tested on real cluster.
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request 33221: OOZIE-2205 add option to load
default/site.xml to actionConf on compute node
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33221/#review80524
-----------------------------------------------------------
Ship it!
Please do the minor variable renames before checking in.
core/src/main/java/org/apache/oozie/action/hadoop/HiveActionExecutor.java
<https://reviews.apache.org/r/33221/#comment130501>
Can you rename loadOnTask to loadDefaultResources and ACTION_CONFS_LOAD to ACTION_CONFS_LOAD_DEFAULT_RESOURCES?
core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java
<https://reviews.apache.org/r/33221/#comment130500>
Can you rename loadOnTask to loadDefaultResources and ACTION_CONFS_LOAD to ACTION_CONFS_LOAD_DEFAULT_RESOURCES?
- Rohini Palaniswamy
On April 17, 2015, 5:56 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33221/
> -----------------------------------------------------------
>
> (Updated April 17, 2015, 5:56 p.m.)
>
>
> Review request for oozie.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-2205
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/hadoop/HiveActionExecutor.java dbb50ba
> core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java cf22ed6
> core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java 4d6a1b4
> core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java 18de48a
> core/src/main/resources/oozie-default.xml 3936fca
> sharelib/hive/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java c28839c
> sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java 039bd84
>
> Diff: https://reviews.apache.org/r/33221/diff/
>
>
> Testing
> -------
>
> tested on real cluster.
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request 33221: OOZIE-2205 add option to load
default/site.xml to actionConf on compute node
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33221/
-----------------------------------------------------------
(Updated April 17, 2015, 5:56 p.m.)
Review request for oozie.
Changes
-------
uploaded wrong version previously, this is correct one
Repository: oozie-git
Description
-------
https://issues.apache.org/jira/browse/OOZIE-2205
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/action/hadoop/HiveActionExecutor.java dbb50ba
core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java cf22ed6
core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java 4d6a1b4
core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java 18de48a
core/src/main/resources/oozie-default.xml 3936fca
sharelib/hive/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java c28839c
sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java 039bd84
Diff: https://reviews.apache.org/r/33221/diff/
Testing
-------
tested on real cluster.
Thanks,
Ryota Egashira
Re: Review Request 33221: OOZIE-2205 add option to load
default/site.xml to actionConf on compute node
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33221/
-----------------------------------------------------------
(Updated April 17, 2015, 5:37 p.m.)
Review request for oozie.
Changes
-------
revised
Repository: oozie-git
Description
-------
https://issues.apache.org/jira/browse/OOZIE-2205
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/action/hadoop/HiveActionExecutor.java dbb50ba
core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java cf22ed6
core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java 4d6a1b4
core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java 18de48a
core/src/main/resources/oozie-default.xml 3936fca
sharelib/hive/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java c28839c
sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java 039bd84
Diff: https://reviews.apache.org/r/33221/diff/
Testing
-------
tested on real cluster.
Thanks,
Ryota Egashira