[GitHub] [apisix] spacewander commented on a change in pull request #2769: feat: enable access log or not

[GitBox <gi...@apache.org>]

spacewander commented on a change in pull request #2769:
URL: https://github.com/apache/apisix/pull/2769#discussion_r528635411



##########
File path: .travis/apisix_cli_test.sh
##########
@@ -391,6 +391,52 @@ fi
 
 git checkout conf/config.yaml
 
+echo '
+nginx_config:
+  http:
+    enable_access_log: true
+    access_log_format: "$remote_addr - $remote_user [$time_local] $http_host test_enable_access_log"
+' > conf/config.yaml
+
+make init
+
+grep "test_enable_access_log" conf/nginx.conf > /dev/null
+if [ ! $? -eq 0 ]; then
+    echo "failed: nginx.conf file doesn't find access_log_format when enable access log"
+    exit 1
+fi
+
+grep "access_log off;" conf/nginx.conf > /dev/null
+if [ $? -eq 0 ]; then
+    echo "failed: nginx.conf file find access_log off; when enable access log"
+    exit 1
+fi
+
+git checkout conf/config.yaml

Review comment:
       ditto

##########
File path: .travis/apisix_cli_test.sh
##########
@@ -391,6 +391,52 @@ fi
 
 git checkout conf/config.yaml

Review comment:
       We don't need to checkout in the middle of a group of test, as we will change it later.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org