You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2022/12/13 09:34:43 UTC

[GitHub] [hadoop] pranavsaxena-microsoft commented on pull request #5198: HADOOP-18546. Followup: ITestReadBufferManager fix

pranavsaxena-microsoft commented on PR #5198:
URL: https://github.com/apache/hadoop/pull/5198#issuecomment-1348053381

   > not happy about javadoc failures, but looks unrelated (annotation issues? javadoc changes?).
   > 
   > going to approve this myself because it's only a test change, and the change is just removing some flaky asserts plus the fix from @pranavsaxena-microsoft . If I'd checked out the PR and tested locally before the merge i would have just included them in the original commit.
   > 
   > +1
   
   Hi @steveloughran , Thanks a lot for the PR. Related to javadocs failure, it seems that it is bit inconsistent. Sometimes it fails and then back-merging the trunk, the test passes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org