[jira] [Commented] (LUCENE-3167) Make lucene/solr a OSGI bundle through Ant

["Steven Rowe (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-3167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13081632#comment-13081632 ] 

Steven Rowe commented on LUCENE-3167:
-------------------------------------

Hi Luca,

I downloaded the bnd jar and applied your patch, then ran {{ant jar-core}} under {{lucene/}}.  This produced a jar, and didn't seem too awfully slow.  The generated {{MANIFEST.MF}} looks mostly okay - see below for some issues.

Can you do some timings with and without the OSGI stuff for creating jars?  If it doesn't take much extra time to produce the OSGi-compatible manifests, I think it would be okay to always produce them.

Your patch doesn't have any special handling for Solr's war file manifest - does OSGi care about war files?  (I know nothing about OSGi.)

The bnd jar is Apache licensed, so we can put it into our repository, rather than require people to download the jar.  You can see an example of this in {{lucene/build.xml}} and {{lucene/common-build.xml}} with the Maven Ant Tasks jar - take a look at the definitions of the {{generate-maven-artifacts}} target and the {{maven-ant-tasks.classpath}} path.

Some stuff that needs to be addressed before this can be committed:

# You didn't check the box to grant the Apache license to your most recent patch; we can't commit your work unless you do this.
# Please follow the patch naming convention when you name patches; e.g. for this issue, the patch should be named {{LUCENE-3167.patch}}.  See http://wiki.apache.org/lucene-java/HowToContribute#Creating_a_patch for more info.
# Solr's manifests are built twice - the {{jarify}} macro invokes the {{build-manifest}} macro.  The {{jarify}} macro may need more parameters to be able to handle both Solr and Lucene needs.
# In the generated {{MANIFEST.MF}}, the {{Bundle-Description}} value is not interpolated properly - here's what I get: {{Bundle-Description: $\{bnd.project.description\}}}
# In the generated {{MANIFEST.MF}}, {{DSTAMP}}, {{TSTAMP}}, and {{TODAY}} each have entries, but they don't appear in the {{lucene.bnd}} template - if possible, these should be eliminated.
# In {{lucene.bnd}}, you have excluded {{$\{user.name\}}} from the {{Implementation-Version}} value - please re-sync with the unpatched value.
# In {{lucene.bnd}}, should {{Bundle-DocUR}} be {{Bundle-DocURL}}?


> Make lucene/solr a OSGI bundle through Ant
> ------------------------------------------
>
>                 Key: LUCENE-3167
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3167
>             Project: Lucene - Java
>          Issue Type: New Feature
>         Environment: bndtools
>            Reporter: Luca Stancapiano
>         Attachments: lucene_trunk.patch, lucene_trunk.patch
>
>
> We need to make a bundle thriugh Ant, so the binary can be published and no more need the download of the sources. Actually to get a OSGI bundle we need to use maven tools and build the sources. Here the reference for the creation of the OSGI bundle through Maven:
> https://issues.apache.org/jira/browse/LUCENE-1344
> Bndtools could be used inside Ant

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org